diff --git a/.idea/jarRepositories.xml b/.idea/jarRepositories.xml
index a5f05cd..ac86a16 100644
--- a/.idea/jarRepositories.xml
+++ b/.idea/jarRepositories.xml
@@ -21,5 +21,10 @@
+
+
+
+
+
\ No newline at end of file
diff --git a/LICENSE.TXT b/LICENSE.TXT
index 2fadd27..4b28e4e 100644
--- a/LICENSE.TXT
+++ b/LICENSE.TXT
@@ -1,4 +1,4 @@
-Copyright (c) 2020, Erik C. Thauvin (erik@thauvin.net)
+Copyright (c) 2011-2020, Erik C. Thauvin (erik@thauvin.net)
All rights reserved.
Redistribution and use in source and binary forms, with or without
diff --git a/app/build.gradle b/app/build.gradle
index 373dab9..ace6427 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -27,7 +27,7 @@ dependencies {
//implementation 'androidx.appcompat:appcompat:1.1.0'
//implementation 'androidx.preference:preference:1.1.1'
- implementation 'net.thauvin.erik:bitly-shorten:0.9.2'
+ implementation 'net.thauvin.erik:bitly-shorten:0.9.3'
implementation 'net.thauvin.erik:isgd-shorten:0.9.1'
testImplementation 'junit:junit:4.13'
diff --git a/app/src/main/java/net/thauvin/erik/android/emaily/Emaily.java b/app/src/main/java/net/thauvin/erik/android/emaily/Emaily.java
index e38d87c..eaaa90b 100644
--- a/app/src/main/java/net/thauvin/erik/android/emaily/Emaily.java
+++ b/app/src/main/java/net/thauvin/erik/android/emaily/Emaily.java
@@ -45,14 +45,13 @@ import android.text.ClipboardManager;
import android.util.Log;
import android.widget.Toast;
-import net.thauvin.erik.bitly.Bitly;
+import net.thauvin.erik.bitly.Bitlinks;
import net.thauvin.erik.isgd.Isgd;
import java.net.MalformedURLException;
import java.net.URL;
import java.net.UnknownHostException;
-
/**
* The Emaily
class implements a URL shortener intent.
*
@@ -110,7 +109,6 @@ public class Emaily extends Activity {
return sharedPrefs.getString(getString(id), defaultValue);
}
- @SuppressLint("CommitPrefEdits")
@Override
public void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
@@ -246,12 +244,15 @@ public class Emaily extends Activity {
Log.d(appName, "is.gd -> " + item);
shortUrl.append(Isgd.shorten(item));
} else {
- final Bitly bitly = new Bitly(keytoken);
- shortUrl.append(bitly.bitlinks().shorten(item));
- if (shortUrl.toString().equals(item)) {
+ final Bitlinks bitlinks = new Bitlinks(keytoken);
+ shortUrl.append(bitlinks.shorten(item));
+ if (!bitlinks.getLastCallResponse().isSuccessful()) {
+ final int resultCode = bitlinks.getLastCallResponse()
+ .getResultCode();
result.setCode(R.string.alert_error);
- //@TODO fixme
- result.setMessage("TBD");
+ result.setMessage(String.format(
+ getString(R.string.alert_http_status_code),
+ resultCode));
}
}
} catch (Exception e) {
@@ -262,7 +263,11 @@ public class Emaily extends Activity {
result.setMessage(cause.getMessage());
} else {
result.setCode(R.string.alert_error);
- result.setMessage(e.getMessage());
+ if (cause != null) {
+ result.setMessage(cause.getMessage());
+ } else {
+ result.setMessage(e.getMessage());
+ }
}
}
@@ -282,8 +287,8 @@ public class Emaily extends Activity {
}
if (shortUrl.length() > 0) {
- emailIntent.putExtra(Intent.EXTRA_TEXT, shortUrl.toString());
- Log.d(appName, "URL: " + emailIntent.getStringExtra(Intent.EXTRA_TEXT));
+ emailIntent.putExtra(Intent.EXTRA_TEXT, shortUrl.toString());
+ Log.d(appName, "URL: " + emailIntent.getStringExtra(Intent.EXTRA_TEXT));
if (!isValid(pageTitle) && textBefore.length() > 0) {
emailIntent.putExtra(Intent.EXTRA_SUBJECT, textBefore.toString());
@@ -313,8 +318,11 @@ public class Emaily extends Activity {
}
result.setCode(R.string.alert_notfound_clip);
+ result.setMessage(getString(R.string.alert_notfound_clip));
+
} else {
result.setCode(R.string.alert_notfound);
+ result.setMessage(getString(R.string.alert_notfound));
}
}
@@ -334,14 +342,14 @@ public class Emaily extends Activity {
}
if (result.hasError()) {
- Toast.makeText(
- getApplicationContext(),
- getString(result.getCode(),
- result.getMessage(),
- isGd ? getString(R.string.prefs_isgd_title)
- : getString(R.string.prefs_bitly_title)), Toast.LENGTH_LONG)
- .show();
-
+ final String msg = getString(result.getCode(),
+ result.getMessage(),
+ isGd ? getString(R.string.prefs_isgd_title)
+ : getString(R.string.prefs_bitly_title));
+ Log.d(appName, msg);
+ Toast.makeText(getApplicationContext(),
+ getString(result.getCode(), result.getMessage(), msg),
+ Toast.LENGTH_LONG).show();
}
Emaily.this.finish();
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index b6013a9..c8eb78b 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -1,8 +1,9 @@
Sorry. An error was returned by %2$s while shortening the url: %1$s
+ HTTP Status Code %d
Please provide your credentials to shorten urls.
- Sorry. Could not connect to %1$s.
+ Sorry. Could not connect to %1$s: %2$s
Sorry. No applications can perform this action.
Sorry. No applications can perform this action. The shortened url has been copied to the clipboard.
Emaily
diff --git a/build.gradle b/build.gradle
index 749de9d..f11d3cf 100644
--- a/build.gradle
+++ b/build.gradle
@@ -14,6 +14,7 @@ buildscript {
allprojects {
repositories {
+ mavenLocal()
google()
jcenter()
}