From e872c226e8970f2c30f572c65fc527999711f365 Mon Sep 17 00:00:00 2001 From: "Erik C. Thauvin" Date: Sat, 5 Dec 2015 02:20:43 -0800 Subject: [PATCH] PMD optimization. --- src/main/java/net/thauvin/erik/httpstatus/Reasons.java | 8 +++++--- src/main/java/net/thauvin/erik/httpstatus/Utils.java | 2 +- .../net/thauvin/erik/httpstatus/taglibs/ReasonTag.java | 2 +- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/main/java/net/thauvin/erik/httpstatus/Reasons.java b/src/main/java/net/thauvin/erik/httpstatus/Reasons.java index 488c567..830807c 100644 --- a/src/main/java/net/thauvin/erik/httpstatus/Reasons.java +++ b/src/main/java/net/thauvin/erik/httpstatus/Reasons.java @@ -63,7 +63,7 @@ public class Reasons * * @return The reason phrase, or null. */ - public static String getReasonPhrase(int statusCode) + public static String getReasonPhrase(final int statusCode) { return getReasonPhrase(Integer.toString(statusCode)); } @@ -75,7 +75,7 @@ public class Reasons * * @return The reason phrase, or null. */ - public static String getReasonPhrase(String statusCode) + public static String getReasonPhrase(final String statusCode) { return REASON_PHRASES.get(statusCode); } @@ -85,12 +85,14 @@ public class Reasons * * @param args The command line arguments. */ - public static void main(String[] args) + public static void main(final String... args) { for (final Map.Entry entry : REASON_PHRASES.entrySet()) { System.out.println(entry.getKey() + ": " + entry.getValue()); } + + System.out.println("Total: " + REASON_PHRASES.entrySet().size()); } /** diff --git a/src/main/java/net/thauvin/erik/httpstatus/Utils.java b/src/main/java/net/thauvin/erik/httpstatus/Utils.java index 910e2c9..fcc2606 100644 --- a/src/main/java/net/thauvin/erik/httpstatus/Utils.java +++ b/src/main/java/net/thauvin/erik/httpstatus/Utils.java @@ -43,7 +43,7 @@ import java.io.Writer; * @created 2015-12-03 * @since 1.0 */ -public class Utils +public final class Utils { /** diff --git a/src/main/java/net/thauvin/erik/httpstatus/taglibs/ReasonTag.java b/src/main/java/net/thauvin/erik/httpstatus/taglibs/ReasonTag.java index b77f2a2..5894cdb 100644 --- a/src/main/java/net/thauvin/erik/httpstatus/taglibs/ReasonTag.java +++ b/src/main/java/net/thauvin/erik/httpstatus/taglibs/ReasonTag.java @@ -61,7 +61,7 @@ public class ReasonTag extends XmlSupport try { - if (statusCode > 0) + if (statusCode >= 0) { Utils.outWrite(out, Reasons.getReasonPhrase(statusCode), defaultValue, escapeXml); }