erik/akismet-kotlin
erik/akismet-kotlin
1
1
Fork 0
Code Issues Pull requests Releases Activity

Fixed potential resource leak

Browse source
This commit is contained in:
Erik C. Thauvin 2023-01-31 22:07:20 -08:00
parent d525910145
commit a918fdf107
1 changed files with 19 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

37
src/main/kotlin/net/thauvin/erik/akismet/Akismet.kt
View file

@ -331,25 +331,26 @@ open class Akismet(apiKey: String) {
Request.Builder().url(apiUrl).post(formBody).header("User-Agent", buildUserAgent()).build() Request.Builder().url(apiUrl).post(formBody).header("User-Agent", buildUserAgent()).build()
} }
try { try {
val result = client.newCall(request).execute() client.newCall(request).execute().use { result ->
httpStatusCode = result.code httpStatusCode = result.code
proTip = result.header("x-akismet-pro-tip", "").toString().trim() proTip = result.header("x-akismet-pro-tip", "").toString().trim()
isDiscard = (proTip == "discard") isDiscard = (proTip == "discard")
debugHelp = result.header("x-akismet-debug-help", "").toString().trim() debugHelp = result.header("x-akismet-debug-help", "").toString().trim()
val body = result.body?.string() val body = result.body?.string()
if (body != null) { if (body != null) {
response = body.trim() response = body.trim()
if (response == "valid" || response == "true" || response.startsWith("Thanks")) { if (response == "valid" || response == "true" || response.startsWith("Thanks")) {
return true return true
} else if (response != "false" && response != "invalid") { } else if (response != "false" && response != "invalid") {
errorMessage = "Unexpected response: " + body.ifBlank { "<blank>" } errorMessage = "Unexpected response: " + body.ifBlank { "<blank>" }
} }
} else {
val message = "No response body was received from Akismet."
errorMessage = if (debugHelp.isNotBlank()) {
"$message: $debugHelp"
} else { } else {
message val message = "No response body was received from Akismet."
errorMessage = if (debugHelp.isNotBlank()) {
"$message: $debugHelp"
} else {
message
}
} }
} }
} catch (e: IOException) { } catch (e: IOException) {