erik/android-about-box
erik/android-about-box
1
0
Fork 0
mirror of https://github.com/ethauvin/android-about-box.git synced 2025-04-25 02:37:11 -07:00
Code Releases Activity

Merge pull request #25 from eggheadgames/feature/null_check_to_protect_from_crash

Browse source 
Fix "Force close on launching AboutActivity"
This commit is contained in:
mikemee 2017-05-16 07:06:15 -07:00 • committed by GitHub
commit ddca85d1b3
2 changed files with 243 additions and 222 deletions
Download patch file Download diff file Expand all files Collapse all files

97
library/src/main/java/com/eggheadgames/aboutbox/AboutBoxUtils.java Normal file
View file

@ -0,0 +1,97 @@
package com.eggheadgames.aboutbox;
import android.app.Activity;
import android.content.ActivityNotFoundException;
import android.content.Intent;
import android.net.Uri;
import android.widget.Toast;
public final class AboutBoxUtils {
private AboutBoxUtils() {
//nothing
}
public static void getOpenFacebookIntent(Activity context, String name) {
try {
context.getPackageManager().getPackageInfo("com.facebook.katana", 0);
Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse("fb://profile/" + name));
context.startActivity(intent);
} catch (Exception e) {
try {
Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse("https://www.facebook.com/" + name));
context.startActivity(intent);
} catch (Exception e1) {
Toast.makeText(context, R.string.egab_can_not_open, Toast.LENGTH_SHORT).show();
}
}
}
public static void startTwitter(Activity context, String name) {
try {
context.getPackageManager().getPackageInfo("com.twitter.android", 0);
Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse("twitter://user?screen_name=" + name));
intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
context.startActivity(intent);
} catch (Exception e) {
try {
Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse("https://twitter.com/" + name));
context.startActivity(intent);
} catch (Exception e1) {
Toast.makeText(context, R.string.egab_can_not_open, Toast.LENGTH_SHORT).show();
}
}
}
public static void openApp(Activity context, AboutConfig.BuildType buildType, String packageName) {
String appURI = null;
String webURI = null;
switch (buildType) {
case GOOGLE:
appURI = "market://details?id=" + packageName;
webURI = "http://play.google.com/store/apps/details?id=" + packageName;
break;
case AMAZON:
appURI = "amzn://apps/android?p=" + packageName;
webURI = "http://www.amazon.com/gp/mas/dl/android?p=" + packageName;
break;
default:
//nothing
}
openApplication(context, appURI, webURI);
}
public static void openPublisher(Activity context, AboutConfig.BuildType buildType, String publisher, String packageName) {
String appURI = null;
String webURI = null;
switch (buildType) {
case GOOGLE:
appURI = "market://search?q=pub:" + publisher;
webURI = "http://play.google.com/store/search?q=pub:" + publisher;
break;
case AMAZON:
appURI = "amzn://apps/android?showAll=1&p=" + packageName;
webURI = "http://www.amazon.com/gp/mas/dl/android?showAll=1&p=" + packageName;
break;
default:
//nothing
}
openApplication(context, appURI, webURI);
}
public static void openApplication(Activity context, String appURI, String webURI) {
try {
context.startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse(appURI)));
} catch (ActivityNotFoundException e1) {
try {
openHTMLPage(context, webURI);
} catch (ActivityNotFoundException e2) {
Toast.makeText(context, R.string.egab_can_not_open, Toast.LENGTH_SHORT).show();
}
}
}
public static void openHTMLPage(Activity context, String htmlPath) {
context.startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse(htmlPath)));
}
}

368
library/src/main/java/com/eggheadgames/aboutbox/activity/AboutActivity.java
View file

@ -1,13 +1,10 @@
package com.eggheadgames.aboutbox.activity; package com.eggheadgames.aboutbox.activity;
import android.app.Activity; import android.app.Activity;
import android.content.ActivityNotFoundException;
import android.content.Context; import android.content.Context;
import android.content.Intent; import android.content.Intent;
import android.net.Uri;
import android.support.annotation.NonNull; import android.support.annotation.NonNull;
import android.text.TextUtils; import android.text.TextUtils;
import android.widget.Toast;
import com.danielstone.materialaboutlibrary.MaterialAboutActivity; import com.danielstone.materialaboutlibrary.MaterialAboutActivity;
import com.danielstone.materialaboutlibrary.items.MaterialAboutActionItem; import com.danielstone.materialaboutlibrary.items.MaterialAboutActionItem;
@ -15,6 +12,7 @@ import com.danielstone.materialaboutlibrary.items.MaterialAboutItemOnClickListen
import com.danielstone.materialaboutlibrary.items.MaterialAboutTitleItem; import com.danielstone.materialaboutlibrary.items.MaterialAboutTitleItem;
import com.danielstone.materialaboutlibrary.model.MaterialAboutCard; import com.danielstone.materialaboutlibrary.model.MaterialAboutCard;
import com.danielstone.materialaboutlibrary.model.MaterialAboutList; import com.danielstone.materialaboutlibrary.model.MaterialAboutList;
import com.eggheadgames.aboutbox.AboutBoxUtils;
import com.eggheadgames.aboutbox.AboutConfig; import com.eggheadgames.aboutbox.AboutConfig;
import com.eggheadgames.aboutbox.IAnalytic; import com.eggheadgames.aboutbox.IAnalytic;
import com.eggheadgames.aboutbox.R; import com.eggheadgames.aboutbox.R;
@ -34,13 +32,13 @@ public class AboutActivity extends MaterialAboutActivity {
final AboutConfig config = AboutConfig.getInstance(); final AboutConfig config = AboutConfig.getInstance();
return new MaterialAboutList.Builder() return new MaterialAboutList.Builder()
.addCard(buildGeneralInfoCard(config)) .addCard(buildGeneralInfoCard(config))
.addCard(buildSupportCard(config)) .addCard(buildSupportCard(config))
.addCard(buildShareCard(config)) .addCard(buildShareCard(config))
.addCard(buildAboutCard(config)) .addCard(buildAboutCard(config))
.addCard(buildSocialNetworksCard(config)) .addCard(buildSocialNetworksCard(config))
.addCard(buildPrivacyCard(config)) .addCard(buildPrivacyCard(config))
.build(); .build();
} }
@NonNull @NonNull
@ -65,27 +63,27 @@ public class AboutActivity extends MaterialAboutActivity {
if (!TextUtils.isEmpty(config.guideHtmlPath)) { if (!TextUtils.isEmpty(config.guideHtmlPath)) {
card.addItem(itemHelper(R.string.egab_guide, R.drawable.ic_help_green, card.addItem(itemHelper(R.string.egab_guide, R.drawable.ic_help_green,
new MaterialAboutItemOnClickListener() { new MaterialAboutItemOnClickListener() {
@Override @Override
public void onClick(boolean b) { public void onClick(boolean b) {
if (config.dialog == null) { if (config.dialog == null) {
openHTMLPage(config.guideHtmlPath); AboutBoxUtils.openHTMLPage(AboutActivity.this, config.guideHtmlPath);
} else { } else {
config.dialog.open(AboutActivity.this, config.guideHtmlPath, getString(R.string.egab_guide)); config.dialog.open(AboutActivity.this, config.guideHtmlPath, getString(R.string.egab_guide));
}
logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_guide));
} }
logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_guide)); })
}
})
); );
} }
card.addItem(itemHelper(R.string.egab_contact_support, R.drawable.ic_email_black, card.addItem(itemHelper(R.string.egab_contact_support, R.drawable.ic_email_black,
new MaterialAboutItemOnClickListener() { new MaterialAboutItemOnClickListener() {
@Override @Override
public void onClick(boolean b) { public void onClick(boolean b) {
EmailUtil.contactUs(AboutActivity.this); EmailUtil.contactUs(AboutActivity.this);
logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_contact_log_event)); logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_contact_log_event));
} }
})); }));
return card.build(); return card.build();
} }
@ -93,24 +91,24 @@ public class AboutActivity extends MaterialAboutActivity {
@NonNull @NonNull
private MaterialAboutCard buildShareCard(final AboutConfig config) { private MaterialAboutCard buildShareCard(final AboutConfig config) {
MaterialAboutCard.Builder card = new MaterialAboutCard.Builder(); MaterialAboutCard.Builder card = new MaterialAboutCard.Builder();
if (config.buildType != null && !TextUtils.isEmpty(config.packageName)) {
card.addItem(itemHelper(R.string.egab_leave_review, R.drawable.ic_review, card.addItem(itemHelper(R.string.egab_leave_review, R.drawable.ic_review,
new MaterialAboutItemOnClickListener() { new MaterialAboutItemOnClickListener() {
@Override @Override
public void onClick(boolean b) { public void onClick(boolean b) {
openApp(config.buildType, config.packageName); AboutBoxUtils.openApp(AboutActivity.this, config.buildType, config.packageName);
logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_review_log_event)); logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_review_log_event));
} }
})); }));
}
card.addItem(itemHelper(R.string.egab_share, R.drawable.ic_share_black, card.addItem(itemHelper(R.string.egab_share, R.drawable.ic_share_black,
new MaterialAboutItemOnClickListener() { new MaterialAboutItemOnClickListener() {
@Override @Override
public void onClick(boolean b) { public void onClick(boolean b) {
ShareUtil.share(AboutActivity.this); ShareUtil.share(AboutActivity.this);
logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_share_log_event)); logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_share_log_event));
} }
})); }));
return card.build(); return card.build();
} }
@ -118,119 +116,128 @@ public class AboutActivity extends MaterialAboutActivity {
@NonNull @NonNull
private MaterialAboutCard buildAboutCard(final AboutConfig config) { private MaterialAboutCard buildAboutCard(final AboutConfig config) {
MaterialAboutCard.Builder card = new MaterialAboutCard.Builder(); MaterialAboutCard.Builder card = new MaterialAboutCard.Builder();
if (config.buildType != null && !TextUtils.isEmpty(config.appPublisher) && !TextUtils.isEmpty(config.packageName)) {
card.addItem(itemHelper(R.string.egab_try_other_apps, R.drawable.ic_try_other_apps, card.addItem(itemHelper(R.string.egab_try_other_apps, R.drawable.ic_try_other_apps,
new MaterialAboutItemOnClickListener() { new MaterialAboutItemOnClickListener() {
@Override @Override
public void onClick(boolean b) { public void onClick(boolean b) {
openPublisher(config.buildType, config.appPublisher, config.packageName); AboutBoxUtils.openPublisher(AboutActivity.this, config.buildType,
logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_try_other_app_log_event)); config.appPublisher, config.packageName);
} logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_try_other_app_log_event));
})); }
card.addItem(new MaterialAboutActionItem.Builder() }));
.text(config.aboutLabelTitle) }
.icon(R.drawable.ic_about_black) if (!TextUtils.isEmpty(config.companyHtmlPath)) {
.setOnClickListener(new MaterialAboutItemOnClickListener() { card.addItem(new MaterialAboutActionItem.Builder()
@Override .text(config.aboutLabelTitle)
public void onClick(boolean b) { .icon(R.drawable.ic_about_black)
if (config.dialog == null) { .setOnClickListener(new MaterialAboutItemOnClickListener() {
openHTMLPage(config.companyHtmlPath); @Override
} else { public void onClick(boolean b) {
config.dialog.open(AboutActivity.this, config.companyHtmlPath, config.aboutLabelTitle); if (config.dialog == null) {
} AboutBoxUtils.openHTMLPage(AboutActivity.this, config.companyHtmlPath);
logUIEventName(config.analytics, config.logUiEventName, config.aboutLabelTitle); } else {
} config.dialog.open(AboutActivity.this, config.companyHtmlPath, config.aboutLabelTitle);
}) }
.build()); logUIEventName(config.analytics, config.logUiEventName, config.aboutLabelTitle);
}
})
.build());
}
return card.build(); return card.build();
} }
@NonNull @NonNull
private MaterialAboutCard buildSocialNetworksCard(final AboutConfig config) { private MaterialAboutCard buildSocialNetworksCard(final AboutConfig config) {
MaterialAboutCard.Builder card = new MaterialAboutCard.Builder(); MaterialAboutCard.Builder card = new MaterialAboutCard.Builder();
if (!TextUtils.isEmpty(config.facebookUserName)) {
card.addItem(new MaterialAboutActionItem.Builder() card.addItem(new MaterialAboutActionItem.Builder()
.text(R.string.egab_facebook_label) .text(R.string.egab_facebook_label)
.subText(config.facebookUserName) .subText(config.facebookUserName)
.icon(R.drawable.ic_facebook_24) .icon(R.drawable.ic_facebook_24)
.setOnClickListener(new MaterialAboutItemOnClickListener() { .setOnClickListener(new MaterialAboutItemOnClickListener() {
@Override @Override
public void onClick(boolean b) { public void onClick(boolean b) {
getOpenFacebookIntent(AboutActivity.this, config.facebookUserName); AboutBoxUtils.getOpenFacebookIntent(AboutActivity.this, config.facebookUserName);
logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_facebook_log_event)); logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_facebook_log_event));
} }
}) })
.build()); .build());
card.addItem(new MaterialAboutActionItem.Builder() }
.text(R.string.egab_twitter_label) if (!TextUtils.isEmpty(config.twitterUserName)) {
.subText(config.twitterUserName) card.addItem(new MaterialAboutActionItem.Builder()
.icon(R.drawable.ic_twitter_24dp) .text(R.string.egab_twitter_label)
.setOnClickListener(new MaterialAboutItemOnClickListener() { .subText(config.twitterUserName)
@Override .icon(R.drawable.ic_twitter_24dp)
public void onClick(boolean b) { .setOnClickListener(new MaterialAboutItemOnClickListener() {
startTwitter(AboutActivity.this, config.twitterUserName); @Override
logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_twitter_log_event)); public void onClick(boolean b) {
} AboutBoxUtils.startTwitter(AboutActivity.this, config.twitterUserName);
}) logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_twitter_log_event));
.build()); }
})
card.addItem(new MaterialAboutActionItem.Builder() .build());
.text(R.string.egab_web_label) }
.subText(config.webHomePage.replace("https://", "").replace("http://", "").replace("/", "")) if (!TextUtils.isEmpty(config.webHomePage)) {
.icon(R.drawable.ic_web_black_24dp) card.addItem(new MaterialAboutActionItem.Builder()
.setOnClickListener(new MaterialAboutItemOnClickListener() { .text(R.string.egab_web_label)
@Override .subText(config.webHomePage.replace("https://", "").replace("http://", "").replace("/", ""))
public void onClick(boolean b) { .icon(R.drawable.ic_web_black_24dp)
openHTMLPage(config.webHomePage); .setOnClickListener(new MaterialAboutItemOnClickListener() {
logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_website_log_event)); @Override
} public void onClick(boolean b) {
}) AboutBoxUtils.openHTMLPage(AboutActivity.this, config.webHomePage);
.build()); logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_website_log_event));
}
})
.build());
}
return card.build(); return card.build();
} }
@NonNull @NonNull
private MaterialAboutCard buildPrivacyCard(final AboutConfig config) { private MaterialAboutCard buildPrivacyCard(final AboutConfig config) {
MaterialAboutCard.Builder card = new MaterialAboutCard.Builder(); MaterialAboutCard.Builder card = new MaterialAboutCard.Builder();
if (!TextUtils.isEmpty(config.privacyHtmlPath)) {
card.addItem(itemHelper(R.string.egab_privacy_policy, R.drawable.ic_privacy,
new MaterialAboutItemOnClickListener() {
@Override
public void onClick(boolean b) {
if (config.dialog == null) {
AboutBoxUtils.openHTMLPage(AboutActivity.this, config.privacyHtmlPath);
} else {
config.dialog.open(AboutActivity.this, config.privacyHtmlPath, getString(R.string.egab_privacy_policy));
}
card.addItem(itemHelper(R.string.egab_privacy_policy, R.drawable.ic_privacy, logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_privacy_log_event));
new MaterialAboutItemOnClickListener() { }
@Override })
public void onClick(boolean b) { );
if (config.dialog == null) { }
openHTMLPage(config.privacyHtmlPath); if (!TextUtils.isEmpty(config.acknowledgmentHtmlPath)) {
} else { card.addItem(itemHelper(R.string.egab_acknowledgements, R.drawable.ic_acknowledgements,
config.dialog.open(AboutActivity.this, config.privacyHtmlPath, getString(R.string.egab_privacy_policy)); new MaterialAboutItemOnClickListener() {
} @Override
public void onClick(boolean b) {
logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_privacy_log_event)); if (config.dialog == null) {
} AboutBoxUtils.openHTMLPage(AboutActivity.this, config.acknowledgmentHtmlPath);
}) } else {
); config.dialog.open(AboutActivity.this, config.acknowledgmentHtmlPath, getString(R.string.egab_acknowledgements));
card.addItem(itemHelper(R.string.egab_acknowledgements, R.drawable.ic_acknowledgements, }
new MaterialAboutItemOnClickListener() { logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_acknowledgements_log_event));
@Override }
public void onClick(boolean b) { })
if (config.dialog == null) { );
openHTMLPage(config.acknowledgmentHtmlPath); }
} else {
config.dialog.open(AboutActivity.this, config.acknowledgmentHtmlPath, getString(R.string.egab_acknowledgements));
}
logUIEventName(config.analytics, config.logUiEventName, getString(R.string.egab_acknowledgements_log_event));
}
})
);
return card.build(); return card.build();
} }
private MaterialAboutActionItem itemHelper(int name, int icon, MaterialAboutItemOnClickListener listener) { private MaterialAboutActionItem itemHelper(int name, int icon, MaterialAboutItemOnClickListener listener) {
return new MaterialAboutActionItem.Builder() return new MaterialAboutActionItem.Builder()
.text(name) .text(name)
.icon(icon) .icon(icon)
.setOnClickListener(listener) .setOnClickListener(listener)
.build(); .build();
} }
@ -239,89 +246,6 @@ public class AboutActivity extends MaterialAboutActivity {
return getString(R.string.egab_about_screen_title); return getString(R.string.egab_about_screen_title);
} }
public static void getOpenFacebookIntent(Activity context, String name) {
try {
context.getPackageManager().getPackageInfo("com.facebook.katana", 0);
Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse("fb://profile/" + name));
context.startActivity(intent);
} catch (Exception e) {
try {
Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse("https://www.facebook.com/" + name));
context.startActivity(intent);
} catch (Exception e1) {
Toast.makeText(context, R.string.egab_can_not_open, Toast.LENGTH_SHORT).show();
}
}
}
public static void startTwitter(Activity context, String name) {
try {
context.getPackageManager().getPackageInfo("com.twitter.android", 0);
Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse("twitter://user?screen_name=" + name));
intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
context.startActivity(intent);
} catch (Exception e) {
try {
Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse("https://twitter.com/" + name));
context.startActivity(intent);
} catch (Exception e1) {
Toast.makeText(context, R.string.egab_can_not_open, Toast.LENGTH_SHORT).show();
}
}
}
public void openApp(AboutConfig.BuildType buildType, String packageName) {
String appURI = null;
String webURI = null;
switch (buildType) {
case GOOGLE:
appURI = "market://details?id=" + packageName;
webURI = "http://play.google.com/store/apps/details?id=" + packageName;
break;
case AMAZON:
appURI = "amzn://apps/android?p=" + packageName;
webURI = "http://www.amazon.com/gp/mas/dl/android?p=" + packageName;
break;
default:
//nothing
}
openApplication(appURI, webURI);
}
public void openPublisher(AboutConfig.BuildType buildType, String publisher, String packageName) {
String appURI = null;
String webURI = null;
switch (buildType) {
case GOOGLE:
appURI = "market://search?q=pub:" + publisher;
webURI = "http://play.google.com/store/search?q=pub:" + publisher;
break;
case AMAZON:
appURI = "amzn://apps/android?showAll=1&p=" + packageName;
webURI = "http://www.amazon.com/gp/mas/dl/android?showAll=1&p=" + packageName;
break;
default:
//nothing
}
openApplication(appURI, webURI);
}
private void openApplication(String appURI, String webURI) {
try {
startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse(appURI)));
} catch (ActivityNotFoundException e1) {
try {
openHTMLPage(webURI);
} catch (ActivityNotFoundException e2) {
Toast.makeText(this, R.string.egab_can_not_open, Toast.LENGTH_SHORT).show();
}
}
}
private void openHTMLPage(String htmlPath) {
startActivity(new Intent(Intent.ACTION_VIEW, Uri.parse(htmlPath)));
}
private void logUIEventName(IAnalytic analytics, String eventType, String eventValue) { private void logUIEventName(IAnalytic analytics, String eventType, String eventValue) {
if (analytics != null) { if (analytics != null) {
analytics.logUiEvent(eventType, eventValue); analytics.logUiEvent(eventType, eventValue);