Added Bitlinks.update() method.

This commit is contained in:
Erik C. Thauvin 2020-03-03 13:25:04 -08:00
parent 95bea38c92
commit b10721573a
23 changed files with 137 additions and 34 deletions

View file

@ -50,9 +50,9 @@ open class Bitlinks(private val accessToken: String) {
*
* See the [Bitly API](https://dev.bitly.com/v4/#operation/getClicksSummaryForBitlink) for more information.
*
* @param bitlink The bitlink.
* @param unit A unit of time.
* @param units An integer representing the time units to query data for. pass -1 to return all units available.
* @param bitlink A Bitlink made of the domain and hash.
* @param unit A [unit of time][Units].
* @param units An integer representing the time units to query data for. Pass -1 to return all units available.
* @param size The quantity of items to be be returned.
* @param unit_reference An ISO-8601 timestamp, indicating the most recent time for which to pull metrics.
* Will default to current time.
@ -72,7 +72,7 @@ open class Bitlinks(private val accessToken: String) {
if (bitlink.isNotBlank()) {
val response = Utils.call(
accessToken,
("/bitlinks/" + bitlink.removeHttp() + "/clicks/summary").toEndPoint(),
("/bitlinks/${bitlink.removeHttp()}/clicks/summary").toEndPoint(),
hashMapOf(
Pair("unit", unit.toString().toLowerCase()),
Pair("units", units.toString()),
@ -156,14 +156,14 @@ open class Bitlinks(private val accessToken: String) {
default
}
private fun parseJsonResponse(response: String, key: String, default: String, toJson: Boolean): String {
private fun parseJsonResponse(response: CallResponse, key: String, default: String, toJson: Boolean): String {
var parsed = default
if (response.isNotEmpty()) {
if (response.body.isNotEmpty()) {
if (toJson) {
parsed = response
parsed = response.body
} else {
try {
parsed = JSONObject(response).getString(key, default)
parsed = JSONObject(response.body).getString(key, default)
} catch (jse: JSONException) {
Utils.logger.log(Level.SEVERE, "An error occurred parsing the response from Bitly.", jse)
}
@ -208,4 +208,61 @@ open class Bitlinks(private val accessToken: String) {
return bitlink
}
/**
* Updates fields in the Bitlink.
*
* See the [Bit.ly API](https://dev.bitly.com/v4/#operation/updateBitlink) for more information.
*
* @oaran bitlink A Bitlink made of the domain and hash.
* @param toJson Returns the full JSON response if `true`
* @return `true` is the update was successful, `false` otherwise, or JSON response.
*/
@JvmOverloads
fun update(
bitlink: String,
references: Map<String, String> = emptyMap(),
archived: Boolean = false,
tags: Array<String> = emptyArray(),
created_at: String = Constants.EMPTY,
title: String = Constants.EMPTY,
deeplinks: Array<Map<String, String>> = emptyArray(),
created_by: String = Constants.EMPTY,
long_url: String = Constants.EMPTY,
client_id: String = Constants.EMPTY,
custom_bitlinks: Array<String> = emptyArray(),
link: String = Constants.EMPTY,
id: String = Constants.EMPTY,
toJson: Boolean = false
): String {
var result = if (toJson) Constants.EMPTY_JSON else Constants.FALSE
if (bitlink.isNotBlank()) {
val response = Utils.call(
accessToken, "/bitlinks/${bitlink.removeHttp()}".toEndPoint(), mutableMapOf<String, Any>().apply {
if (references.isNotEmpty()) put("references", references)
if (archived) put("archived", archived)
if (tags.isNotEmpty()) put("tags", tags)
if (created_at.isNotBlank()) put("created_at", created_at)
if (title.isNotBlank()) put("title", title)
if (deeplinks.isNotEmpty()) put("deeplinks", deeplinks)
if (created_by.isNotBlank()) put("created_by", created_by)
if (long_url.isNotBlank()) put("long_url", long_url)
if (client_id.isNotBlank()) put("client_id", client_id)
if (custom_bitlinks.isNotEmpty()) put("custom_bitlinks", custom_bitlinks)
if (link.isNotBlank()) put("link", link)
if (id.isNotBlank()) put("id", id)
},
Methods.PATCH
)
if (response.isSuccessful) {
result = if (toJson) {
response.body
} else {
Constants.TRUE
}
}
}
return result
}
}

View file

@ -114,7 +114,7 @@ open class Bitly() {
* @return The response (JSON) from the API.
*/
@JvmOverloads
fun call(endPoint: String, params: Map<String, Any> = emptyMap(), method: Methods = Methods.POST): String {
fun call(endPoint: String, params: Map<String, Any> = emptyMap(), method: Methods = Methods.POST): CallResponse {
return Utils.call(accessToken, endPoint, params, method)
}
}

View file

@ -35,13 +35,15 @@ package net.thauvin.erik.bitly
/** Provides the constants for this package. */
open class Constants private constructor() {
companion object Constants {
/** The Bitly API base URL.
/**
* The Bitly API base URL.
*
* @value `https://api-ssl.bitly.com/v4`
*/
const val API_BASE_URL = "https://api-ssl.bitly.com/v4"
/** The API access token environment variable.
/**
* The API access token environment variable.
*
* @value `BITLY_ACCESS_TOKEN`
*/
@ -52,5 +54,19 @@ open class Constants private constructor() {
/** Empty JSON Object. */
const val EMPTY_JSON = "{}"
/**
* False
*
* @value `false`
*/
const val FALSE = false.toString()
/**
* True
*
* @value `true`
*/
const val TRUE = true.toString()
}
}

View file

@ -67,8 +67,8 @@ open class Utils private constructor() {
endPoint: String,
params: Map<String, Any> = emptyMap(),
method: Methods = Methods.POST
): String {
var response = Constants.EMPTY
): CallResponse {
val response = CallResponse()
if (validateCall(accessToken, endPoint)) {
val apiUrl = endPoint.toHttpUrlOrNull()
if (apiUrl != null) {
@ -99,7 +99,8 @@ open class Utils private constructor() {
}.addHeader("Authorization", "Bearer $accessToken")
val result = createHttpClient().newCall(builder.build()).execute()
response = parseBody(endPoint, result)
response.body = parseBody(endPoint, result)
response.resultCode = result.code
}
}
return response

View file

@ -34,7 +34,6 @@ package net.thauvin.erik.bitly
import net.thauvin.erik.bitly.Utils.Companion.removeHttp
import net.thauvin.erik.bitly.Utils.Companion.toEndPoint
import org.json.JSONObject
import org.junit.Before
import java.io.File
import java.util.logging.Level
@ -97,16 +96,16 @@ class BitlyTest {
@Test
fun `get user`() {
assertTrue(bitly.call("/user".toEndPoint(), method = Methods.GET).contains("\"login\":"))
assertTrue(bitly.call("/user".toEndPoint(), method = Methods.GET).isSuccessful)
}
@Test
fun `created by`() {
assertEquals(
"ethauvin",
JSONObject(
bitly.call("/bitlinks/${shortUrl.removeHttp()}".toEndPoint(), method = Methods.GET)
).getString("created_by")
bitly.call("/bitlinks/${shortUrl.removeHttp()}".toEndPoint(), method = Methods.GET)
.toJson()
.getString("created_by")
)
}
@ -138,4 +137,12 @@ class BitlyTest {
)
)
}
@Test
fun `update bitlink`() {
assertEquals(
Constants.TRUE,
bitly.bitlinks().update(shortUrl, title = "Erik's Weblog", tags = arrayOf("blog", "weblog"))
)
}
}