erik/cryptoprice
erik/cryptoprice
1
1
Fork 0
Code Issues Pull requests Releases Activity

Added toPrice() extension.

Browse source
This commit is contained in:
Erik C. Thauvin 2021-05-08 10:21:12 -07:00
parent cd76f2d9cb
commit 8cb6ac4c0b
3 changed files with 31 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

6
baseline.xml
View file

@ -1,8 +1,8 @@
<?xml version="1.0" ?>
<?xml version='1.0' encoding='UTF-8'?>
<SmellBaseline>
<ManuallySuppressedIssues></ManuallySuppressedIssues>
<ManuallySuppressedIssues/>
<CurrentIssues>
<ID>ThrowsCount:CryptoPrice.kt$CryptoPrice.Companion$ @JvmStatic @JvmOverloads @Throws(CryptoException::class) fun apiCall(paths: List&lt;String&gt;, params: Map&lt;String, String&gt; = emptyMap()): String</ID>
<ID>ThrowsCount:CryptoPrice.kt$CryptoPrice.Companion$ @JvmStatic @JvmOverloads @Throws(CryptoException::class) fun apiCall(paths: List&lt;String>, params: Map&lt;String, String> = emptyMap()): String</ID>
<ID>UtilityClassWithPublicConstructor:CryptoPrice.kt$CryptoPrice</ID>
</CurrentIssues>
</SmellBaseline>

18
src/main/kotlin/net/thauvin/erik/crypto/CryptoPrice.kt
View file

@ -42,6 +42,16 @@ import java.time.LocalDate
data class Price(val base: String, val currency: String, val amount: Double)
fun String.toPrice(): Price {
val json = JSONObject(this)
if (json.has("data")) {
val data = json.getJSONObject("data")
return Price(data.getString("base"), data.getString("currency"), data.getString("amount").toDouble())
} else {
throw CryptoException("Missing JSON data.")
}
}
open class CryptoPrice private constructor() {
companion object {
// Coinbase API URL
@ -101,13 +111,7 @@ open class CryptoPrice private constructor() {
params.put("date", "$date")
}
val body = apiCall(listOf("prices", "$base-$currency", "spot"), params)
val json = JSONObject(body)
if (json.has("data")) {
val data = json.getJSONObject("data")
return Price(data.getString("base"), data.getString("currency"), data.getString("amount").toDouble())
} else {
throw CryptoException("Missing JSON data.")
}
return body.toPrice()
}
}
}

23
src/test/kotlin/net/thauvin/erik/cryptoprice/CryptoPriceTest.kt → src/test/kotlin/net/thauvin/erik/crypto/CryptoPriceTest.kt
View file

@ -42,7 +42,7 @@ class CryptoPriceTest {
@Throws(CryptoException::class)
fun testBCHPrice() {
val price = marketPrice("BCH", "GBP", LocalDate.now().minusDays(1))
assertEquals(price.base, "BCH", "ETH2")
assertEquals(price.base, "BCH", "BCH")
assertEquals(price.currency, "GBP", "is GBP")
assertTrue(price.amount > 0.00, "BCH > 0")
}
@ -51,15 +51,24 @@ class CryptoPriceTest {
@Throws(CryptoException::class)
fun testMarketPriceExceptions() {
assertFailsWith(
message = "FOO did not fail",
exceptionClass = CryptoException::class,
block = { marketPrice("FOO") }
message = "FOO did not fail",
exceptionClass = CryptoException::class,
block = { marketPrice("FOO") }
)
assertFailsWith(
message = "BAR did not fail",
exceptionClass = CryptoException::class,
block = { marketPrice("BTC", "BAR") }
message = "BAR did not fail",
exceptionClass = CryptoException::class,
block = { marketPrice("BTC", "BAR") }
)
}
@Test
@Throws(CryptoException::class)
fun testToPrice() {
val price = "{\"data\":{\"base\":\"BTC\",\"currency\":\"USD\",\"amount\":\"57515.69\"}}".toPrice()
assertEquals(price.base, "BTC", "base is BTC")
assertEquals(price.currency, "USD", "currency is USD")
assertEquals(price.amount, "57515.69".toDouble(), "amount is 57515.69")
}
}