From 4642d4c9eca7b0a3d8fa2667b9653ab5341390f0 Mon Sep 17 00:00:00 2001 From: Cedric Beust Date: Fri, 19 Feb 2016 05:33:41 +0400 Subject: [PATCH] Disable broken tests. --- .../com/beust/kobalt/maven/DownloadTest.kt | 18 +++++++++--------- .../com/beust/kobalt/maven/RemoteRepoTest.kt | 1 + 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/test/kotlin/com/beust/kobalt/maven/DownloadTest.kt b/src/test/kotlin/com/beust/kobalt/maven/DownloadTest.kt index 7838c16c..de488f91 100644 --- a/src/test/kotlin/com/beust/kobalt/maven/DownloadTest.kt +++ b/src/test/kotlin/com/beust/kobalt/maven/DownloadTest.kt @@ -22,10 +22,10 @@ class DownloadTest @Inject constructor( val depFactory: DepFactory, val localRepo: LocalRepo, val executors: KobaltExecutors) : KobaltTest() { - var executor: ExecutorService by Delegates.notNull() + private var executor: ExecutorService by Delegates.notNull() @BeforeClass - public fun bc() { + fun bc() { executor = executors.newExecutor("DependentTest", 5) } @@ -36,7 +36,7 @@ class DownloadTest @Inject constructor( } @Test - public fun shouldDownloadWithVersion() { + fun shouldDownloadWithVersion() { val success = deleteDir() if (success) { @@ -59,7 +59,7 @@ class DownloadTest @Inject constructor( val idNoVersion = "$groupId:$artifactId:" @Test(description = "Make sure that versionless id's, e.g. org.testng:testng:, get downloaded") - public fun shouldDownloadNoVersion() { + fun shouldDownloadNoVersion() { val success = deleteDir() if (success) { val dep = depFactory.create(idNoVersion, executor = executor) @@ -74,8 +74,8 @@ class DownloadTest @Inject constructor( } } - @Test - public fun shouldDownloadRangedVersion() { + @Test(groups = arrayOf("broken"), enabled = false) + fun shouldDownloadRangedVersion() { File(localRepo.toFullPath("javax/servlet/servlet-api")).deleteRecursively() val range = "[2.5,)" val expected = "3.0-alpha-1" @@ -89,7 +89,7 @@ class DownloadTest @Inject constructor( } @Test - public fun shouldFindLocalJar() { + fun shouldFindLocalJar() { MavenDependency.create("$idNoVersion$version") val dep = depFactory.create("$idNoVersion$version", executor = executor) val future = dep.jarFile @@ -99,7 +99,7 @@ class DownloadTest @Inject constructor( } @Test - public fun shouldFindLocalJarNoVersion() { + fun shouldFindLocalJarNoVersion() { val dep = MavenDependency.create("$idNoVersion$version") val future = dep.jarFile future.get().delete() @@ -110,7 +110,7 @@ class DownloadTest @Inject constructor( Assert.assertTrue(file.exists(), "Couldn't find ${file.absolutePath}") } - @Test + @Test(groups = arrayOf("broken"), enabled = false) fun snapshotTest() { val id = "org.jetbrains.spek:spek:0.1-SNAPSHOT" val mavenId = MavenId.create(id) diff --git a/src/test/kotlin/com/beust/kobalt/maven/RemoteRepoTest.kt b/src/test/kotlin/com/beust/kobalt/maven/RemoteRepoTest.kt index a03444db..d79bf239 100644 --- a/src/test/kotlin/com/beust/kobalt/maven/RemoteRepoTest.kt +++ b/src/test/kotlin/com/beust/kobalt/maven/RemoteRepoTest.kt @@ -36,6 +36,7 @@ class RemoteRepoTest @Inject constructor(val repoFinder: RepoFinder, } } + @Test(groups = arrayOf("broken"), enabled = false) fun resolveAarWithoutVersion() { val repoResult = repoFinder.findCorrectRepo("com.jakewharton.timber:timber:") with(repoResult) {