erik/kobalt
erik/kobalt
1
0
Fork 0
mirror of https://github.com/ethauvin/kobalt.git synced 2025-04-26 16:28:12 -07:00
Code Releases Activity

Unnecessary recompilation of the build file.

Browse source
This commit is contained in:
Cedric Beust 2015-11-03 10:21:14 -08:00
parent a5bad9b48a
commit 642f4fc0bc
1 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/main/kotlin/com/beust/kobalt/kotlin/BuildFileCompiler.kt
View file

@ -74,12 +74,15 @@ public class BuildFileCompiler @Inject constructor(@Assisted("buildFiles") val b
return result return result
} }
private fun isUpToDate(buildFile: BuildFile, jarFile: File) =
buildFile.exists() && jarFile.exists()
&& buildFile.lastModified < jarFile.lastModified()
private fun maybeCompileBuildFile(buildFile: BuildFile, buildScriptJarFile: File, private fun maybeCompileBuildFile(buildFile: BuildFile, buildScriptJarFile: File,
pluginUrls: List<URL>) { pluginUrls: List<URL>) {
log(2, "Running build file ${buildFile.name} jar: $buildScriptJarFile") log(2, "Running build file ${buildFile.name} jar: $buildScriptJarFile")
if (buildFile.exists() && buildScriptJarFile.exists() if (isUpToDate(buildFile, buildScriptJarFile)) {
&& buildFile.lastModified < buildScriptJarFile.lastModified()) {
log(2, "Build file is up to date") log(2, "Build file is up to date")
} else { } else {
log(2, "Need to recompile ${buildFile.name}") log(2, "Need to recompile ${buildFile.name}")
@ -132,8 +135,10 @@ public class BuildFileCompiler @Inject constructor(@Assisted("buildFiles") val b
// //
val buildScriptJar = KFiles.findBuildScriptLocation(buildFile, "preBuildScript.jar") val buildScriptJar = KFiles.findBuildScriptLocation(buildFile, "preBuildScript.jar")
val buildScriptJarFile = File(buildScriptJar) val buildScriptJarFile = File(buildScriptJar)
buildScriptJarFile.parentFile.mkdirs() if (! isUpToDate(buildFile, File(buildScriptJar))) {
generateJarFile(BuildFile(Paths.get(pluginSourceFile.path), "Plugins"), buildScriptJarFile) buildScriptJarFile.parentFile.mkdirs()
generateJarFile(BuildFile(Paths.get(pluginSourceFile.path), "Plugins"), buildScriptJarFile)
}
// //
// Run preBuildScript.jar to initialize plugins and repos // Run preBuildScript.jar to initialize plugins and repos