From da0cc233d98735de212c115cc85292bf961ff387 Mon Sep 17 00:00:00 2001 From: Cedric Beust Date: Fri, 19 Feb 2016 07:43:54 +0400 Subject: [PATCH] Warn about network calls. --- .../src/main/kotlin/com/beust/kobalt/maven/DepFactory.kt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/modules/kobalt-plugin-api/src/main/kotlin/com/beust/kobalt/maven/DepFactory.kt b/modules/kobalt-plugin-api/src/main/kotlin/com/beust/kobalt/maven/DepFactory.kt index 59dae026..a65432f8 100644 --- a/modules/kobalt-plugin-api/src/main/kotlin/com/beust/kobalt/maven/DepFactory.kt +++ b/modules/kobalt-plugin-api/src/main/kotlin/com/beust/kobalt/maven/DepFactory.kt @@ -7,6 +7,7 @@ import com.beust.kobalt.maven.dependency.FileDependency import com.beust.kobalt.maven.dependency.MavenDependency import com.beust.kobalt.misc.DependencyExecutor import com.beust.kobalt.misc.KobaltExecutors +import com.beust.kobalt.misc.warn import com.google.inject.Key import java.util.concurrent.ExecutorService import javax.inject.Inject @@ -40,10 +41,14 @@ public class DepFactory @Inject constructor(val localRepo: LocalRepo, if (tentativeVersion != null && ! MavenId.isRangedVersion(tentativeVersion)) tentativeVersion else { var localVersion: String? = tentativeVersion - if (localFirst) localVersion = localRepo.findLocalVersion(mavenId.groupId, mavenId.artifactId, mavenId.packaging) + if (localFirst) localVersion = localRepo.findLocalVersion(mavenId.groupId, mavenId.artifactId, + mavenId.packaging) if (localFirst && localVersion != null) { localVersion } else { + if (! localFirst) { + warn("The id \"$id\" doesn't contain a version, which will cause a network call") + } repoResult = remoteRepo.findCorrectRepo(id) if (!repoResult.found) { throw KobaltException("Couldn't resolve $id")