1
0
Fork 0
mirror of https://github.com/ethauvin/kobalt.git synced 2025-04-26 16:28:12 -07:00

More IClasspathDependency clean up.

This commit is contained in:
Cedric Beust 2015-11-29 10:01:20 -08:00
parent bbfde8c44f
commit e4e4a3348f
5 changed files with 14 additions and 15 deletions

View file

@ -1,12 +1,11 @@
package com.beust.kobalt package com.beust.kobalt
import com.beust.kobalt.api.IClasspathDependency
import com.beust.kobalt.api.Kobalt import com.beust.kobalt.api.Kobalt
import com.beust.kobalt.api.Project
import com.beust.kobalt.api.annotation.Directive import com.beust.kobalt.api.annotation.Directive
import com.beust.kobalt.maven.DepFactory import com.beust.kobalt.maven.DepFactory
import com.beust.kobalt.api.IClasspathDependency import com.beust.kobalt.maven.dependency.FileDependency
import com.beust.kobalt.misc.KobaltExecutors import com.beust.kobalt.misc.KobaltExecutors
import com.beust.kobalt.SystemProperties
import java.io.File import java.io.File
@Directive @Directive
@ -14,7 +13,7 @@ fun homeDir(vararg dirs: String) : String = SystemProperties.homeDir +
File.separator + dirs.toArrayList().joinToString(File.separator) File.separator + dirs.toArrayList().joinToString(File.separator)
@Directive @Directive
fun file(file: String) : String = IClasspathDependency.PREFIX_FILE + file fun file(file: String) : String = FileDependency.PREFIX_FILE + file
@Directive @Directive
fun plugins(vararg dependency : IClasspathDependency) { fun plugins(vararg dependency : IClasspathDependency) {

View file

@ -10,10 +10,6 @@ import java.util.concurrent.Future
* which represents a dependency living in a Maven repo. * which represents a dependency living in a Maven repo.
*/ */
interface IClasspathDependency { interface IClasspathDependency {
companion object {
val PREFIX_FILE: String = "file://"
}
/** Identifier for this dependency */ /** Identifier for this dependency */
val id: String val id: String

View file

@ -1,8 +1,8 @@
package com.beust.kobalt.maven package com.beust.kobalt.maven
import com.beust.kobalt.KobaltException import com.beust.kobalt.KobaltException
import com.beust.kobalt.maven.dependency.FileDependency
import com.beust.kobalt.api.IClasspathDependency import com.beust.kobalt.api.IClasspathDependency
import com.beust.kobalt.maven.dependency.FileDependency
import com.beust.kobalt.maven.dependency.MavenDependency import com.beust.kobalt.maven.dependency.MavenDependency
import com.beust.kobalt.misc.KobaltExecutors import com.beust.kobalt.misc.KobaltExecutors
import java.util.concurrent.ExecutorService import java.util.concurrent.ExecutorService
@ -19,8 +19,8 @@ public class DepFactory @Inject constructor(val localRepo: LocalRepo,
*/ */
public fun create(id: String, executor: ExecutorService, public fun create(id: String, executor: ExecutorService,
localFirst : Boolean = true) : IClasspathDependency { localFirst : Boolean = true) : IClasspathDependency {
if (id.startsWith(IClasspathDependency.PREFIX_FILE)) { if (id.startsWith(FileDependency.PREFIX_FILE)) {
return FileDependency(id.substring(IClasspathDependency.PREFIX_FILE.length)) return FileDependency(id.substring(FileDependency.PREFIX_FILE.length))
} else { } else {
val mavenId = MavenId(id) val mavenId = MavenId(id)
var version = mavenId.version var version = mavenId.version

View file

@ -1,6 +1,6 @@
package com.beust.kobalt.maven package com.beust.kobalt.maven
import com.beust.kobalt.api.IClasspathDependency import com.beust.kobalt.maven.dependency.FileDependency
import com.google.inject.assistedinject.Assisted import com.google.inject.assistedinject.Assisted
import java.io.* import java.io.*
import java.net.HttpURLConnection import java.net.HttpURLConnection
@ -25,8 +25,8 @@ class Kurl @Inject constructor(@Assisted val url: String) {
val result = val result =
if (connection is HttpURLConnection) { if (connection is HttpURLConnection) {
(connection as HttpURLConnection).responseCode == 200 (connection as HttpURLConnection).responseCode == 200
} else if (url.startsWith(IClasspathDependency.PREFIX_FILE)) { } else if (url.startsWith(FileDependency.PREFIX_FILE)) {
val fileName = url.substring(IClasspathDependency.PREFIX_FILE.length) val fileName = url.substring(FileDependency.PREFIX_FILE.length)
File(fileName).exists() File(fileName).exists()
} else { } else {
false false

View file

@ -6,7 +6,11 @@ import org.apache.maven.model.Dependency
import java.io.File import java.io.File
open public class FileDependency(open val fileName: String) : IClasspathDependency, Comparable<FileDependency> { open public class FileDependency(open val fileName: String) : IClasspathDependency, Comparable<FileDependency> {
override val id = IClasspathDependency.PREFIX_FILE + fileName companion object {
val PREFIX_FILE: String = "file://"
}
override val id = PREFIX_FILE + fileName
override val jarFile = CompletedFuture(File(fileName)) override val jarFile = CompletedFuture(File(fileName))