diff --git a/src/main/java/net/thauvin/erik/mobibot/EntriesMgr.java b/src/main/java/net/thauvin/erik/mobibot/EntriesMgr.java index 19756d8..d2299ae 100644 --- a/src/main/java/net/thauvin/erik/mobibot/EntriesMgr.java +++ b/src/main/java/net/thauvin/erik/mobibot/EntriesMgr.java @@ -125,7 +125,7 @@ final class EntriesMgr { final String today; - try (InputStreamReader reader = new InputStreamReader(new FileInputStream(file), StandardCharsets.UTF_8)) { + try (final InputStreamReader reader = new InputStreamReader(new FileInputStream(file), StandardCharsets.UTF_8)) { final SyndFeed feed = input.build(reader); today = Utils.isoLocalDate(feed.getPublishedDate()); diff --git a/src/main/java/net/thauvin/erik/mobibot/EntryLink.java b/src/main/java/net/thauvin/erik/mobibot/EntryLink.java index 94395f9..8820227 100644 --- a/src/main/java/net/thauvin/erik/mobibot/EntryLink.java +++ b/src/main/java/net/thauvin/erik/mobibot/EntryLink.java @@ -58,22 +58,22 @@ public class EntryLink implements Serializable { private final List tags = new CopyOnWriteArrayList<>(); // The channel - private String channel = ""; + private String channel; // The creation date private Date date = Calendar.getInstance().getTime(); // The link's URL - private String link = ""; + private String link; // The author's login private String login = ""; // The author's nickname - private String nick = ""; + private String nick; // The link's title - private String title = ""; + private String title; /** * Creates a new entry. @@ -184,7 +184,7 @@ public class EntryLink implements Serializable { * @return The comments. */ public final EntryComment[] getComments() { - return (comments.toArray(new EntryComment[comments.size()])); + return (comments.toArray(new EntryComment[0])); } /** diff --git a/src/main/java/net/thauvin/erik/mobibot/Tell.java b/src/main/java/net/thauvin/erik/mobibot/Tell.java index fd5b98d..de149c8 100644 --- a/src/main/java/net/thauvin/erik/mobibot/Tell.java +++ b/src/main/java/net/thauvin/erik/mobibot/Tell.java @@ -144,7 +144,7 @@ public class Tell { helpResponse(sender); } else if (cmds.startsWith(Commands.VIEW_CMD)) { if (bot.isOp(sender) && cmds.equals(Commands.VIEW_CMD + ' ' + TELL_ALL_KEYWORD)) { - if (messages.isEmpty()) { + if (!messages.isEmpty()) { for (final TellMessage message : messages) { bot.send(sender, Utils.bold(message.getSender()) + arrow + Utils.bold(message.getRecipient()) + " [ID: " + message.getId() + ", " diff --git a/src/main/java/net/thauvin/erik/mobibot/TellMessagesMgr.java b/src/main/java/net/thauvin/erik/mobibot/TellMessagesMgr.java index eb46a1c..8d6cdde 100644 --- a/src/main/java/net/thauvin/erik/mobibot/TellMessagesMgr.java +++ b/src/main/java/net/thauvin/erik/mobibot/TellMessagesMgr.java @@ -89,7 +89,7 @@ final class TellMessagesMgr { public static List load(final String file, final Logger logger) { try { - try (ObjectInput input = new ObjectInputStream(new BufferedInputStream(new FileInputStream(file)))) { + try (final ObjectInput input = new ObjectInputStream(new BufferedInputStream(new FileInputStream(file)))) { if (logger.isDebugEnabled()) { logger.debug("Loading the messages."); } @@ -117,7 +117,7 @@ final class TellMessagesMgr { public static void save(final String file, final List messages, final Logger logger) { try { - try (ObjectOutput output = new ObjectOutputStream(new BufferedOutputStream(new FileOutputStream(file)))) { + try (final ObjectOutput output = new ObjectOutputStream(new BufferedOutputStream(new FileOutputStream(file)))) { if (logger.isDebugEnabled()) { logger.debug("Saving the messages."); }