Used variable instead of repeat literal strings. (PMD)

This commit is contained in:
Erik C. Thauvin 2019-04-27 03:06:37 -07:00
parent f4afbcaaa5
commit 7e16f1cb3f

View file

@ -689,21 +689,23 @@ public class Mobibot extends PircBot {
} else if (Commands.INFO_CMD.equals(lcTopic)) { } else if (Commands.INFO_CMD.equals(lcTopic)) {
send(sender, "To view information about the bot:"); send(sender, "To view information about the bot:");
send(sender, helpIndent(getNick() + ": " + Commands.INFO_CMD)); send(sender, helpIndent(getNick() + ": " + Commands.INFO_CMD));
} else if (Commands.CYCLE_CMD.equals(lcTopic) && isOp(sender)) { } else {
final String msg = "/msg ";
if (Commands.CYCLE_CMD.equals(lcTopic) && isOp(sender)) {
send(sender, "To have the bot leave the channel and come back:"); send(sender, "To have the bot leave the channel and come back:");
send(sender, helpIndent("/msg " + getNick() + ' ' + Commands.CYCLE_CMD)); send(sender, helpIndent(msg + getNick() + ' ' + Commands.CYCLE_CMD));
} else if (Commands.ME_CMD.equals(lcTopic) && isOp(sender)) { } else if (Commands.ME_CMD.equals(lcTopic) && isOp(sender)) {
send(sender, "To have the bot perform an action:"); send(sender, "To have the bot perform an action:");
send(sender, helpIndent("/msg " + getNick() + ' ' + Commands.ME_CMD + " <action>")); send(sender, helpIndent(msg + getNick() + ' ' + Commands.ME_CMD + " <action>"));
} else if (Commands.SAY_CMD.equals(lcTopic) && isOp(sender)) { } else if (Commands.SAY_CMD.equals(lcTopic) && isOp(sender)) {
send(sender, "To have the bot say something on the channel:"); send(sender, "To have the bot say something on the channel:");
send(sender, helpIndent("/msg " + getNick() + ' ' + Commands.SAY_CMD + " <text>")); send(sender, helpIndent(msg + getNick() + ' ' + Commands.SAY_CMD + " <text>"));
} else if (Commands.VERSION_CMD.equals(lcTopic) && isOp(sender)) { } else if (Commands.VERSION_CMD.equals(lcTopic) && isOp(sender)) {
send(sender, "To view the version data (bot, java, etc.):"); send(sender, "To view the version data (bot, java, etc.):");
send(sender, helpIndent("/msg " + getNick() + ' ' + Commands.VERSION_CMD)); send(sender, helpIndent(msg + getNick() + ' ' + Commands.VERSION_CMD));
} else if (Commands.MSG_CMD.equals(lcTopic) && isOp(sender)) { } else if (Commands.MSG_CMD.equals(lcTopic) && isOp(sender)) {
send(sender, "To have the bot send a private message to someone:"); send(sender, "To have the bot send a private message to someone:");
send(sender, helpIndent("/msg " + getNick() + ' ' + Commands.MSG_CMD + " <nick> <text>")); send(sender, helpIndent(msg + getNick() + ' ' + Commands.MSG_CMD + " <nick> <text>"));
} else if (Commands.IGNORE_CMD.equals(lcTopic)) { } else if (Commands.IGNORE_CMD.equals(lcTopic)) {
send(sender, "To check your ignore status:"); send(sender, "To check your ignore status:");
send(sender, helpIndent(getNick() + ": " + Commands.IGNORE_CMD)); send(sender, helpIndent(getNick() + ": " + Commands.IGNORE_CMD));
@ -776,6 +778,7 @@ public class Mobibot extends PircBot {
} }
} }
} }
}
/** /**
* Identifies the bot. * Identifies the bot.