From be0c1c4cd4ce1818085b9178b3b7a4050af5945a Mon Sep 17 00:00:00 2001 From: "Erik C. Thauvin" Date: Sat, 27 Apr 2019 02:37:45 -0700 Subject: [PATCH] Repeat string to variables (PMD) --- .../erik/mobibot/modules/ModuleExceptionTest.java | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/test/java/net/thauvin/erik/mobibot/modules/ModuleExceptionTest.java b/src/test/java/net/thauvin/erik/mobibot/modules/ModuleExceptionTest.java index c058317..a2faff9 100644 --- a/src/test/java/net/thauvin/erik/mobibot/modules/ModuleExceptionTest.java +++ b/src/test/java/net/thauvin/erik/mobibot/modules/ModuleExceptionTest.java @@ -48,26 +48,29 @@ import static org.assertj.core.api.Assertions.assertThat; * @since 1.0 */ public class ModuleExceptionTest { + static final String debugMessage = "debugMessage"; + static final String message = "message"; + @DataProvider(name = "dp") Object[][] createData(final Method m) { - return new Object[][]{new Object[]{new ModuleException("debugMessage", "message", + return new Object[][]{new Object[]{new ModuleException(debugMessage, message, new IOException("Secret URL http://foo.com?apiKey=sec&userID=me"))}, - new Object[]{new ModuleException("debugMessage", "message", + new Object[]{new ModuleException(debugMessage, message, new IOException("URL http://foobar.com"))}, - new Object[]{new ModuleException("debugMessage", "message", + new Object[]{new ModuleException(debugMessage, message, new IOException("URL http://foobar.com?"))}, - new Object[]{new ModuleException("debugMessage", "message")} + new Object[]{new ModuleException(debugMessage, message)} }; } @Test(dataProvider = "dp") final void testGetDebugMessage(final ModuleException e) { - assertThat(e.getDebugMessage()).as("get debug message").isEqualTo("debugMessage"); + assertThat(e.getDebugMessage()).as("get debug message").isEqualTo(debugMessage); } @Test(dataProvider = "dp") final void testGetMessage(final ModuleException e) { - assertThat(e.getMessage()).as("get message").isEqualTo("message"); + assertThat(e.getMessage()).as("get message").isEqualTo(message); } @Test(dataProvider = "dp")