Updated dependencies.

build.gradle

@@ -1,16 +1,16 @@
 plugins {
     id 'application'
     id 'checkstyle'
-    id 'com.github.ben-manes.versions' version '0.36.0'
+    id 'com.github.ben-manes.versions' version '0.38.0'
-    id 'com.github.spotbugs' version '4.6.0'
+    id 'com.github.spotbugs' version '4.7.0'
     id 'idea'
-    id 'io.gitlab.arturbosch.detekt' version '1.15.0-RC1'
+    id 'io.gitlab.arturbosch.detekt' version '1.16.0'
     id 'jacoco'
     id 'java'
     id 'net.thauvin.erik.gradle.semver' version '1.0.4'
-    id 'org.jetbrains.kotlin.jvm' version '1.4.20'
+    id 'org.jetbrains.kotlin.jvm' version '1.4.31'
-    id 'org.jetbrains.kotlin.kapt' version '1.4.20'
+    id 'org.jetbrains.kotlin.kapt' version '1.4.31'
-    id 'org.sonarqube' version '3.0'
+    id 'org.sonarqube' version '3.1.1'
     id 'pmd'
 }
 
@@ -22,9 +22,9 @@ final def semverProcessor = "net.thauvin.erik:semver:1.2.0"
 
 ext.versions = [
     jacoco  : '0.8.6',
-    log4j   : '2.14.0',
+    log4j   : '2.14.1',
-    pmd     : '6.29.0',
+    pmd     : '6.32.0',
-    spotbugs: '4.2.0'
+    spotbugs: '4.2.2'
 ]
 
 repositories {
@@ -48,9 +48,9 @@ dependencies {
     implementation 'net.aksingh:owm-japis:2.5.3.0'
     implementation 'net.objecthunter:exp4j:0.4.8'
     implementation 'net.thauvin.erik:pinboard-poster:1.0.1'
-    implementation 'org.apache.commons:commons-lang3:3.11'
+    implementation 'org.apache.commons:commons-lang3:3.12.0'
-    implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.4.2'
+    implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.4.3'
-    implementation 'org.json:json:20201115'
+    implementation 'org.json:json:20210307'
     implementation 'org.jsoup:jsoup:1.13.1'
     implementation 'org.twitter4j:twitter4j-core:4.0.7'
     implementation "org.apache.logging.log4j:log4j-api:$versions.log4j"
@@ -60,8 +60,8 @@ dependencies {
     compileOnly "com.github.spotbugs:spotbugs-annotations:$versions.spotbugs"
     testCompileOnly "com.github.spotbugs:spotbugs-annotations:$versions.spotbugs"
 
-    testImplementation 'org.assertj:assertj-core:3.18.1'
+    testImplementation 'org.assertj:assertj-core:3.19.0'
-    testImplementation 'org.testng:testng:7.3.0'
+    testImplementation 'org.testng:testng:7.4.0'
 
     spotbugsPlugins 'com.h3xstream.findsecbugs:findsecbugs-plugin:1.11.0'
     spotbugsPlugins 'com.mebigfatguy.sb-contrib:sb-contrib:7.4.7'

config/detekt/baseline.xml

@@ -14,42 +14,6 @@
     <ID>LongParameterList:Comment.kt$Comment$(bot: Mobibot, cmd: String, sender: String, entry: EntryLink, index: Int, commentIndex: Int)</ID>
     <ID>LongParameterList:Mobibot.kt$Mobibot$( nick: String, list: List&lt;String&gt;, maxPerLine: Int, isPrivate: Boolean, isBold: Boolean = false, isIndent: Boolean = false )</ID>
     <ID>LongParameterList:Twitter.kt$Twitter.Companion$( consumerKey: String?, consumerSecret: String?, token: String?, tokenSecret: String?, handle: String?, message: String, isDm: Boolean )</ID>
-    <ID>MagicNumber:AddLog.kt$AddLog$4</ID>
-    <ID>MagicNumber:Comment.kt$Comment$3</ID>
-    <ID>MagicNumber:CurrencyConverter.kt$CurrencyConverter$11</ID>
-    <ID>MagicNumber:CurrencyConverter.kt$CurrencyConverter$3</ID>
-    <ID>MagicNumber:CurrencyConverter.kt$CurrencyConverter.Companion$3</ID>
-    <ID>MagicNumber:CurrencyConverter.kt$CurrencyConverter.Companion$4</ID>
-    <ID>MagicNumber:CurrencyConverter.kt$CurrencyConverter.Companion$8</ID>
-    <ID>MagicNumber:Cycle.kt$Cycle$10</ID>
-    <ID>MagicNumber:Dice.kt$Dice$7</ID>
-    <ID>MagicNumber:FeedReader.kt$FeedReader$5</ID>
-    <ID>MagicNumber:Ignore.kt$Ignore$8</ID>
-    <ID>MagicNumber:Mobibot.kt$Mobibot$10</ID>
-    <ID>MagicNumber:Mobibot.kt$Mobibot$1000L</ID>
-    <ID>MagicNumber:Mobibot.kt$Mobibot$3</ID>
-    <ID>MagicNumber:Mobibot.kt$Mobibot$5</ID>
-    <ID>MagicNumber:Mobibot.kt$Mobibot$8</ID>
-    <ID>MagicNumber:Modules.kt$Modules$7</ID>
-    <ID>MagicNumber:Recap.kt$Recap.Companion$10</ID>
-    <ID>MagicNumber:Tell.kt$Tell$50</ID>
-    <ID>MagicNumber:Tell.kt$Tell$7</ID>
-    <ID>MagicNumber:Twitter.kt$Twitter$1000L</ID>
-    <ID>MagicNumber:Twitter.kt$Twitter$60L</ID>
-    <ID>MagicNumber:Users.kt$Users$8</ID>
-    <ID>MagicNumber:Utils.kt$Utils$30</ID>
-    <ID>MagicNumber:Utils.kt$Utils$365</ID>
-    <ID>MagicNumber:Utils.kt$Utils$7</ID>
-    <ID>MagicNumber:View.kt$View$8</ID>
-    <ID>MagicNumber:Weather2.kt$Weather2.Companion$1.60934</ID>
-    <ID>MagicNumber:Weather2.kt$Weather2.Companion$32</ID>
-    <ID>MagicNumber:Weather2.kt$Weather2.Companion$5</ID>
-    <ID>MagicNumber:Weather2.kt$Weather2.Companion$9</ID>
-    <ID>MagicNumber:WorldTime.kt$WorldTime$17</ID>
-    <ID>MagicNumber:WorldTime.kt$WorldTime.Companion$3</ID>
-    <ID>MagicNumber:WorldTime.kt$WorldTime.Companion$3600</ID>
-    <ID>MagicNumber:WorldTime.kt$WorldTime.Companion$60</ID>
-    <ID>MagicNumber:WorldTime.kt$WorldTime.Companion$86.4</ID>
     <ID>MemberNameEqualsClassName:Calc.kt$Calc.Companion$ @JvmStatic fun calc(query: String): String</ID>
     <ID>MemberNameEqualsClassName:Lookup.kt$Lookup.Companion$ @JvmStatic @Throws(UnknownHostException::class) fun lookup(query: String): String</ID>
     <ID>MemberNameEqualsClassName:WorldTime.kt$WorldTime.Companion$ @JvmStatic fun worldTime(query: String): Message</ID>
@@ -74,19 +38,14 @@
     <ID>NestedBlockDepth:Weather2.kt$Weather2$ override fun run(sender: String, cmd: String, args: String, isPrivate: Boolean)</ID>
     <ID>NestedBlockDepth:Weather2.kt$Weather2.Companion$ @JvmStatic @Throws(ModuleException::class) fun getWeather(query: String, apiKey: String?): List&lt;Message&gt;</ID>
     <ID>NestedBlockDepth:WorldTime.kt$WorldTime$override fun commandResponse( sender: String, cmd: String, args: String, isPrivate: Boolean )</ID>
+    <ID>PrintStackTrace:Mobibot.kt$Mobibot$e</ID>
+    <ID>PrintStackTrace:Mobibot.kt$Mobibot.Companion$e</ID>
     <ID>ReturnCount:Addons.kt$Addons$ fun exec(sender: String, login: String, cmd: String, args: String, isOp: Boolean, isPrivate: Boolean): Boolean</ID>
     <ID>ReturnCount:Addons.kt$Addons$ fun help(sender: String, topic: String, isOp: Boolean, isPrivate: Boolean): Boolean</ID>
+    <ID>SwallowedException:Calc.kt$Calc.Companion$catch (e: IllegalArgumentException) { "No idea. This is the kind of math I don't get." }</ID>
     <ID>ThrowsCount:GoogleSearch.kt$GoogleSearch.Companion$ @JvmStatic @Throws(ModuleException::class) fun searchGoogle(query: String, apiKey: String?, cseKey: String?): List&lt;Message&gt;</ID>
     <ID>ThrowsCount:StockQuote.kt$StockQuote.Companion$ @JvmStatic @Throws(ModuleException::class) fun getQuote(symbol: String, apiKey: String?): List&lt;Message&gt;</ID>
     <ID>ThrowsCount:StockQuote.kt$StockQuote.Companion$@Throws(ModuleException::class) private fun getJsonResponse(response: String, debugMessage: String): JSONObject</ID>
     <ID>ThrowsCount:Weather2.kt$Weather2.Companion$ @JvmStatic @Throws(ModuleException::class) fun getWeather(query: String, apiKey: String?): List&lt;Message&gt;</ID>
-    <ID>TooGenericExceptionCaught:FeedReader.kt$FeedReader$e: Exception</ID>
-    <ID>TooGenericExceptionCaught:Mobibot.kt$Mobibot$e: Exception</ID>
-    <ID>TooGenericExceptionCaught:Mobibot.kt$Mobibot$ex: Exception</ID>
-    <ID>TooGenericExceptionCaught:StockQuote.kt$StockQuote.Companion$e: NullPointerException</ID>
-    <ID>TooGenericExceptionCaught:Weather2.kt$Weather2.Companion$e: NullPointerException</ID>
-    <ID>TooManyFunctions:Mobibot.kt$Mobibot : PircBot</ID>
-    <ID>TooManyFunctions:Tell.kt$Tell : AbstractCommand</ID>
-    <ID>TooManyFunctions:Utils.kt$Utils$Utils</ID>
   </CurrentIssues>
 </SmellBaseline>

config/pmd.xml

@@ -237,7 +237,6 @@
     <rule ref="category/java/performance.xml/AvoidArrayLoops"/>
     <rule ref="category/java/performance.xml/AvoidFileStream"/>
     <rule ref="category/java/performance.xml/AvoidInstantiatingObjectsInLoops"/>
-    <rule ref="category/java/performance.xml/AvoidUsingShortType"/>
     <rule ref="category/java/performance.xml/BigIntegerInstantiation"/>
     <rule ref="category/java/performance.xml/BooleanInstantiation"/>
     <rule ref="category/java/performance.xml/ByteInstantiation"/>
@@ -250,7 +249,6 @@
     <rule ref="category/java/performance.xml/LongInstantiation"/>
     <rule ref="category/java/performance.xml/OptimizableToArrayCall"/>
     <rule ref="category/java/performance.xml/RedundantFieldInitializer"/>
-    <rule ref="category/java/performance.xml/SimplifyStartsWith"/>
     <rule ref="category/java/performance.xml/ShortInstantiation"/>
     <rule ref="category/java/performance.xml/StringInstantiation"/>
     <rule ref="category/java/performance.xml/StringToString"/>

gradle/wrapper/gradle-wrapper.properties

@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-6.8.3-bin.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists

src/main/java/net/thauvin/erik/mobibot/commands/Info.java

@@ -87,9 +87,10 @@ public class Info extends AbstractCommand {
                                 final boolean isPrivate) {
         getBot().sendList(sender, allVersions, 1, isPrivate);
 
-        final StringBuilder info = new StringBuilder("Uptime: ");
+        final StringBuilder info = new StringBuilder(29);
 
-        info.append(Utils.uptime(ManagementFactory.getRuntimeMXBean().getUptime()))
+        info.append("Uptime: ")
+            .append(Utils.uptime(ManagementFactory.getRuntimeMXBean().getUptime()))
             .append(" [Entries: ")
             .append(LinksMgr.entries.size());
 

src/main/java/net/thauvin/erik/mobibot/modules/WorldTime.kt

@@ -64,7 +64,7 @@ class WorldTime(bot: Mobibot) : AbstractModule(bot) {
             val zdt = ZonedDateTime.now(ZoneId.of("UTC+01:00"))
             val beats = ((zdt[ChronoField.SECOND_OF_MINUTE] + zdt[ChronoField.MINUTE_OF_HOUR] * 60
                 + zdt[ChronoField.HOUR_OF_DAY] * 3600) / 86.4).toInt()
-            return String.format("%c%03d", '@', beats)
+            return String.format(Locale.getDefault(), "%c%03d", '@', beats)
         }
 
         /**

version.properties

@@ -1,9 +1,9 @@
 #Generated by the Semver Plugin for Gradle
-#Thu Mar 11 18:09:42 PST 2021
+#Fri Mar 12 21:10:57 PST 2021
-version.buildmeta=428
+version.buildmeta=434
 version.major=0
 version.minor=8
 version.patch=0
 version.prerelease=beta
 version.project=mobibot
-version.semver=0.8.0-beta+428
+version.semver=0.8.0-beta+434