From 05bbce736a39eee5770f80b9bfb35a42e9fb7ee4 Mon Sep 17 00:00:00 2001 From: Adel Atallah Date: Sun, 7 Oct 2018 21:03:40 +0200 Subject: [PATCH 1/3] Fix typo in the readme file --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 0bbc268..4e90ebd 100644 --- a/README.md +++ b/README.md @@ -12,7 +12,7 @@ Tested with fish 2.7.1 and SDKMAN! 5.7.1. With [fisherman] (install separately): ``` -fisher reitzig/sdkman-for-fish +fisher add reitzig/sdkman-for-fish ``` ## Usage From 74c0772ac189d53a4876363375165d30d4e20b92 Mon Sep 17 00:00:00 2001 From: Raphael R <4246780+reitzig@users.noreply.github.com> Date: Mon, 8 Oct 2018 15:34:04 +0200 Subject: [PATCH 2/3] Changes location of hacked sdkman init script Config folder of fisher(man) changed location between v2 and v3. Pertains to issue #19 --- conf.d/sdk.fish | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf.d/sdk.fish b/conf.d/sdk.fish index af1ee5d..14a66d4 100644 --- a/conf.d/sdk.fish +++ b/conf.d/sdk.fish @@ -8,7 +8,7 @@ # https://github.com/reitzig/sdkman-for-fish set __fish_sdkman_init "$HOME/.sdkman/bin/sdkman-init.sh" -set __fish_sdkman_noexport_init "$HOME/.config/fisherman/sdkman-for-fish/sdkman-noexport-init.sh" +set __fish_sdkman_noexport_init "$HOME/.config/fisher/github.com/reitzig/sdkman-for-fish/sdkman-noexport-init.sh" # Guard: SDKMAN! needs to be installed if not test -f "$__fish_sdkman_init" From 189739ca31eadffa5cb3d402b219caa661d4084c Mon Sep 17 00:00:00 2001 From: Raphael R <4246780+reitzig@users.noreply.github.com> Date: Mon, 8 Oct 2018 15:50:36 +0200 Subject: [PATCH 3/3] Update README.md Updates references to fisher(man) v2. --- README.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 4e90ebd..34604c7 100644 --- a/README.md +++ b/README.md @@ -5,16 +5,18 @@ Makes command `sdk` from [SDKMAN!] available in fish. Also provides auto-completion and adds binaries from installed SDKs to the PATH. -Tested with fish 2.7.1 and SDKMAN! 5.7.1. +Tested with fish 2.7.1 and SDKMAN! 5.7.3. ## Install -With [fisherman] (install separately): +With [fisher] (install separately): ``` fisher add reitzig/sdkman-for-fish ``` +_Note:_ Only compatible with fisher v3 upwards; v2 is no longer supported. + ## Usage It's all in the background; you should be able to run `sdk` and binaries installed @@ -28,6 +30,6 @@ with `sdk` as you would expect. see [his comment on sdkman/sdkman-cli#294](https://github.com/sdkman/sdkman-cli/issues/294#issuecomment-318252058). [SDKMAN!]: https://github.com/sdkman/sdkman-cli -[fisherman]: https://github.com/fisherman/fisherman +[fisher]: https://github.com/jorgebucaran/fisher [travis-link]: https://travis-ci.org/reitzig/sdkman-for-fish -[travis-badge]: https://travis-ci.org/reitzig/sdkman-for-fish.svg?branch=master \ No newline at end of file +[travis-badge]: https://travis-ci.org/reitzig/sdkman-for-fish.svg?branch=master