Migrate wrapper test to Cucumber.

test/features/support/helpers.rb

@@ -1,5 +1,8 @@
 # frozen_string_literal: true
 
+require 'fileutils'
+require 'tmpdir'
+
 def list_installed_candidates
   candidates = {}
 
@@ -17,26 +20,70 @@ end
 
 def installed?(candidate, version = nil)
   candidates = list_installed_candidates
-  candidates.key?(candidate) && (version.nil? || candidates[candidate].include?(version))
+  candidates.key?(candidate) \
+                  && (version.nil? || candidates[candidate].include?(version))
 end
 
 def run_bash_command(cmd)
-  stdout, stderr, status = Open3.capture3("bash -c 'source \"$HOME/.sdkman/bin/sdkman-init.sh\"; #{cmd}'")
-  unless status.success?
-    warn(stderr)
-    raise "Bash command failed: #{stderr}"
-  end
+  Dir.mktmpdir(%w[sdkman-for-fish-test_ _fish]) do |tmp_dir|
+    files = %i[status stdout stderr env].map { |s|
+      [s, FileUtils.touch("#{tmp_dir}/#{s}")[0]]
+    }.to_h
 
-  stdout
+    out, status = Open3.capture2e(<<~BASH
+      bash -c 'source "#{ENV['HOME']}/.sdkman/bin/sdkman-init.sh" && \
+               #{cmd} > #{files[:stdout]} 2> #{files[:stderr]}; \
+               echo "$?" > #{files[:status]}; \
+               env > #{files[:env]}; \
+              '
+    BASH
+    )
+
+    unless status.success?
+      warn(out)
+      raise "Bash command failed: #{out}"
+    end
+
+    {
+      status: File.read(files[:status]).to_i,
+      stdout: File.readlines(files[:stdout]),
+      stderr: File.readlines(files[:stderr]),
+      env: File.readlines(files[:env])
+    }
+  end
 end
 
+# # For nicer diffs: one entry per line, sorted
+# string split ":" (cat path_bash) | sort > path_bash
+# string split ":" (cat path_fish) \
+#       | string split " " \
+#       | sort > path_fish
+# # split by spaces for fish 2.*
+
 def run_fish_command(cmd)
-  # NB: Fish errors out if we don't set terminal dimensions
-  stdout, stderr, status = Open3.capture3("fish -c 'stty rows 80 columns 80; #{cmd}'")
-  unless status.success?
-    warn(stderr)
-    raise 'Fish command failed'
-  end
+  Dir.mktmpdir(%w[sdkman-for-fish-test_ _fish]) do |tmp_dir|
+    files = %i[status stdout stderr env].map { |s|
+      [s, FileUtils.touch("#{tmp_dir}/#{s}")[0]]
+    }.to_h
 
-  stdout
+    out, status = Open3.capture2e(<<~FISH
+      fish -c '#{cmd} > #{files[:stdout]} ^ #{files[:stderr]}; \
+               echo $status > #{files[:status]}; \
+               env > #{files[:env]}; \
+              '
+    FISH
+    )
+
+    unless status.success?
+      warn(out)
+      raise "Fish command failed: #{out}"
+    end
+
+    {
+      status: File.read(files[:status]).to_i,
+      stdout: File.readlines(files[:stdout]),
+      stderr: File.readlines(files[:stderr]),
+      env: File.readlines(files[:env])
+    }
+  end
 end

test/features/support/parameter_types.rb

@@ -19,3 +19,12 @@ ParameterType(
                    end
                end
 )
+
+ParameterType(
+  name: 'env_glob',
+  regexp: /[A-Z_*]+/,
+  type: Regexp,
+  transformer: lambda do |glob|
+    /^#{glob.gsub('*', '[A-Z_]*')}=/
+  end
+)