erik/urlencoder-java
erik/urlencoder-java
1
0
Fork 0
mirror of https://github.com/gbevin/urlencoder.git synced 2025-04-25 07:17:11 -07:00
Code Issues Projects Releases Packages Wiki Activity

Handle more invalid CLI argument usages.

Browse source
This commit is contained in:
Geert Bevin 2023-01-01 17:13:28 -05:00
parent ca82b1ec6d
commit 97bc6137a3
2 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/src/main/java/com/uwyn/urlencoder/UrlEncoder.java
View file

@ -237,9 +237,9 @@ public final class UrlEncoder {
var option = args.remove(0); var option = args.remove(0);
if (option.equals("-d")) { if (option.equals("-d")) {
perform_decode = true; perform_decode = true;
valid_arguments = !args.isEmpty(); valid_arguments = (args.size() == 1);
} else if (option.equals("-e")) { } else if (option.equals("-e")) {
valid_arguments = !args.isEmpty(); valid_arguments = (args.size() == 1);
} else { } else {
args.clear(); args.clear();
} }

14
lib/src/test/java/com/uwyn/urlencoder/UrlEncoderTest.java
View file

@ -94,6 +94,20 @@ class UrlEncoderTest {
assertTrue(result.output.contains("Usage :")); assertTrue(result.output.contains("Usage :"));
} }
@Test
void testMainWrongArgs4() {
var result = UrlEncoder.processMain(new String[] {"-d", "stuff", "txt"});
assertEquals(1, result.status);
assertTrue(result.output.contains("Usage :"));
}
@Test
void testMainWrongArgs5() {
var result = UrlEncoder.processMain(new String[] {"-e", "stuff", "txt"});
assertEquals(1, result.status);
assertTrue(result.output.contains("Usage :"));
}
@Test @Test
void testDecodeMainOption() { void testDecodeMainOption() {
validMap.forEach((expected, source) -> { validMap.forEach((expected, source) -> {