erik/urlencoder-java
erik/urlencoder-java
1
0
Fork 0
mirror of https://github.com/gbevin/urlencoder.git synced 2025-04-25 07:17:11 -07:00
Code Issues Projects Releases Packages Wiki Activity

Code cleanups

Browse source
This commit is contained in:
Geert Bevin 2022-12-31 08:08:47 -05:00
parent a53a9c4f76
commit fc251e2073
2 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/src/main/java/com/uwyn/urlencoder/UrlEncoder.java
View file

@ -15,7 +15,7 @@ import java.util.BitSet;
* @author Geert Bevin (gbevin[remove] at uwyn dot com) * @author Geert Bevin (gbevin[remove] at uwyn dot com)
* @since 1.0 * @since 1.0
*/ */
public class UrlEncoder { public abstract class UrlEncoder {
static final BitSet UNRESERVED_URI_CHARS; static final BitSet UNRESERVED_URI_CHARS;
private static final char[] HEX_DIGITS = "0123456789ABCDEF".toCharArray(); private static final char[] HEX_DIGITS = "0123456789ABCDEF".toCharArray();
@ -61,7 +61,8 @@ public class UrlEncoder {
char ch; char ch;
byte[] bytes_buffer = null; byte[] bytes_buffer = null;
var bytes_pos = 0; var bytes_pos = 0;
for (var i = 0; i < length; ) { var i = 0;
while(i < length) {
ch = source.charAt(i); ch = source.charAt(i);
if (ch == '%') { if (ch == '%') {

4
lib/src/test/java/com/uwyn/urlencoder/UrlEncoderTest.java
View file

@ -21,7 +21,7 @@ class UrlEncoderTest {
); );
@Test @Test
public void testDecodeURL() { void testDecodeURL() {
assertNull(UrlEncoder.decode(null)); assertNull(UrlEncoder.decode(null));
assertSame(same, UrlEncoder.decode(same)); assertSame(same, UrlEncoder.decode(same));
validMap.forEach((expected, source) -> assertEquals(expected, UrlEncoder.decode(source))); validMap.forEach((expected, source) -> assertEquals(expected, UrlEncoder.decode(source)));
@ -32,7 +32,7 @@ class UrlEncoderTest {
} }
@Test @Test
public void testEncodeURL() { void testEncodeURL() {
assertNull(UrlEncoder.encode(null)); assertNull(UrlEncoder.encode(null));
assertTrue(UrlEncoder.encode("").isEmpty()); assertTrue(UrlEncoder.encode("").isEmpty());
assertSame(same, UrlEncoder.encode(same)); assertSame(same, UrlEncoder.encode(same));