erik/version-processor
erik/version-processor
1
0
Fork 0
mirror of https://github.com/ethauvin/version-processor.git synced 2025-04-24 15:37:12 -07:00
Code Releases Activity

Merge pull request #1 from ethauvin/master

Browse source 
Fixed property file left open after reading.
This commit is contained in:
Cedric Beust 2016-01-17 21:55:08 -08:00
commit 60f0f316c5
1 changed files with 11 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

20
processor/src/main/java/com/beust/version/VersionProcessor.java
View file

@ -48,12 +48,12 @@ public class VersionProcessor extends AbstractProcessor {
if (versionValue != null) { if (versionValue != null) {
log("Version value found: " + versionValue); log("Version value found: " + versionValue);
jfo = filer.createSourceFile(packageName + ".GeneratedVersion"); jfo = filer.createSourceFile(packageName + ".GeneratedVersion");
BufferedWriter writer = new BufferedWriter(jfo.openWriter()); try (BufferedWriter writer = new BufferedWriter(jfo.openWriter())) {
writer.write("package " + packageName + ";\n\n"); writer.write("package " + packageName + ";\n\n");
writer.write("public class GeneratedVersion {\n"); writer.write("public class GeneratedVersion {\n");
writer.write(" public static final String VERSION = \"" + versionValue + "\";\n"); writer.write(" public static final String VERSION = \"" + versionValue + "\";\n");
writer.write("}\n"); writer.write("}\n");
writer.close(); }
log("Generated " + jfo.getName()); log("Generated " + jfo.getName());
} else { } else {
error("Need to specify either @Version(value) or @Version(fileName)"); error("Need to specify either @Version(value) or @Version(fileName)");
@ -79,9 +79,10 @@ public class VersionProcessor extends AbstractProcessor {
if (f.exists()) { if (f.exists()) {
log("Found " + f); log("Found " + f);
Properties p = new Properties(); Properties p = new Properties();
p.load(new FileReader(f)); try (FileReader r = new FileReader(f)) {
String result = p.getProperty(version.propertyName()); p.load(r);
return result; return p.getProperty(version.propertyName());
}
} else { } else {
error("Couldn't find " + version.fileName()); error("Couldn't find " + version.fileName());
} }
@ -90,6 +91,7 @@ public class VersionProcessor extends AbstractProcessor {
return null; return null;
} }
@Override
public Set<String> getSupportedAnnotationTypes() { public Set<String> getSupportedAnnotationTypes() {
Set<String> result = new HashSet<>(); Set<String> result = new HashSet<>();
result.add(Version.class.getCanonicalName()); result.add(Version.class.getCanonicalName());