From 83ecfe37a71c9434721fc5c752daa98dfeabc796 Mon Sep 17 00:00:00 2001 From: "Erik C. Thauvin" Date: Sun, 17 Jan 2016 11:20:26 -0800 Subject: [PATCH] Added try-with-resources whenever applicable. --- .../com/beust/version/VersionProcessor.java | 21 +++++++++---------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/processor/src/main/java/com/beust/version/VersionProcessor.java b/processor/src/main/java/com/beust/version/VersionProcessor.java index 11d66e4..1ad3fb7 100644 --- a/processor/src/main/java/com/beust/version/VersionProcessor.java +++ b/processor/src/main/java/com/beust/version/VersionProcessor.java @@ -48,12 +48,12 @@ public class VersionProcessor extends AbstractProcessor { if (versionValue != null) { log("Version value found: " + versionValue); jfo = filer.createSourceFile(packageName + ".GeneratedVersion"); - BufferedWriter writer = new BufferedWriter(jfo.openWriter()); - writer.write("package " + packageName + ";\n\n"); - writer.write("public class GeneratedVersion {\n"); - writer.write(" public static final String VERSION = \"" + versionValue + "\";\n"); - writer.write("}\n"); - writer.close(); + try (BufferedWriter writer = new BufferedWriter(jfo.openWriter())) { + writer.write("package " + packageName + ";\n\n"); + writer.write("public class GeneratedVersion {\n"); + writer.write(" public static final String VERSION = \"" + versionValue + "\";\n"); + writer.write("}\n"); + } log("Generated " + jfo.getName()); } else { error("Need to specify either @Version(value) or @Version(fileName)"); @@ -79,11 +79,10 @@ public class VersionProcessor extends AbstractProcessor { if (f.exists()) { log("Found " + f); Properties p = new Properties(); - FileReader r = new FileReader(f); - p.load(r); - String result = p.getProperty(version.propertyName()); - r.close(); - return result; + try (FileReader r = new FileReader(f)) { + p.load(r); + return p.getProperty(version.propertyName()); + } } else { error("Couldn't find " + version.fileName()); }