From ce22d079779d64de7cce384a5fcccd2a0c4628f9 Mon Sep 17 00:00:00 2001
From: "Erik C. Thauvin" <erik@thauvin.net>
Date: Wed, 30 Aug 2023 22:02:45 -0700
Subject: [PATCH] Minor cleanup

---
 .github/workflows/bld.yml                     | 32 -----------
 .github/workflows/pages.yml                   | 57 -------------------
 .idea/misc.xml                                |  4 +-
 README.md                                     |  0
 .../inspectionProfiles/Project_Default.xml    |  8 +++
 examples/.idea/misc.xml                       |  7 ++-
 examples/.idea/vcs.xml                        |  6 ++
 pages.yml                                     | 57 -------------------
 .../bld/extension/CheckstyleOperation.java    | 10 ++--
 9 files changed, 27 insertions(+), 154 deletions(-)
 mode change 100755 => 100644 README.md
 create mode 100644 examples/.idea/inspectionProfiles/Project_Default.xml
 create mode 100644 examples/.idea/vcs.xml
 delete mode 100644 pages.yml

diff --git a/.github/workflows/bld.yml b/.github/workflows/bld.yml
index 2b0ba38..e69de29 100644
--- a/.github/workflows/bld.yml
+++ b/.github/workflows/bld.yml
@@ -1,32 +0,0 @@
-name: bld-ci
-
-on: [ push, pull_request, workflow_dispatch ]
-
-jobs:
-  build-bld-project:
-    runs-on: ubuntu-latest
-
-    strategy:
-      matrix:
-        java-version: [ 17, 20 ]
-
-    steps:
-      - name: Checkout source repository
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
-
-      - name: Set up JDK ${{ matrix.java-version }}
-        uses: actions/setup-java@v3
-        with:
-          distribution: 'zulu'
-          java-version: ${{ matrix.java-version }}
-
-      - name: Grant execute permission for bld
-        run: chmod +x bld
-
-      - name: Download the dependencies
-        run: ./bld download
-
-      - name: Run tests with bld
-        run: ./bld compile test
diff --git a/.github/workflows/pages.yml b/.github/workflows/pages.yml
index f6122cd..e69de29 100644
--- a/.github/workflows/pages.yml
+++ b/.github/workflows/pages.yml
@@ -1,57 +0,0 @@
-name: javadocs-pages
-
-on:
-  # Runs on pushes targeting the default branch
-  push:
-    branches: ["master"]
-
-  # Allows you to run this workflow manually from the Actions tab
-  workflow_dispatch:
-
-# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
-permissions:
-  contents: read
-  pages: write
-  id-token: write
-
-# Allow one concurrent deployment
-concurrency:
-  group: "pages"
-  cancel-in-progress: true
-
-jobs:
-  # Single deploy job since we're just deploying
-  deploy:
-    environment:
-      name: github-pages
-      url: ${{ steps.deployment.outputs.page_url }}
-
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout source repository
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
-
-      - name: Set up JDK 17
-        uses: actions/setup-java@v3
-        with:
-          distribution: 'zulu'
-          java-version: 17
-
-      - name: Build Javadocs
-        run: ./bld download clean javadoc
-
-      - name: Setup Pages
-        uses: actions/configure-pages@v3
-
-      - name: Upload artifact
-        uses: actions/upload-pages-artifact@v1
-        with:
-          # Upload generated Javadocs repository
-          path: 'build/javadoc/'
-
-      - name: Deploy to GitHub Pages
-        id: deployment
-        uses: actions/deploy-pages@v1
\ No newline at end of file
diff --git a/.idea/misc.xml b/.idea/misc.xml
index af10cee..083a492 100644
--- a/.idea/misc.xml
+++ b/.idea/misc.xml
@@ -8,7 +8,9 @@
   <component name="PDMPlugin">
     <option name="customRuleSets">
       <list>
-        <option value="$PROJECT_DIR$/../bld-exec/config/pmd.xml" />
+        <option value="$PROJECT_DIR$/config/pmd.xml" />
+        <option value="K:\java\semver\config\pmd.xml" />
+        <option value="$PROJECT_DIR$/../bld-pmd/config/pmd.xml" />
       </list>
     </option>
     <option name="skipTestSources" value="false" />
diff --git a/README.md b/README.md
old mode 100755
new mode 100644
diff --git a/examples/.idea/inspectionProfiles/Project_Default.xml b/examples/.idea/inspectionProfiles/Project_Default.xml
new file mode 100644
index 0000000..1e01b48
--- /dev/null
+++ b/examples/.idea/inspectionProfiles/Project_Default.xml
@@ -0,0 +1,8 @@
+<component name="InspectionProjectProfileManager">
+  <profile version="1.0">
+    <option name="myName" value="Project Default" />
+    <inspection_tool class="JavadocDeclaration" enabled="true" level="WARNING" enabled_by_default="true">
+      <option name="ADDITIONAL_TAGS" value="created" />
+    </inspection_tool>
+  </profile>
+</component>
\ No newline at end of file
diff --git a/examples/.idea/misc.xml b/examples/.idea/misc.xml
index 542659b..7e477ca 100644
--- a/examples/.idea/misc.xml
+++ b/examples/.idea/misc.xml
@@ -1,9 +1,14 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project version="4">
   <component name="PDMPlugin">
+    <option name="customRuleSets">
+      <list>
+        <option value="$PROJECT_DIR$/config/pmd.xml" />
+      </list>
+    </option>
     <option name="skipTestSources" value="false" />
   </component>
   <component name="ProjectRootManager" version="2" languageLevel="JDK_17" project-jdk-name="17" project-jdk-type="JavaSDK">
     <output url="file://$PROJECT_DIR$/build" />
   </component>
-</project>
\ No newline at end of file
+</project>
diff --git a/examples/.idea/vcs.xml b/examples/.idea/vcs.xml
new file mode 100644
index 0000000..6c0b863
--- /dev/null
+++ b/examples/.idea/vcs.xml
@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project version="4">
+  <component name="VcsDirectoryMappings">
+    <mapping directory="$PROJECT_DIR$/.." vcs="Git" />
+  </component>
+</project>
\ No newline at end of file
diff --git a/pages.yml b/pages.yml
deleted file mode 100644
index f6122cd..0000000
--- a/pages.yml
+++ /dev/null
@@ -1,57 +0,0 @@
-name: javadocs-pages
-
-on:
-  # Runs on pushes targeting the default branch
-  push:
-    branches: ["master"]
-
-  # Allows you to run this workflow manually from the Actions tab
-  workflow_dispatch:
-
-# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
-permissions:
-  contents: read
-  pages: write
-  id-token: write
-
-# Allow one concurrent deployment
-concurrency:
-  group: "pages"
-  cancel-in-progress: true
-
-jobs:
-  # Single deploy job since we're just deploying
-  deploy:
-    environment:
-      name: github-pages
-      url: ${{ steps.deployment.outputs.page_url }}
-
-    runs-on: ubuntu-latest
-
-    steps:
-      - name: Checkout source repository
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
-
-      - name: Set up JDK 17
-        uses: actions/setup-java@v3
-        with:
-          distribution: 'zulu'
-          java-version: 17
-
-      - name: Build Javadocs
-        run: ./bld download clean javadoc
-
-      - name: Setup Pages
-        uses: actions/configure-pages@v3
-
-      - name: Upload artifact
-        uses: actions/upload-pages-artifact@v1
-        with:
-          # Upload generated Javadocs repository
-          path: 'build/javadoc/'
-
-      - name: Deploy to GitHub Pages
-        id: deployment
-        uses: actions/deploy-pages@v1
\ No newline at end of file
diff --git a/src/main/java/rife/bld/extension/CheckstyleOperation.java b/src/main/java/rife/bld/extension/CheckstyleOperation.java
index 922bb0b..8237736 100644
--- a/src/main/java/rife/bld/extension/CheckstyleOperation.java
+++ b/src/main/java/rife/bld/extension/CheckstyleOperation.java
@@ -92,8 +92,8 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
      *
      * @see #exclude(String...)
      */
-    public CheckstyleOperation exclude(Collection<String> path) {
-        for (var p : path) {
+    public CheckstyleOperation exclude(Collection<String> paths) {
+        for (var p : paths) {
             options.put("-e", p);
         }
         return this;
@@ -110,8 +110,6 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
     /**
      * Part of the {@link #execute} operation, constructs the command list
      * to use for building the process.
-     *
-     * @since 1.5
      */
     @Override
     protected List<String> executeConstructProcessCommandList() {
@@ -247,8 +245,8 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
      *
      * @see #sourceDir(String...)
      */
-    public CheckstyleOperation sourceDir(Collection<String> dir) {
-        sourceDirs.addAll(dir);
+    public CheckstyleOperation sourceDir(Collection<String> dirs) {
+        sourceDirs.addAll(dirs);
         return this;
     }