From d7d9cdf98cbb0b55e232bfb3f863f95725fbb43f Mon Sep 17 00:00:00 2001 From: "Erik C. Thauvin" Date: Mon, 29 Apr 2024 04:05:22 -0700 Subject: [PATCH] Avoid duplicate literals (PMD) --- .../rife/bld/extension/CheckstyleOperationTest.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/test/java/rife/bld/extension/CheckstyleOperationTest.java b/src/test/java/rife/bld/extension/CheckstyleOperationTest.java index 9273bcd..039744a 100644 --- a/src/test/java/rife/bld/extension/CheckstyleOperationTest.java +++ b/src/test/java/rife/bld/extension/CheckstyleOperationTest.java @@ -59,19 +59,21 @@ class CheckstyleOperationTest { @Test void exclude() { var op = new CheckstyleOperation().fromProject(new Project()).exclude(FOO, BAR); - assertThat(op.executeConstructProcessCommandList()).contains("-e " + FOO, "-e " + BAR); + var e = "-e "; + assertThat(op.executeConstructProcessCommandList()).contains(e + FOO, e + BAR); op = new CheckstyleOperation().fromProject(new Project()).exclude(List.of(FOO, BAR)); - assertThat(op.executeConstructProcessCommandList()).as("as list").contains("-e " + FOO, "-e " + BAR); + assertThat(op.executeConstructProcessCommandList()).as("as list").contains(e + FOO, e + BAR); } @Test void excludeRegex() { var op = new CheckstyleOperation().fromProject(new Project()).excludeRegex(FOO, BAR); - assertThat(op.executeConstructProcessCommandList()).contains("-x " + FOO, "-x " + BAR); + var x = "-x "; + assertThat(op.executeConstructProcessCommandList()).contains(x + FOO, x + BAR); op = new CheckstyleOperation().fromProject(new Project()).excludeRegex(List.of(FOO, BAR)); - assertThat(op.executeConstructProcessCommandList()).as("as list").contains("-x " + FOO, "-x " + BAR); + assertThat(op.executeConstructProcessCommandList()).as("as list").contains(x + FOO, x + BAR); }