Compare commits

..

No commits in common. "master" and "1.0.1" have entirely different histories.

32 changed files with 295 additions and 640 deletions

View file

@ -1,16 +1,14 @@
name: bld-ci name: bld-ci
on: [ push, pull_request, workflow_dispatch ] on: [push, pull_request, workflow_dispatch]
jobs: jobs:
build-bld-project: build-bld-project:
runs-on: ubuntu-latest
strategy: strategy:
matrix: matrix:
java-version: [ 17, 21, 24 ] java-version: [17, 21, 22]
kotlin-version: [ 1.9.25, 2.0.21, 2.1.20 ]
os: [ ubuntu-latest, windows-latest, macos-latest ]
runs-on: ${{ matrix.os }}
steps: steps:
- name: Checkout source repository - name: Checkout source repository
@ -24,16 +22,11 @@ jobs:
distribution: "zulu" distribution: "zulu"
java-version: ${{ matrix.java-version }} java-version: ${{ matrix.java-version }}
- name: Download dependencies [examples] - name: Grant execute permission for bld
working-directory: examples run: chmod +x bld
- name: Download the dependencies
run: ./bld download run: ./bld download
- name: Compile and Run Checkstyle [examples] - name: Run tests with bld
working-directory: examples
run: ./bld compile checkstyle-custom
- name: Download dependencies
run: ./bld download
- name: Run tests
run: ./bld compile test run: ./bld compile test

View file

@ -47,11 +47,11 @@ jobs:
uses: actions/configure-pages@v3 uses: actions/configure-pages@v3
- name: Upload artifact - name: Upload artifact
uses: actions/upload-pages-artifact@v3 uses: actions/upload-pages-artifact@v1
with: with:
# Upload generated Javadocs repository # Upload generated Javadocs repository
path: "build/javadoc/" path: "build/javadoc/"
- name: Deploy to GitHub Pages - name: Deploy to GitHub Pages
id: deployment id: deployment
uses: actions/deploy-pages@v4 uses: actions/deploy-pages@v1

6
.idea/bld.xml generated
View file

@ -1,6 +0,0 @@
<?xml version="1.0" encoding="UTF-8"?>
<project version="4">
<component name="BldConfiguration">
<events />
</component>
</project>

View file

@ -1,5 +0,0 @@
<component name="ProjectCodeStyleConfiguration">
<state>
<option name="PREFERRED_PROJECT_CODE_STYLE" value="Erik's Code Style" />
</state>
</component>

13
.idea/icon.svg generated
View file

@ -1,13 +0,0 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg width="100%" height="100%" viewBox="0 0 179 108" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" xml:space="preserve" xmlns:serif="http://www.serif.com/" style="fill-rule:evenodd;clip-rule:evenodd;stroke-linejoin:round;stroke-miterlimit:2;">
<g transform="matrix(1,0,0,1,-210.511,-96.3382)">
<g transform="matrix(1,0,0,1,-23.3386,-649.816)">
<g transform="matrix(0.221288,0,0,0.24,73.9536,390.254)">
<path d="M722.568,1482.92L722.568,1921.1L808.968,1921.1L808.968,1888.7C822.168,1907.9 846.168,1930.1 893.568,1930.1C933.168,1930.1 961.968,1917.5 985.368,1893.5C1012.97,1865.9 1027.37,1827.5 1027.37,1786.1C1027.37,1741.7 1011.17,1705.1 985.368,1680.5C961.968,1658.3 928.968,1644.5 892.368,1644.5C862.968,1644.5 830.568,1654.1 808.968,1683.5L808.968,1482.92L722.568,1482.92ZM871.368,1718.9C888.768,1718.9 903.768,1723.7 917.568,1736.9C930.168,1748.9 938.568,1766.3 938.568,1787.9C938.568,1807.7 930.168,1825.1 917.568,1837.1C904.368,1849.7 887.568,1855.7 872.568,1855.7C856.368,1855.7 837.168,1849.1 823.368,1835.9C813.168,1826.3 803.568,1810.1 803.568,1787.9C803.568,1765.1 812.568,1749.5 822.768,1738.7C836.568,1724.3 852.768,1718.9 871.368,1718.9Z" style="fill:rgb(35,146,255);fill-rule:nonzero;"/>
<rect x="1083.77" y="1482.92" width="86.4" height="438.182" style="fill:rgb(250,144,82);fill-rule:nonzero;"/>
<path d="M1531.37,1482.92L1444.97,1482.92L1444.97,1683.5C1423.37,1654.1 1390.97,1644.5 1361.57,1644.5C1324.97,1644.5 1291.97,1658.3 1268.57,1680.5C1242.77,1705.1 1226.57,1741.7 1226.57,1786.1C1226.57,1827.5 1240.97,1865.9 1268.57,1893.5C1291.97,1917.5 1320.77,1930.1 1360.37,1930.1C1407.77,1930.1 1431.77,1907.9 1444.97,1888.7L1444.97,1921.1L1531.37,1921.1L1531.37,1482.92ZM1382.57,1718.9C1401.17,1718.9 1417.37,1724.3 1431.17,1738.7C1441.37,1749.5 1450.37,1765.1 1450.37,1787.9C1450.37,1810.1 1440.77,1826.3 1430.57,1835.9C1416.77,1849.1 1397.57,1855.7 1381.37,1855.7C1366.37,1855.7 1349.57,1849.7 1336.37,1837.1C1323.77,1825.1 1315.37,1807.7 1315.37,1787.9C1315.37,1766.3 1323.77,1748.9 1336.37,1736.9C1350.17,1723.7 1365.17,1718.9 1382.57,1718.9Z" style="fill:rgb(35,146,255);fill-rule:nonzero;"/>
</g>
</g>
</g>
</svg>

Before

Width:  |  Height:  |  Size: 2.4 KiB

View file

@ -2,12 +2,12 @@
<library name="bld"> <library name="bld">
<CLASSES> <CLASSES>
<root url="file://$PROJECT_DIR$/lib/bld" /> <root url="file://$PROJECT_DIR$/lib/bld" />
<root url="jar://$USER_HOME$/.bld/dist/bld-2.2.1.jar!/" /> <root url="jar://$USER_HOME$/.bld/dist/bld-1.9.1.jar!/" />
</CLASSES> </CLASSES>
<JAVADOC /> <JAVADOC />
<SOURCES> <SOURCES>
<root url="file://$PROJECT_DIR$/lib/bld" /> <root url="file://$PROJECT_DIR$/lib/bld" />
<root url="jar://$USER_HOME$/.bld/dist/bld-2.2.1-sources.jar!/" /> <root url="jar://$USER_HOME$/.bld/dist/bld-1.9.1-sources.jar!/" />
</SOURCES> </SOURCES>
<excluded> <excluded>
<root url="jar://$PROJECT_DIR$/lib/bld/bld-wrapper.jar!/" /> <root url="jar://$PROJECT_DIR$/lib/bld/bld-wrapper.jar!/" />

View file

@ -7,7 +7,7 @@
<SOURCES> <SOURCES>
<root url="file://$PROJECT_DIR$/lib/compile" /> <root url="file://$PROJECT_DIR$/lib/compile" />
</SOURCES> </SOURCES>
<jarDirectory url="file://$PROJECT_DIR$/lib/compile" recursive="true" /> <jarDirectory url="file://$PROJECT_DIR$/lib/compile" recursive="false" />
<jarDirectory url="file://$PROJECT_DIR$/lib/compile" recursive="true" type="SOURCES" /> <jarDirectory url="file://$PROJECT_DIR$/lib/compile" recursive="false" type="SOURCES" />
</library> </library>
</component> </component>

View file

@ -8,7 +8,7 @@
<SOURCES> <SOURCES>
<root url="file://$PROJECT_DIR$/lib/runtime" /> <root url="file://$PROJECT_DIR$/lib/runtime" />
</SOURCES> </SOURCES>
<jarDirectory url="file://$PROJECT_DIR$/lib/runtime" recursive="true" /> <jarDirectory url="file://$PROJECT_DIR$/lib/runtime" recursive="false" />
<jarDirectory url="file://$PROJECT_DIR$/lib/runtime" recursive="true" type="SOURCES" /> <jarDirectory url="file://$PROJECT_DIR$/lib/runtime" recursive="false" type="SOURCES" />
</library> </library>
</component> </component>

View file

@ -8,7 +8,7 @@
<SOURCES> <SOURCES>
<root url="file://$PROJECT_DIR$/lib/test" /> <root url="file://$PROJECT_DIR$/lib/test" />
</SOURCES> </SOURCES>
<jarDirectory url="file://$PROJECT_DIR$/lib/test" recursive="true" /> <jarDirectory url="file://$PROJECT_DIR$/lib/test" recursive="false" />
<jarDirectory url="file://$PROJECT_DIR$/lib/test" recursive="true" type="SOURCES" /> <jarDirectory url="file://$PROJECT_DIR$/lib/test" recursive="false" type="SOURCES" />
</library> </library>
</component> </component>

View file

@ -9,7 +9,7 @@
], ],
"java.configuration.updateBuildConfiguration": "automatic", "java.configuration.updateBuildConfiguration": "automatic",
"java.project.referencedLibraries": [ "java.project.referencedLibraries": [
"${HOME}/.bld/dist/bld-2.2.1.jar", "${HOME}/.bld/dist/bld-1.9.1.jar",
"lib/**/*.jar" "lib/**/*.jar"
], ],
"java.compile.nullAnalysis.mode": "automatic" "java.compile.nullAnalysis.mode": "automatic"

View file

@ -1,21 +1,13 @@
# [Checkstyle](https://checkstyle.sourceforge.io/) Extension for [b<span style="color:orange">l</span>d](https://rife2.com/bld) # [Checkstyle](https://checkstyle.sourceforge.io/) Extension for [b<span style="color:orange">l</span>d](https://rife2.com/bldb)
[![License](https://img.shields.io/badge/license-Apache%20License%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0) [![License](https://img.shields.io/badge/license-Apache%20License%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)
[![Java](https://img.shields.io/badge/java-17%2B-blue)](https://www.oracle.com/java/technologies/javase/jdk17-archive-downloads.html) [![Java](https://img.shields.io/badge/java-17%2B-blue)](https://www.oracle.com/java/technologies/javase/jdk17-archive-downloads.html)
[![bld](https://img.shields.io/badge/2.2.1-FA9052?label=bld&labelColor=2392FF)](https://rife2.com/bld) [![bld](https://img.shields.io/badge/1.9.1-FA9052?label=bld&labelColor=2392FF)](https://rife2.com/bld)
[![Release](https://flat.badgen.net/maven/v/metadata-url/repo.rife2.com/releases/com/uwyn/rife2/bld-checkstyle/maven-metadata.xml?color=blue)](https://repo.rife2.com/#/releases/com/uwyn/rife2/bld-checkstyle) [![Release](https://flat.badgen.net/maven/v/metadata-url/repo.rife2.com/releases/com/uwyn/rife2/bld-checkstyle/maven-metadata.xml?color=blue)](https://repo.rife2.com/#/releases/com/uwyn/rife2/bld-checkstyle)
[![Snapshot](https://flat.badgen.net/maven/v/metadata-url/repo.rife2.com/snapshots/com/uwyn/rife2/bld-checkstyle/maven-metadata.xml?label=snapshot)](https://repo.rife2.com/#/snapshots/com/uwyn/rife2/bld-checkstyle) [![Snapshot](https://flat.badgen.net/maven/v/metadata-url/repo.rife2.com/snapshots/com/uwyn/rife2/bld-checkstyle/maven-metadata.xml?label=snapshot)](https://repo.rife2.com/#/snapshots/com/uwyn/rife2/bld-checkstyle)
[![GitHub CI](https://github.com/rife2/bld-checkstyle/actions/workflows/bld.yml/badge.svg)](https://github.com/rife2/bld-checkstyle/actions/workflows/bld.yml) [![GitHub CI](https://github.com/rife2/bld-checkstyle/actions/workflows/bld.yml/badge.svg)](https://github.com/rife2/bld-checkstyle/actions/workflows/bld.yml)
To install the latest version, add the following to the `lib/bld/bld-wrapper.properties` file: To install, please refer to the [extensions documentation](https://github.com/rife2/bld/wiki/Extensions).
```properties
bld.extension-checkstyle=com.uwyn.rife2:bld-checkstyle
```
For more information, please refer to the [extensions](https://github.com/rife2/bld/wiki/Extensions) documentation.
## Check Source Code with Checkstyle
To check your code with Chesktyle, include the following in your build file: To check your code with Chesktyle, include the following in your build file:
@ -45,5 +37,5 @@ not provided by the extension. For example:
```java ```java
repositories = List.of(MAVEN_CENTRAL); repositories = List.of(MAVEN_CENTRAL);
scope(test).include(dependency("com.puppycrawl.tools", "checkstyle", version(10, 23, 0))); scope(test).include(dependency("com.puppycrawl.tools", "checkstyle", version(10, 17, 0)));
``` ```

16
checkcliargs.sh Executable file
View file

@ -0,0 +1,16 @@
#!/bin/bash
MAIN="com.puppycrawl.tools.checkstyle.Main"
TMPNEW=/tmp/checkcliargs-new
TMPOLD=/tmp/checkcliargs-old
java -cp "lib/test/*" $MAIN --help >$TMPNEW
java -cp "examples/lib/test/*" $MAIN --help >$TMPOLD
if [ "$1" == "-v" ]; then
code --wait --diff $TMPOLD $TMPNEW
else
diff $TMPOLD $TMPNEW
fi
rm -rf $TMPNEW $TMPOLD

View file

@ -7,9 +7,9 @@
<!-- BEST PRACTICES --> <!-- BEST PRACTICES -->
<rule ref="category/java/bestpractices.xml"> <rule ref="category/java/bestpractices.xml">
<exclude name="AvoidPrintStackTrace"/> <exclude name="AvoidPrintStackTrace"/>
<exclude name="JUnit4TestShouldUseTestAnnotation"/>
<exclude name="JUnitTestContainsTooManyAsserts"/>
<exclude name="GuardLogStatement"/> <exclude name="GuardLogStatement"/>
<exclude name="UnitTestContainsTooManyAsserts"/>
<exclude name="UnitTestShouldUseTestAnnotation"/>
</rule> </rule>
<rule ref="category/java/bestpractices.xml/MissingOverride"> <rule ref="category/java/bestpractices.xml/MissingOverride">

View file

@ -2,12 +2,12 @@
<library name="bld"> <library name="bld">
<CLASSES> <CLASSES>
<root url="file://$PROJECT_DIR$/lib/bld" /> <root url="file://$PROJECT_DIR$/lib/bld" />
<root url="jar://$USER_HOME$/.bld/dist/bld-2.2.1.jar!/" /> <root url="jar://$USER_HOME$/.bld/dist/bld-1.9.1.jar!/" />
</CLASSES> </CLASSES>
<JAVADOC /> <JAVADOC />
<SOURCES> <SOURCES>
<root url="file://$PROJECT_DIR$/lib/bld" /> <root url="file://$PROJECT_DIR$/lib/bld" />
<root url="jar://$USER_HOME$/.bld/dist/bld-2.2.1-sources.jar!/" /> <root url="jar://$USER_HOME$/.bld/dist/bld-1.9.1-sources.jar!/" />
</SOURCES> </SOURCES>
<excluded> <excluded>
<root url="jar://$PROJECT_DIR$/lib/bld/bld-wrapper.jar!/" /> <root url="jar://$PROJECT_DIR$/lib/bld/bld-wrapper.jar!/" />

View file

@ -7,7 +7,7 @@
<SOURCES> <SOURCES>
<root url="file://$PROJECT_DIR$/lib/compile" /> <root url="file://$PROJECT_DIR$/lib/compile" />
</SOURCES> </SOURCES>
<jarDirectory url="file://$PROJECT_DIR$/lib/compile" recursive="true" /> <jarDirectory url="file://$PROJECT_DIR$/lib/compile" recursive="false" />
<jarDirectory url="file://$PROJECT_DIR$/lib/compile" recursive="true" type="SOURCES" /> <jarDirectory url="file://$PROJECT_DIR$/lib/compile" recursive="false" type="SOURCES" />
</library> </library>
</component> </component>

View file

@ -8,7 +8,7 @@
<SOURCES> <SOURCES>
<root url="file://$PROJECT_DIR$/lib/runtime" /> <root url="file://$PROJECT_DIR$/lib/runtime" />
</SOURCES> </SOURCES>
<jarDirectory url="file://$PROJECT_DIR$/lib/runtime" recursive="true" /> <jarDirectory url="file://$PROJECT_DIR$/lib/runtime" recursive="false" />
<jarDirectory url="file://$PROJECT_DIR$/lib/runtime" recursive="true" type="SOURCES" /> <jarDirectory url="file://$PROJECT_DIR$/lib/runtime" recursive="false" type="SOURCES" />
</library> </library>
</component> </component>

View file

@ -8,7 +8,7 @@
<SOURCES> <SOURCES>
<root url="file://$PROJECT_DIR$/lib/test" /> <root url="file://$PROJECT_DIR$/lib/test" />
</SOURCES> </SOURCES>
<jarDirectory url="file://$PROJECT_DIR$/lib/test" recursive="true" /> <jarDirectory url="file://$PROJECT_DIR$/lib/test" recursive="false" />
<jarDirectory url="file://$PROJECT_DIR$/lib/test" recursive="true" type="SOURCES" /> <jarDirectory url="file://$PROJECT_DIR$/lib/test" recursive="false" type="SOURCES" />
</library> </library>
</component> </component>

View file

@ -1,8 +1,4 @@
<project version="4"> <project version="4">
<component name="EntryPointsManager">
<pattern value="com.example.ExamplesBuild" method="checkstyle" />
<pattern value="com.example.ExamplesBuild" />
</component>
<component name="PDMPlugin"> <component name="PDMPlugin">
<option name="customRuleSets"> <option name="customRuleSets">
<list> <list>

View file

@ -9,7 +9,7 @@
], ],
"java.configuration.updateBuildConfiguration": "automatic", "java.configuration.updateBuildConfiguration": "automatic",
"java.project.referencedLibraries": [ "java.project.referencedLibraries": [
"${HOME}/.bld/dist/bld-2.2.1.jar", "${HOME}/.bld/dist/bld-1.9.1.jar",
"lib/**/*.jar" "lib/**/*.jar"
] ]
} }

Binary file not shown.

View file

@ -1,7 +1,7 @@
bld.downloadExtensionJavadoc=false bld.downloadExtensionJavadoc=false
bld.downloadExtensionSources=true bld.downloadExtensionSources=true
bld.downloadLocation= bld.extensions=com.uwyn.rife2:bld-checkstyle:1.0.1
bld.extension-checkstyle=com.uwyn.rife2:bld-checkstyle:1.0.14
bld.repositories=MAVEN_LOCAL,MAVEN_CENTRAL,RIFE2_SNAPSHOTS,RIFE2_RELEASES bld.repositories=MAVEN_LOCAL,MAVEN_CENTRAL,RIFE2_SNAPSHOTS,RIFE2_RELEASES
bld.downloadLocation=
bld.sourceDirectories= bld.sourceDirectories=
bld.version=2.2.1 bld.version=1.9.1

View file

@ -5,9 +5,6 @@ import rife.bld.BuildCommand;
import rife.bld.extension.CheckstyleOperation; import rife.bld.extension.CheckstyleOperation;
import java.util.List; import java.util.List;
import java.util.logging.ConsoleHandler;
import java.util.logging.Level;
import java.util.logging.Logger;
import static rife.bld.dependencies.Repository.MAVEN_CENTRAL; import static rife.bld.dependencies.Repository.MAVEN_CENTRAL;
import static rife.bld.dependencies.Scope.*; import static rife.bld.dependencies.Scope.*;
@ -26,26 +23,16 @@ public class ExamplesBuild extends BaseProject {
repositories = List.of(MAVEN_CENTRAL); repositories = List.of(MAVEN_CENTRAL);
scope(test).include(dependency("com.puppycrawl.tools", "checkstyle", version(10, 23, 0))); scope(test).include(dependency("com.puppycrawl.tools", "checkstyle", version(10, 17, 0)));
testOperation().mainClass("com.example.ExamplesTest"); testOperation().mainClass("com.example.ExamplesTest");
} }
public static void main(String[] args) { public static void main(String[] args) {
// Enable detailed logging for the extensions
var level = Level.ALL;
var logger = Logger.getLogger("rife.bld.extension");
var consoleHandler = new ConsoleHandler();
consoleHandler.setLevel(level);
logger.addHandler(consoleHandler);
logger.setLevel(level);
logger.setUseParentHandlers(false);
new ExamplesBuild().start(args); new ExamplesBuild().start(args);
} }
@BuildCommand(summary = "Check code style using Sun coding conventions") @BuildCommand(summary = "Check code style")
public void checkstyle() throws Exception { public void checkstyle() throws Exception {
new CheckstyleOperation() new CheckstyleOperation()
.fromProject(this) .fromProject(this)
@ -53,11 +40,4 @@ public class ExamplesBuild extends BaseProject {
.execute(); .execute();
} }
@BuildCommand(value = "checkstyle-custom", summary = "Check code style using custom coding conventions")
public void checkstyleCustom() throws Exception {
new CheckstyleOperation()
.fromProject(this)
.configurationFile("src/test/resources/checkstyle.xml")
.execute();
}
} }

View file

@ -1,10 +0,0 @@
<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.3//EN"
"http://www.puppycrawl.com/dtds/configuration_1_3.dtd">
<module name="Checker">
<module name="TreeWalker">
<module name="AvoidStarImport">
<property name="severity" value="warning" />
</module>
</module>
</module>

Binary file not shown.

View file

@ -1,8 +1,8 @@
bld.downloadExtensionJavadoc=false bld.downloadExtensionJavadoc=false
bld.downloadExtensionSources=true bld.downloadExtensionSources=true
bld.downloadLocation= bld.extension-pmd=com.uwyn.rife2:bld-pmd:0.9.9
bld.extension-exec=com.uwyn.rife2:bld-exec:1.0.5 bld.extension-jacoco=com.uwyn.rife2:bld-jacoco-report:0.9.5
bld.extension-pmd=com.uwyn.rife2:bld-pmd:1.2.2
bld.repositories=MAVEN_CENTRAL,MAVEN_LOCAL,RIFE2_SNAPSHOTS,RIFE2_RELEASES bld.repositories=MAVEN_CENTRAL,MAVEN_LOCAL,RIFE2_SNAPSHOTS,RIFE2_RELEASES
bld.downloadLocation=
bld.sourceDirectories= bld.sourceDirectories=
bld.version=2.2.1 bld.version=1.9.1

View file

@ -1,16 +0,0 @@
#!/bin/bash
main="com.puppycrawl.tools.checkstyle.Main"
new=/tmp/checkcliargs-new
old=/tmp/checkcliargs-old
java -cp "lib/test/*" $main --help >$new
java -cp "examples/lib/test/*" $main --help >$old
if [ "$1" == "-v" ]; then
code --wait --diff $old $new
else
diff $old $new
fi
rm -rf $new $old

View file

@ -1,6 +0,0 @@
#!/bin/bash
java -cp "lib/test/*" com.puppycrawl.tools.checkstyle.Main --help |\
grep "^ -.*" |\
sed -e "s/ -/-/" -e "s/[,=].*//" -e '/-V/d' -e '/-h/d' |\
sort > "src/test/resources/checkstyle-args.txt"

View file

@ -1,5 +1,5 @@
/* /*
* Copyright 2023-2025 the original author or authors. * Copyright 2023-2024 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -22,10 +22,11 @@ import rife.bld.publish.PublishDeveloper;
import rife.bld.publish.PublishLicense; import rife.bld.publish.PublishLicense;
import rife.bld.publish.PublishScm; import rife.bld.publish.PublishScm;
import java.io.IOException;
import java.util.List; import java.util.List;
import java.util.Locale;
import static rife.bld.dependencies.Repository.*; import static rife.bld.dependencies.Repository.MAVEN_CENTRAL;
import static rife.bld.dependencies.Repository.RIFE2_RELEASES;
import static rife.bld.dependencies.Scope.compile; import static rife.bld.dependencies.Scope.compile;
import static rife.bld.dependencies.Scope.test; import static rife.bld.dependencies.Scope.test;
import static rife.bld.operations.JavadocOptions.DocLinkOption.NO_MISSING; import static rife.bld.operations.JavadocOptions.DocLinkOption.NO_MISSING;
@ -34,23 +35,20 @@ public class CheckstyleOperationBuild extends Project {
public CheckstyleOperationBuild() { public CheckstyleOperationBuild() {
pkg = "rife.bld.extension"; pkg = "rife.bld.extension";
name = "CheckstyleOperation"; name = "CheckstyleOperation";
version = version(1, 0, 15, "SNAPSHOT"); version = version(1, 0, 1);
javaRelease = 17; javaRelease = 17;
downloadSources = true; downloadSources = true;
autoDownloadPurge = true; autoDownloadPurge = true;
repositories = List.of(MAVEN_CENTRAL, RIFE2_RELEASES);
repositories = List.of(MAVEN_LOCAL, MAVEN_CENTRAL, RIFE2_RELEASES, RIFE2_SNAPSHOTS);
scope(compile) scope(compile)
.include(dependency("com.uwyn.rife2", "bld", version(2, 2, 1))); .include(dependency("com.uwyn.rife2", "bld", version(1, 9, 1)));
scope(test) scope(test)
.include(dependency("com.puppycrawl.tools", "checkstyle", version(10, 23, 0))) .include(dependency("com.puppycrawl.tools", "checkstyle", version(10, 17, 0)))
.include(dependency("org.junit.jupiter", "junit-jupiter", version(5, 12, 1))) .include(dependency("org.junit.jupiter", "junit-jupiter", version(5, 10, 2)))
.include(dependency("org.junit.platform", "junit-platform-console-standalone", version(1, 12, 1))) .include(dependency("org.junit.platform", "junit-platform-console-standalone", version(1, 10, 2)))
.include(dependency("org.assertj", "assertj-core", version(3, 27, 3))); .include(dependency("org.assertj", "assertj-core", version(3, 26, 0)));
javadocOperation() javadocOperation()
.javadocOptions() .javadocOptions()
.author() .author()
@ -60,23 +58,25 @@ public class CheckstyleOperationBuild extends Project {
publishOperation() publishOperation()
.repository(version.isSnapshot() ? repository("rife2-snapshot") : repository("rife2")) .repository(version.isSnapshot() ? repository("rife2-snapshot") : repository("rife2"))
.repository(repository("github"))
.info() .info()
.groupId("com.uwyn.rife2") .groupId("com.uwyn.rife2")
.artifactId("bld-checkstyle") .artifactId("bld-checkstyle")
.description("bld Checkstyle Extension") .description("bld Checkstyle Extension")
.url("https://github.com/rife2/bld-checkstyle") .url("https://github.com/rife2/bld-checkstyle")
.developer(new PublishDeveloper() .developer(
new PublishDeveloper()
.id("ethauvin") .id("ethauvin")
.name("Erik C. Thauvin") .name("Erik C. Thauvin")
.email("erik@thauvin.net") .email("erik@thauvin.net")
.url("https://erik.thauvin.net/") .url("https://erik.thauvin.net/")
) )
.license(new PublishLicense() .license(
new PublishLicense()
.name("The Apache License, Version 2.0") .name("The Apache License, Version 2.0")
.url("https://www.apache.org/licenses/LICENSE-2.0.txt") .url("https://www.apache.org/licenses/LICENSE-2.0.txt")
) )
.scm(new PublishScm() .scm(
new PublishScm()
.connection("scm:git:https://github.com/rife2/bld-checkstyle.git") .connection("scm:git:https://github.com/rife2/bld-checkstyle.git")
.developerConnection("scm:git:git@github.com:rife2/bld-checkstyle.git") .developerConnection("scm:git:git@github.com:rife2/bld-checkstyle.git")
.url("https://github.com/rife2/bld-checkstyle") .url("https://github.com/rife2/bld-checkstyle")
@ -89,24 +89,19 @@ public class CheckstyleOperationBuild extends Project {
new CheckstyleOperationBuild().start(args); new CheckstyleOperationBuild().start(args);
} }
@BuildCommand(summary = "Generates JaCoCo Reports")
public void jacoco() throws IOException {
new JacocoReportOperation()
.fromProject(this)
.execute();
}
@BuildCommand(summary = "Runs PMD analysis") @BuildCommand(summary = "Runs PMD analysis")
public void pmd() throws Exception { public void pmd() {
new PmdOperation() new PmdOperation()
.fromProject(this) .fromProject(this)
.failOnViolation(true) .failOnViolation(true)
.ruleSets("config/pmd.xml") .ruleSets("config/pmd.xml")
.execute(); .execute();
} }
@Override
public void test() throws Exception {
var os = System.getProperty("os.name");
if (os != null && os.toLowerCase(Locale.US).contains("linux")) {
new ExecOperation()
.fromProject(this)
.command("scripts/cliargs.sh")
.execute();
}
super.test();
}
} }

View file

@ -1,5 +1,5 @@
/* /*
* Copyright 2023-2025 the original author or authors. * Copyright 2023-2004 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -14,22 +14,19 @@
* limitations under the License. * limitations under the License.
*/ */
package rife.bld.extension.checkstyle; package rife.bld.extension;
/** /**
* The Checkstyle output format for XML, sarif and default (plain) logger. * The Checkstyle output format for XML, sarif and default (plaib) logger.
*/ */
public enum OutputFormat { public enum CheckstyleFormatOption {
XML("xml"), XML("xml"),
SARIF("sarif"), SARIF("sarif"),
PLAIN("plain"); PLAIN("plain");
public final String label; public final String label;
/** CheckstyleFormatOption(String label) {
* Sets the label of this output format.
*/
OutputFormat(String label) {
this.label = label; this.label = label;
} }
} }

View file

@ -1,5 +1,5 @@
/* /*
* Copyright 2023-2025 the original author or authors. * Copyright 2023-2024 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -17,16 +17,11 @@
package rife.bld.extension; package rife.bld.extension;
import rife.bld.BaseProject; import rife.bld.BaseProject;
import rife.bld.extension.checkstyle.OutputFormat;
import rife.bld.operations.AbstractProcessOperation; import rife.bld.operations.AbstractProcessOperation;
import rife.bld.operations.exceptions.ExitStatusException;
import java.io.File;
import java.io.IOException;
import java.nio.file.Path; import java.nio.file.Path;
import java.util.*; import java.util.*;
import java.util.concurrent.ConcurrentHashMap; import java.util.concurrent.ConcurrentHashMap;
import java.util.logging.Level;
import java.util.logging.Logger; import java.util.logging.Logger;
/** /**
@ -37,11 +32,16 @@ import java.util.logging.Logger;
*/ */
public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOperation> { public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOperation> {
private static final Logger LOGGER = Logger.getLogger(CheckstyleOperation.class.getName()); private static final Logger LOGGER = Logger.getLogger(CheckstyleOperation.class.getName());
private final Collection<String> excludeRegex_ = new ArrayList<>(); protected final List<String> exclude = new ArrayList<>();
private final Collection<File> exclude_ = new ArrayList<>(); protected final List<String> excludeRegex = new ArrayList<>();
private final Map<String, String> options_ = new ConcurrentHashMap<>(); /**
private final Set<File> sourceDir_ = new TreeSet<>(); * The command line options.
*/
protected final Map<String, String> options = new ConcurrentHashMap<>();
/**
* The source files(s) or folder(s).
*/
protected final Set<String> sourceDirs = new TreeSet<>();
private BaseProject project_; private BaseProject project_;
/** /**
@ -52,7 +52,7 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
*/ */
public CheckstyleOperation branchMatchingXpath(String xPathQuery) { public CheckstyleOperation branchMatchingXpath(String xPathQuery) {
if (isNotBlank(xPathQuery)) { if (isNotBlank(xPathQuery)) {
options_.put("-b", xPathQuery); options.put("-b", xPathQuery);
} }
return this; return this;
} }
@ -67,156 +67,92 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
*/ */
public CheckstyleOperation configurationFile(String file) { public CheckstyleOperation configurationFile(String file) {
if (isNotBlank(file)) { if (isNotBlank(file)) {
options_.put("-c", file); options.put("-c", file);
} }
return this; return this;
} }
/** /**
* Specifies the location of the file that defines the configuration modules. The location can either be a * Prints all debug logging of CheckStyle utility.
* filesystem location, or a name passed to the {@link ClassLoader#getResource(String) ClassLoader.getResource() }
* method. A configuration file is required.
*
* @param file the file
* @return the checkstyle operation
*/
public CheckstyleOperation configurationFile(File file) {
return configurationFile(file.getAbsolutePath());
}
/**
* Specifies the location of the file that defines the configuration modules. The location can either be a
* filesystem location, or a name passed to the {@link ClassLoader#getResource(String) ClassLoader.getResource() }
* method. A configuration file is required.
*
* @param file the file
* @return the checkstyle operation
*/
public CheckstyleOperation configurationFile(Path file) {
return configurationFile(file.toFile().getAbsolutePath());
}
/**
* Prints all debug logging of Checkstyle utility.
* *
* @param isDebug {@code true} or {@code false} * @param isDebug {@code true} or {@code false}
* @return the checkstyle operation * @return the checkstyle operation
*/ */
public CheckstyleOperation debug(boolean isDebug) { public CheckstyleOperation debug(boolean isDebug) {
if (isDebug) { if (isDebug) {
options_.put("-d", ""); options.put("-d", "");
} else { } else {
options_.remove("-d"); options.remove("-d");
} }
return this; return this;
} }
/** /**
* Directory/file to exclude from Checkstyle. The path can be the full, absolute path, or relative to the current * Directory/file to exclude from CheckStyle. The path can be the full, absolute path, or relative to the current
* path. Multiple excludes are allowed. * path. Multiple excludes are allowed.
* *
* @param path one or more paths * @param path one or more paths
* @return the checkstyle operation * @return the checkstyle operation
* @see #excludeStrings(Collection) * @see #sourceDir(Collection)
*/ */
public CheckstyleOperation exclude(String... path) { public CheckstyleOperation exclude(String... path) {
return excludeStrings(List.of(path)); for (var p : path) {
if (isNotBlank(p)) {
exclude.add(p);
} }
/**
* Directory/file to exclude from Checkstyle. The path can be the full, absolute path, or relative to the current
* path. Multiple excludes are allowed.
*
* @param path one or more paths
* @return the checkstyle operation
* @see #exclude(Collection)
*/
public CheckstyleOperation exclude(File... path) {
return exclude(List.of(path));
} }
/**
* Directory/file to exclude from Checkstyle. The path can be the full, absolute path, or relative to the current
* path. Multiple excludes are allowed.
*
* @param path one or more paths
* @return the checkstyle operation
* @see #excludePaths(Collection)
*/
public CheckstyleOperation exclude(Path... path) {
return excludePaths(List.of(path));
}
/**
* Directory/file to exclude from Checkstyle. The path can be the full, absolute path, or relative to the current
* path. Multiple excludes are allowed.
*
* @param paths the paths
* @return the checkstyle operation
* @see #exclude(File...)
*/
public CheckstyleOperation exclude(Collection<File> paths) {
exclude_.addAll(paths);
return this; return this;
} }
/** /**
* Directory/file to exclude from Checkstyle. The path can be the full, absolute path, or relative to the current * Directory/file to exclude from CheckStyle. The path can be the full, absolute path, or relative to the current
* path. Multiple excludes are allowed.
*
* @param paths the paths
* @return the checkstyle operation
* @see #exclude(Path...)
*/
public CheckstyleOperation excludePaths(Collection<Path> paths) {
return exclude(paths.stream().map(Path::toFile).toList());
}
/**
* Directory/file pattern to exclude from Checkstyle. Multiple exclude are allowed.
*
* @param regex the pattern to exclude
* @return the checkstyle operation
* @see #excludeRegex(Collection)
*/
public CheckstyleOperation excludeRegex(String... regex) {
return excludeRegex(List.of(regex));
}
/**
* Directory/file pattern to exclude from Checkstyle. Multiple exclude are allowed.
*
* @param regex the patterns to exclude
* @return the checkstyle operation
* @see #excludeRegex(String...)
*/
public CheckstyleOperation excludeRegex(Collection<String> regex) {
excludeRegex_.addAll(regex);
return this;
}
/**
* Directory/file to exclude from Checkstyle. The path can be the full, absolute path, or relative to the current
* path. Multiple excludes are allowed. * path. Multiple excludes are allowed.
* *
* @param paths the paths * @param paths the paths
* @return the checkstyle operation * @return the checkstyle operation
* @see #exclude(String...) * @see #exclude(String...)
*/ */
public CheckstyleOperation excludeStrings(Collection<String> paths) { public CheckstyleOperation exclude(Collection<String> paths) {
return exclude(paths.stream().map(File::new).toList()); for (var p : paths) {
if (isNotBlank(p)) {
exclude.add(p);
}
}
return this;
} }
@Override /**
public void execute() throws IOException, InterruptedException, ExitStatusException { * Directory/file pattern to exclude from CheckStyle. Multiple exclude are allowed.
if (project_ == null) { *
if (LOGGER.isLoggable(Level.SEVERE) && !silent()) { * @param regex the pattern to exclude
LOGGER.severe("A project must be specified."); * @return the checkstyle operation
* @see #excludeRegex(Collection)
*/
public CheckstyleOperation excludeRegex(String... regex) {
for (var r : regex) {
if (isNotBlank(r)) {
excludeRegex.add(r);
} }
throw new ExitStatusException(ExitStatusException.EXIT_FAILURE);
} else {
super.execute();
} }
return this;
}
/**
* Directory/file pattern to exclude from CheckStyle. Multiple exclude are allowed.
*
* @param regex the patterns to exclude
* @return the checkstyle operation
* @see #excludeRegex(String...)
*/
public CheckstyleOperation excludeRegex(Collection<String> regex) {
for (var r : regex) {
if (isNotBlank(r)) {
excludeRegex.add(r);
}
}
return this;
} }
/** /**
@ -225,52 +161,46 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
*/ */
@Override @Override
protected List<String> executeConstructProcessCommandList() { protected List<String> executeConstructProcessCommandList() {
final List<String> args = new ArrayList<>(); if (project_ == null) {
LOGGER.severe("A project must be specified.");
if (project_ != null) { } else if (sourceDirs.isEmpty()) {
if (sourceDir_.isEmpty()) { sourceDirs.add(project_.srcMainJavaDirectory().getPath());
sourceDir_.add(project_.srcMainJavaDirectory()); sourceDirs.add(project_.srcTestJavaDirectory().getPath());
sourceDir_.add(project_.srcTestJavaDirectory());
} }
final List<String> args = new ArrayList<>();
args.add(javaTool()); args.add(javaTool());
args.add("-cp"); args.add("-cp");
args.add(String.format("%s%s%s%s%s%s%s", new File(project_.libTestDirectory(), "*"), args.add(String.format("%s:%s:%s:%s", Path.of(project_.libTestDirectory().getPath(), "*"),
File.pathSeparator, new File(project_.libCompileDirectory(), "*"), File.pathSeparator, Path.of(project_.libCompileDirectory().getPath(), "*"), project_.buildMainDirectory(),
project_.buildMainDirectory(), File.pathSeparator, project_.buildTestDirectory())); project_.buildTestDirectory()));
args.add("com.puppycrawl.tools.checkstyle.Main"); args.add("com.puppycrawl.tools.checkstyle.Main");
options_.forEach((k, v) -> { options.forEach((k, v) -> {
args.add(k); args.add(k);
if (!v.isEmpty()) { if (!v.isEmpty()) {
args.add(v); args.add(v);
} }
}); });
if (!exclude_.isEmpty()) { if (!exclude.isEmpty()) {
for (var e : exclude_) { for (var e : exclude) {
if (e.exists()) {
args.add("-e");
args.add(e.getAbsolutePath());
}
}
}
if (!excludeRegex_.isEmpty()) {
for (var e : excludeRegex_) {
if (isNotBlank(e)) { if (isNotBlank(e)) {
args.add("-x"); args.add("-e " + e);
args.add(e);
} }
} }
} }
args.addAll(sourceDir_.stream().map(File::getAbsolutePath).toList()); if (!excludeRegex.isEmpty()) {
for (var e : excludeRegex) {
if (isNotBlank(e)) {
args.add("-x " + e);
}
}
}
if (LOGGER.isLoggable(Level.FINE)) { args.addAll(sourceDirs);
LOGGER.log(Level.FINE, String.join(" ", args));
}
}
return args; return args;
} }
@ -292,25 +222,25 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
*/ */
public CheckstyleOperation executeIgnoredModules(boolean isAllowIgnoreModules) { public CheckstyleOperation executeIgnoredModules(boolean isAllowIgnoreModules) {
if (isAllowIgnoreModules) { if (isAllowIgnoreModules) {
options_.put("-E", ""); options.put("-E", "");
} else { } else {
options_.remove("-E"); options.remove("-E");
} }
return this; return this;
} }
/** /**
* Specifies the output format. Valid values: {@link OutputFormat#XML}, * Specifies the output format. Valid values: {@link CheckstyleFormatOption#XML},
* {@link OutputFormat#SARIF}, {@link OutputFormat#PLAIN} for the XML, sarif and default logger * {@link CheckstyleFormatOption#SARIF}, {@link CheckstyleFormatOption#PLAIN} for the XML, sarif and default logger
* respectively. * respectively.
* <p> * <p>
* Defaults to {@link OutputFormat#PLAIN}. * Defaults to {@link CheckstyleFormatOption#PLAIN}.
* *
* @param format the output format * @param format the output format
* @return the checkstyle operation * @return the checkstyle operation
*/ */
public CheckstyleOperation format(OutputFormat format) { public CheckstyleOperation format(CheckstyleFormatOption format) {
options_.put("-f", format.label.toLowerCase()); options.put("-f", format.label.toLowerCase());
return this; return this;
} }
@ -325,9 +255,9 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
*/ */
public CheckstyleOperation generateXpathSuppression(boolean xPathSuppression) { public CheckstyleOperation generateXpathSuppression(boolean xPathSuppression) {
if (xPathSuppression) { if (xPathSuppression) {
options_.put("-g", ""); options.put("-g", "");
} else { } else {
options_.remove("-g"); options.remove("-g");
} }
return this; return this;
} }
@ -349,22 +279,13 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
*/ */
public CheckstyleOperation javadocTree(boolean isTree) { public CheckstyleOperation javadocTree(boolean isTree) {
if (isTree) { if (isTree) {
options_.put("-j", ""); options.put("-j", "");
} else { } else {
options_.remove("-j"); options.remove("-j");
} }
return this; return this;
} }
/**
* Returns the command line options.
*
* @return the command line options
*/
public Map<String, String> options() {
return options_;
}
/** /**
* Sets the output file. * Sets the output file.
* <p> * <p>
@ -375,35 +296,11 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
*/ */
public CheckstyleOperation outputPath(String file) { public CheckstyleOperation outputPath(String file) {
if (isNotBlank(file)) { if (isNotBlank(file)) {
options_.put("-o", file); options.put("-o", file);
} }
return this; return this;
} }
/**
* Sets the output file.
* <p>
* Defaults to stdout.
*
* @param file the output file
* @return the checkstyle operation
*/
public CheckstyleOperation outputPath(File file) {
return outputPath(file.getAbsolutePath());
}
/**
* Sets the output file.
* <p>
* Defaults to stdout.
*
* @param file the output file
* @return the checkstyle operation
*/
public CheckstyleOperation outputPath(Path file) {
return outputPath(file.toFile().getAbsolutePath());
}
/** /**
* Sets the property files to load. * Sets the property files to load.
* *
@ -412,105 +309,33 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
*/ */
public CheckstyleOperation propertiesFile(String file) { public CheckstyleOperation propertiesFile(String file) {
if (isNotBlank(file)) { if (isNotBlank(file)) {
options_.put("-p", file); options.put("-p", file);
} }
return this; return this;
} }
/** /**
* Sets the property files to load. * Specified the file(s) or folder(s) containing the source files to check.
*
* @param file the file
* @return the checkstyle operation
*/
public CheckstyleOperation propertiesFile(File file) {
return propertiesFile(file.getAbsolutePath());
}
/**
* Sets the property files to load.
*
* @param file the file
* @return the checkstyle operation
*/
public CheckstyleOperation propertiesFile(Path file) {
return propertiesFile(file.toFile().getAbsolutePath());
}
/**
* Specifies the file(s) or folder(s) containing the source files to check.
*
* @param dir one or more directories
* @return the checkstyle operation
* @see #sourceDirStrings(Collection)
*/
public CheckstyleOperation sourceDir(String... dir) {
return sourceDirStrings(List.of(dir));
}
/**
* Specifies the file(s) or folder(s) containing the source files to check.
* *
* @param dir one or more directories * @param dir one or more directories
* @return the checkstyle operation * @return the checkstyle operation
* @see #sourceDir(Collection) * @see #sourceDir(Collection)
*/ */
public CheckstyleOperation sourceDir(File... dir) { public CheckstyleOperation sourceDir(String... dir) {
return sourceDir(List.of(dir)); sourceDirs.addAll(Arrays.stream(dir).filter(this::isNotBlank).toList());
}
/**
* Specifies the file(s) or folder(s) containing the source files to check.
*
* @param dir one or more directories
* @return the checkstyle operation
* @see #sourceDirPaths(Collection)
*/
public CheckstyleOperation sourceDir(Path... dir) {
return sourceDirPaths(List.of(dir));
}
/**
* Specifies the file(s) or folder(s) containing the source files to check.
*
* @param dirs the directories
* @return the checkstyle operation
* @see #sourceDir(File...)
*/
public CheckstyleOperation sourceDir(Collection<File> dirs) {
sourceDir_.addAll(dirs);
return this; return this;
} }
/** /**
* Returns the file(s) or folders(s) containing the sources files to check * Specified the file(s) or folder(s) containing the source files to check.
*
* @return the files or directories
*/
public Set<File> sourceDir() {
return sourceDir_;
}
/**
* Specifies the file(s) or folder(s) containing the source files to check.
*
* @param dirs the directories
* @return the checkstyle operation
* @see #sourceDir(Path...)
*/
public CheckstyleOperation sourceDirPaths(Collection<Path> dirs) {
return sourceDir(dirs.stream().map(Path::toFile).toList());
}
/**
* Specifies the file(s) or folder(s) containing the source files to check.
* *
* @param dirs the directories * @param dirs the directories
* @return the checkstyle operation * @return the checkstyle operation
* @see #sourceDir(String...) * @see #sourceDir(String...)
*/ */
public CheckstyleOperation sourceDirStrings(Collection<String> dirs) { public CheckstyleOperation sourceDir(Collection<String> dirs) {
return sourceDir(dirs.stream().map(File::new).toList()); sourceDirs.addAll(dirs.stream().filter(this::isNotBlank).toList());
return this;
} }
/** /**
@ -527,7 +352,7 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
*/ */
public CheckstyleOperation suppressionLineColumnNumber(String lineColumnNumber) { public CheckstyleOperation suppressionLineColumnNumber(String lineColumnNumber) {
if (isNotBlank(lineColumnNumber)) { if (isNotBlank(lineColumnNumber)) {
options_.put("-s", lineColumnNumber); options.put("-s", lineColumnNumber);
} }
return this; return this;
} }
@ -542,7 +367,7 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
* @return the checkstyle operation * @return the checkstyle operation
*/ */
public CheckstyleOperation tabWith(int length) { public CheckstyleOperation tabWith(int length) {
options_.put("-w", String.valueOf(length)); options.put("-w", String.valueOf(length));
return this; return this;
} }
@ -555,9 +380,9 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
*/ */
public CheckstyleOperation tree(boolean isTree) { public CheckstyleOperation tree(boolean isTree) {
if (isTree) { if (isTree) {
options_.put("-t", ""); options.put("-t", "");
} else { } else {
options_.remove("-t"); options.remove("-t");
} }
return this; return this;
} }
@ -571,9 +396,9 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
*/ */
public CheckstyleOperation treeWithComments(boolean isTree) { public CheckstyleOperation treeWithComments(boolean isTree) {
if (isTree) { if (isTree) {
options_.put("-T", ""); options.put("-T", "");
} else { } else {
options_.remove("-T"); options.remove("-T");
} }
return this; return this;
} }
@ -587,9 +412,9 @@ public class CheckstyleOperation extends AbstractProcessOperation<CheckstyleOper
*/ */
public CheckstyleOperation treeWithJavadoc(boolean isTree) { public CheckstyleOperation treeWithJavadoc(boolean isTree) {
if (isTree) { if (isTree) {
options_.put("-J", ""); options.put("-J", "");
} else { } else {
options_.remove("-J"); options.remove("-J");
} }
return this; return this;
} }

View file

@ -1,5 +1,5 @@
/* /*
* Copyright 2023-2025 the original author or authors. * Copyright 2023-2024 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,76 +16,66 @@
package rife.bld.extension; package rife.bld.extension;
import org.assertj.core.api.AutoCloseableSoftAssertions;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.EnabledOnOs;
import org.junit.jupiter.api.condition.OS;
import rife.bld.BaseProject; import rife.bld.BaseProject;
import rife.bld.Project; import rife.bld.Project;
import rife.bld.WebProject; import rife.bld.WebProject;
import rife.bld.extension.checkstyle.OutputFormat;
import rife.bld.operations.exceptions.ExitStatusException; import rife.bld.operations.exceptions.ExitStatusException;
import java.io.File; import java.io.File;
import java.io.IOException; import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.List; import java.util.List;
import java.util.logging.ConsoleHandler;
import java.util.logging.Level;
import java.util.logging.Logger;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatCode; import static org.assertj.core.api.Assertions.assertThatCode;
class CheckstyleOperationTest { class CheckstyleOperationTest {
public static final String SRC_MAIN_JAVA = "src/main/java";
public static final String SRC_TEST_JAVA = "src/test/java";
private static final String ADD = "add"; private static final String ADD = "add";
private static final String BAR = "bar"; private static final String BAR = "bar";
private static final String FOO = "foo"; private static final String FOO = "foo";
private static final String REMOVE = "remove"; private static final String REMOVE = "remove";
@BeforeAll
static void beforeAll() {
var level = Level.ALL;
var logger = Logger.getLogger("rife.bld.extension");
var consoleHandler = new ConsoleHandler();
consoleHandler.setLevel(level);
logger.addHandler(consoleHandler);
logger.setLevel(level);
logger.setUseParentHandlers(false);
}
@Test @Test
void branchMatchingXpath() { void branchMatchingXpath() {
var op = new CheckstyleOperation().fromProject(new Project()).branchMatchingXpath(FOO); var op = new CheckstyleOperation().fromProject(new Project()).branchMatchingXpath(FOO);
assertThat(op.options().get("-b")).isEqualTo(FOO); assertThat(op.options.get("-b")).isEqualTo(FOO);
} }
@Test @Test
@EnabledOnOs(OS.LINUX) void checkAllParameters() {
void checkAllParameters() throws IOException { var params = List.of(
var args = Files.readAllLines(Paths.get("src", "test", "resources", "checkstyle-args.txt")); "-b",
"-c",
"-d",
"-e",
"-E",
"-f",
"-g",
"-j",
"-J",
"-o",
"-p",
"-s",
"-t",
"-T",
"-w",
"-x"
);
assertThat(args).isNotEmpty(); var args = new CheckstyleOperation()
var params = new CheckstyleOperation()
.fromProject(new Project()) .fromProject(new Project())
.branchMatchingXpath("xpath") .branchMatchingXpath("xpath")
.configurationFile("config")
.debug(true) .debug(true)
.configurationFile(new File("config")) .exclude("path")
.exclude(SRC_MAIN_JAVA)
.excludeRegex("regex") .excludeRegex("regex")
.executeIgnoredModules(true) .executeIgnoredModules(true)
.format(OutputFormat.XML) .format(CheckstyleFormatOption.XML)
.generateXpathSuppression(true) .generateXpathSuppression(true)
.javadocTree(true) .javadocTree(true)
.outputPath(new File("optionPath")) .outputPath("optionPath")
.propertiesFile(new File("properties")) .propertiesFile("properties")
.suppressionLineColumnNumber("12") .suppressionLineColumnNumber("12")
.tabWith(1) .tabWith(1)
.tree(true) .tree(true)
@ -93,73 +83,50 @@ class CheckstyleOperationTest {
.treeWithJavadoc(true) .treeWithJavadoc(true)
.executeConstructProcessCommandList(); .executeConstructProcessCommandList();
try (var softly = new AutoCloseableSoftAssertions()) { for (var p : params) {
for (var p : args) {
var found = false; var found = false;
for (var a : params) { for (var a : args) {
if (a.startsWith(p)) { if (a.startsWith(p)) {
found = true; found = true;
break; break;
} }
} }
softly.assertThat(found).as(p + " not found.").isTrue(); assertThat(found).as(p + " not found.").isTrue();
}
} }
} }
@Test @Test
void configurationFile() { void configurationFile() {
var op = new CheckstyleOperation().fromProject(new Project()).configurationFile(FOO); var op = new CheckstyleOperation().fromProject(new Project()).configurationFile(FOO);
assertThat(op.options().get("-c")).isEqualTo(FOO); assertThat(op.options.get("-c")).isEqualTo(FOO);
} }
@Test @Test
void debug() { void debug() {
var op = new CheckstyleOperation().fromProject(new Project()).debug(true); var op = new CheckstyleOperation().fromProject(new Project()).debug(true);
assertThat(op.options().containsKey("-d")).as(ADD).isTrue(); assertThat(op.options.containsKey("-d")).as(ADD).isTrue();
op = op.debug(false); op = op.debug(false);
assertThat(op.options().containsKey("-d")).as(REMOVE).isFalse(); assertThat(op.options.containsKey("-d")).as(REMOVE).isFalse();
} }
@Test @Test
void exclude() { void exclude() {
var foo = new File(SRC_MAIN_JAVA); var op = new CheckstyleOperation().fromProject(new Project()).exclude(FOO, BAR);
var bar = new File(SRC_TEST_JAVA);
var e = "-e "; var e = "-e ";
assertThat(op.executeConstructProcessCommandList()).contains(e + FOO, e + BAR);
var op = new CheckstyleOperation().fromProject(new Project()).exclude(SRC_MAIN_JAVA, SRC_TEST_JAVA); op = new CheckstyleOperation().fromProject(new Project()).exclude(List.of(FOO, BAR));
assertThat(String.join(" ", op.executeConstructProcessCommandList())).as("String...") assertThat(op.executeConstructProcessCommandList()).as("as list").contains(e + FOO, e + BAR);
.contains(e + foo.getAbsolutePath()).contains(e + bar.getAbsolutePath());
op = new CheckstyleOperation().fromProject(new Project()).excludeStrings(List.of(SRC_MAIN_JAVA, SRC_TEST_JAVA));
assertThat(String.join(" ", op.executeConstructProcessCommandList())).as("List(String...)")
.contains(e + foo.getAbsolutePath()).contains(e + bar.getAbsolutePath());
op = new CheckstyleOperation().fromProject(new Project()).exclude(foo, bar);
assertThat(String.join(" ", op.executeConstructProcessCommandList())).as("File...")
.contains(e + foo.getAbsolutePath()).contains(e + bar.getAbsolutePath());
op = new CheckstyleOperation().fromProject(new Project()).exclude(List.of(foo, bar));
assertThat(String.join(" ", op.executeConstructProcessCommandList())).as("List(File...)")
.contains(e + foo.getAbsolutePath()).contains(e + bar.getAbsolutePath());
op = new CheckstyleOperation().fromProject(new Project()).exclude(foo.toPath(), bar.toPath());
assertThat(String.join(" ", op.executeConstructProcessCommandList())).as("Path...")
.contains(e + foo.getAbsolutePath()).contains(e + bar.getAbsolutePath());
op = new CheckstyleOperation().fromProject(new Project()).excludePaths(List.of(foo.toPath(), bar.toPath()));
assertThat(String.join(" ", op.executeConstructProcessCommandList())).as("List(Path...)")
.contains(e + foo.getAbsolutePath()).contains(e + bar.getAbsolutePath());
} }
@Test @Test
void excludeRegex() { void excludeRegex() {
var op = new CheckstyleOperation().fromProject(new Project()).excludeRegex(FOO, BAR); var op = new CheckstyleOperation().fromProject(new Project()).excludeRegex(FOO, BAR);
var x = "-x "; var x = "-x ";
assertThat(String.join(" ", op.executeConstructProcessCommandList())).contains(x + FOO, x + BAR); assertThat(op.executeConstructProcessCommandList()).contains(x + FOO, x + BAR);
op = new CheckstyleOperation().fromProject(new Project()).excludeRegex(List.of(FOO, BAR)); op = new CheckstyleOperation().fromProject(new Project()).excludeRegex(List.of(FOO, BAR));
assertThat(String.join(" ", op.executeConstructProcessCommandList())).as("as list").contains(x + FOO, x + BAR); assertThat(op.executeConstructProcessCommandList()).as("as list").contains(x + FOO, x + BAR);
} }
@Test @Test
@ -168,9 +135,9 @@ class CheckstyleOperationTest {
tmpFile.deleteOnExit(); tmpFile.deleteOnExit();
var op = new CheckstyleOperation() var op = new CheckstyleOperation()
.fromProject(new WebProject()) .fromProject(new WebProject())
.sourceDir(SRC_MAIN_JAVA, SRC_TEST_JAVA) .sourceDir("src/main/java", "src/test/java")
.configurationFile(Path.of("src/test/resources/google_checks.xml")) .configurationFile("src/test/resources/google_checks.xml")
.outputPath(tmpFile.toPath()); .outputPath(tmpFile.getAbsolutePath());
op.execute(); op.execute();
assertThat(tmpFile).exists(); assertThat(tmpFile).exists();
} }
@ -183,7 +150,7 @@ class CheckstyleOperationTest {
.propertiesFile("config/checkstyle.properties") .propertiesFile("config/checkstyle.properties")
.debug(true) .debug(true)
.executeIgnoredModules(true) .executeIgnoredModules(true)
.sourceDir(SRC_MAIN_JAVA, SRC_TEST_JAVA); .sourceDir("src/main/java", "src/test/java");
assertThat(String.join(" ", op.executeConstructProcessCommandList())) assertThat(String.join(" ", op.executeConstructProcessCommandList()))
.startsWith("java -cp ") .startsWith("java -cp ")
.endsWith( .endsWith(
@ -192,22 +159,15 @@ class CheckstyleOperationTest {
"-b xpath " + "-b xpath " +
"-c config/checkstyle.xml " + "-c config/checkstyle.xml " +
"-d -E " + "-d -E " +
new File(SRC_MAIN_JAVA).getAbsolutePath() + " " + "src/main/java src/test/java");
new File(SRC_TEST_JAVA).getAbsolutePath());
} }
@Test @Test
void executeIgnoredModules() { void executeIgnoredModules() {
var op = new CheckstyleOperation().fromProject(new Project()).executeIgnoredModules(true); var op = new CheckstyleOperation().fromProject(new Project()).executeIgnoredModules(true);
assertThat(op.options().containsKey("-E")).as(ADD).isTrue(); assertThat(op.options.containsKey("-E")).as(ADD).isTrue();
op = op.executeIgnoredModules(false); op = op.executeIgnoredModules(false);
assertThat(op.options().containsKey("-E")).as(REMOVE).isFalse(); assertThat(op.options.containsKey("-E")).as(REMOVE).isFalse();
}
@Test
void executeNoProject() {
var op = new CheckstyleOperation();
assertThatCode(op::execute).isInstanceOf(ExitStatusException.class);
} }
@Test @Test
@ -216,7 +176,7 @@ class CheckstyleOperationTest {
tmpFile.deleteOnExit(); tmpFile.deleteOnExit();
var op = new CheckstyleOperation() var op = new CheckstyleOperation()
.fromProject(new WebProject()) .fromProject(new WebProject())
.sourceDir(SRC_MAIN_JAVA, SRC_TEST_JAVA) .sourceDir(List.of("src/main/java", "src/test/java"))
.configurationFile("src/test/resources/sun_checks.xml") .configurationFile("src/test/resources/sun_checks.xml")
.outputPath(tmpFile.getAbsolutePath()); .outputPath(tmpFile.getAbsolutePath());
assertThatCode(op::execute).isInstanceOf(ExitStatusException.class); assertThatCode(op::execute).isInstanceOf(ExitStatusException.class);
@ -225,106 +185,79 @@ class CheckstyleOperationTest {
@Test @Test
void format() { void format() {
var op = new CheckstyleOperation().fromProject(new Project()).format(OutputFormat.XML); var op = new CheckstyleOperation().fromProject(new Project()).format(CheckstyleFormatOption.XML);
assertThat(op.options().get("-f")).isEqualTo("xml"); assertThat(op.options.get("-f")).isEqualTo("xml");
} }
@Test @Test
void generateXpathSuppression() { void generateXpathSuppression() {
var op = new CheckstyleOperation().fromProject(new Project()).generateXpathSuppression(true); var op = new CheckstyleOperation().fromProject(new Project()).generateXpathSuppression(true);
assertThat(op.options().containsKey("-g")).as(ADD).isTrue(); assertThat(op.options.containsKey("-g")).as(ADD).isTrue();
op = op.generateXpathSuppression(false); op = op.generateXpathSuppression(false);
assertThat(op.options().containsKey("-g")).as(REMOVE).isFalse(); assertThat(op.options.containsKey("-g")).as(REMOVE).isFalse();
} }
@Test @Test
void javadocTree() { void javadocTree() {
var op = new CheckstyleOperation().fromProject(new Project()).javadocTree(true); var op = new CheckstyleOperation().fromProject(new Project()).javadocTree(true);
assertThat(op.options().containsKey("-j")).as(ADD).isTrue(); assertThat(op.options.containsKey("-j")).as(ADD).isTrue();
op = op.javadocTree(false); op = op.javadocTree(false);
assertThat(op.options().containsKey("-j")).as(REMOVE).isFalse(); assertThat(op.options.containsKey("-j")).as(REMOVE).isFalse();
} }
@Test @Test
void outputPath() { void outputPath() {
var op = new CheckstyleOperation().fromProject(new Project()).outputPath(FOO); var op = new CheckstyleOperation().fromProject(new Project()).outputPath(FOO);
assertThat(op.options().get("-o")).isEqualTo(FOO); assertThat(op.options.get("-o")).isEqualTo(FOO);
} }
@Test @Test
void propertiesFile() { void propertiesFile() {
var op = new CheckstyleOperation().fromProject(new Project()).propertiesFile(FOO); var op = new CheckstyleOperation().fromProject(new Project()).propertiesFile(FOO);
assertThat(op.options().get("-p")).isEqualTo(FOO); assertThat(op.options.get("-p")).isEqualTo(FOO);
var fooPath = Path.of(FOO);
op = op.propertiesFile(fooPath);
assertThat(op.options().get("-p")).isEqualTo(fooPath.toFile().getAbsolutePath());
} }
@Test @Test
void sourceDir() { void sourceDir() {
var foo = new File(FOO); var op = new CheckstyleOperation().fromProject(new Project()).sourceDir(FOO);
var bar = new File(BAR); assertThat(op.sourceDirs).contains(FOO);
op = op.sourceDir(FOO, BAR);
var op = new CheckstyleOperation().fromProject(new Project()).sourceDir(FOO, BAR); assertThat(op.sourceDirs).as("foo, bar").hasSize(2).contains(FOO).contains(BAR);
assertThat(op.sourceDir()).as("String...").hasSize(2).contains(foo, bar);
op.sourceDir().clear();
op = op.sourceDirStrings(List.of(FOO, BAR));
assertThat(op.sourceDir()).as("List(String...)").hasSize(2).contains(foo, bar);
op.sourceDir().clear();
op = op.sourceDir(foo, bar);
assertThat(op.sourceDir()).as("File...").hasSize(2).contains(foo, bar);
op.sourceDir().clear();
op = op.sourceDir(List.of(foo, bar));
assertThat(op.sourceDir()).as("List(File...)").hasSize(2).contains(foo, bar);
op.sourceDir().clear();
op = op.sourceDir(foo.toPath(), bar.toPath());
assertThat(op.sourceDir()).as("Path...").hasSize(2).contains(foo, bar);
op.sourceDir().clear();
op = op.sourceDirPaths(List.of(foo.toPath(), bar.toPath()));
assertThat(op.sourceDir()).as("List(Path...)").hasSize(2).contains(foo, bar);
op.sourceDir().clear();
} }
@Test @Test
void suppressionLineColumnNumber() { void suppressionLineColumnNumber() {
var op = new CheckstyleOperation().fromProject(new Project()).suppressionLineColumnNumber(FOO + ':' + BAR); var op = new CheckstyleOperation().fromProject(new Project()).suppressionLineColumnNumber(FOO + ':' + BAR);
assertThat(op.options().get("-s")).isEqualTo(FOO + ':' + BAR); assertThat(op.options.get("-s")).isEqualTo(FOO + ':' + BAR);
} }
@Test @Test
void tabWith() { void tabWith() {
var op = new CheckstyleOperation().fromProject(new Project()).tabWith(9); var op = new CheckstyleOperation().fromProject(new Project()).tabWith(9);
assertThat(op.options().get("-w")).isEqualTo("9"); assertThat(op.options.get("-w")).isEqualTo("9");
} }
@Test @Test
void tree() { void tree() {
var op = new CheckstyleOperation().fromProject(new Project()).tree(true); var op = new CheckstyleOperation().fromProject(new Project()).tree(true);
assertThat(op.options().containsKey("-t")).as(ADD).isTrue(); assertThat(op.options.containsKey("-t")).as(ADD).isTrue();
op = op.tree(false); op = op.tree(false);
assertThat(op.options().containsKey("-t")).as(REMOVE).isFalse(); assertThat(op.options.containsKey("-t")).as(REMOVE).isFalse();
} }
@Test @Test
void treeWithComments() { void treeWithComments() {
var op = new CheckstyleOperation().fromProject(new Project()).treeWithComments(true); var op = new CheckstyleOperation().fromProject(new Project()).treeWithComments(true);
assertThat(op.options().containsKey("-T")).as(ADD).isTrue(); assertThat(op.options.containsKey("-T")).as(ADD).isTrue();
op = op.treeWithComments(false); op = op.treeWithComments(false);
assertThat(op.options().containsKey("-T")).as(REMOVE).isFalse(); assertThat(op.options.containsKey("-T")).as(REMOVE).isFalse();
} }
@Test @Test
void treeWithJavadoc() { void treeWithJavadoc() {
var op = new CheckstyleOperation().fromProject(new Project()).treeWithJavadoc(true); var op = new CheckstyleOperation().fromProject(new Project()).treeWithJavadoc(true);
assertThat(op.options().containsKey("-J")).as(ADD).isTrue(); assertThat(op.options.containsKey("-J")).as(ADD).isTrue();
op = op.treeWithJavadoc(false); op = op.treeWithJavadoc(false);
assertThat(op.options().containsKey("-J")).as(REMOVE).isFalse(); assertThat(op.options.containsKey("-J")).as(REMOVE).isFalse();
} }
} }

View file

@ -1,16 +0,0 @@
-b
-c
-d
-e
-E
-f
-g
-j
-J
-o
-p
-s
-t
-T
-w
-x