From 10fd25ebf61f036e3de81e51e1cc0919e4930cdc Mon Sep 17 00:00:00 2001
From: "Erik C. Thauvin" <erik@thauvin.net>
Date: Sun, 26 May 2024 12:38:47 -0700
Subject: [PATCH] Added checks against all parameters

---
 .../extension/dokka/DokkaOperationTest.java   | 36 +++++++++++++++++--
 .../bld/extension/dokka/SourceSetTest.java    | 34 ++++++++++++++++++
 2 files changed, 68 insertions(+), 2 deletions(-)

diff --git a/src/test/java/rife/bld/extension/dokka/DokkaOperationTest.java b/src/test/java/rife/bld/extension/dokka/DokkaOperationTest.java
index b4f30a9..f115a27 100644
--- a/src/test/java/rife/bld/extension/dokka/DokkaOperationTest.java
+++ b/src/test/java/rife/bld/extension/dokka/DokkaOperationTest.java
@@ -31,7 +31,25 @@ class DokkaOperationTest {
     @Test
     @SuppressWarnings({"ExtractMethodRecommender", "PMD.AvoidDuplicateLiterals"})
     void executeConstructProcessCommandListTest() {
+        var params = List.of(
+                "-moduleName",
+                "-moduleVersion",
+                "-outputDir",
+                "-sourceSet",
+                "-pluginsConfiguration",
+                "-pluginsClasspath",
+                "-offlineMode",
+                "-failOnWarning",
+                "-delayTemplateSubstitution",
+                "-noSuppressObviousFunctions",
+                "-includes",
+                "-suppressInheritedMembers",
+                "-globalPackageOptions",
+                "-globalLinks",
+                "-globalSrcLink",
+                "-loggingLevel");
         var examples = new File("examples");
+        var jsonConf = new File("config.json");
         var args = new DokkaOperation()
                 .fromProject(new BaseProjectBlueprint(examples, "com.example", "Example"))
                 .globalLinks("s", "link")
@@ -41,6 +59,7 @@ class DokkaOperationTest {
                 .globalSrcLink("link1", "link2")
                 .globalSrcLink(List.of("link3", "link4"))
                 .includes("file1", "file2")
+                .includes(List.of("file3", "file4"))
                 .pluginConfigurations("name", "{\"json\"}")
                 .pluginConfigurations(Map.of("{\"name2\"}", "json2", "name3}", "{json3"))
                 .pluginsClasspath("path1", "path2")
@@ -60,8 +79,20 @@ class DokkaOperationTest {
                                 new File("examples/foo.jar"),
                                 new File("examples/bar.jar")
                         )))
+                .json(jsonConf)
                 .executeConstructProcessCommandList();
 
+        for (var p : params) {
+            var found = false;
+            for (var a : args) {
+                if (a.startsWith(p)) {
+                    found = true;
+                    break;
+                }
+            }
+            assertThat(found).as(p + " not found.").isTrue();
+        }
+
         var path = examples.getAbsolutePath();
         var dokkaJar = "1.9.20.jar";
         var matches = List.of("java",
@@ -78,14 +109,15 @@ class DokkaOperationTest {
                 "-globalLinks", "s^link^^s2^link2",
                 "-globalPackageOptions", "option1;option2;option3;option4",
                 "-globalSrcLinks_", "link1;link2;link3;link4",
-                "-includes", "file1;file2",
+                "-includes", "file1;file2;file3;file4",
                 "-loggingLevel", "debug",
                 "-moduleName", "name",
                 "-moduleVersion", "1.0",
                 "-noSuppressObviousFunctions",
                 "-offlineMode",
                 "-pluginsConfiguration", "{\\\"name2\\\"}={json2}^^{name}={\\\"json\\\"}^^{name3}}={{json3}",
-                "-suppressInheritedMembers");
+                "-suppressInheritedMembers",
+                jsonConf.getAbsolutePath());
 
         assertThat(args).hasSize(matches.size());
 
diff --git a/src/test/java/rife/bld/extension/dokka/SourceSetTest.java b/src/test/java/rife/bld/extension/dokka/SourceSetTest.java
index f48c26e..ac1c20b 100644
--- a/src/test/java/rife/bld/extension/dokka/SourceSetTest.java
+++ b/src/test/java/rife/bld/extension/dokka/SourceSetTest.java
@@ -53,6 +53,29 @@ class SourceSetTest {
     @Test
     @SuppressWarnings("PMD.AvoidDuplicateLiterals")
     void sourceSetTest() {
+        var params = List.of(
+                "-sourceSetName",
+                "-displayName",
+                "-classpath",
+                "-src",
+                "-dependentSourceSets",
+                "-samples",
+                "-includes",
+                "-documentedVisibilities",
+                "-reportUndocumented",
+                "-noSkipEmptyPackages",
+                "-skipDeprecated",
+                "-jdkVersion",
+                "-languageVersion",
+                "-apiVersion",
+                "-noStdlibLink",
+                "-noJdkLink",
+                "-suppressedFiles",
+                "-analysisPlatform",
+                "-perPackageOptions",
+                "-externalDocumentationLinks",
+                "-srcLink"
+        );
         var sourceSet = new SourceSet()
                 .classpath("classpath1", "classpath2")
                 .dependentSourceSets("moduleName", "sourceSetName")
@@ -80,6 +103,17 @@ class SourceSetTest {
 
         var args = sourceSet.args();
 
+        for (var p : params) {
+            var found = false;
+            for (var a : args) {
+                if (a.startsWith(p)) {
+                    found = true;
+                    break;
+                }
+            }
+            assertThat(found).as(p + " not found.").isTrue();
+        }
+
         var matches = List.of(
                 "-analysisPlatform", "jvm",
                 "-apiVersion", "1.0",