From 84c2474ffc23e73f99a871f66ed50ccdbe912a61 Mon Sep 17 00:00:00 2001
From: "Erik C. Thauvin" <erik@thauvin.net>
Date: Sun, 19 May 2024 02:35:39 -0700
Subject: [PATCH] Fixed boolean-type functions producing invalid parameters.
 Closes #1

---
 examples/src/bld/java/com/example/ExampleBuild.java    |  1 +
 .../java/rife/bld/extension/dokka/DokkaOperation.java  |  5 -----
 .../rife/bld/extension/dokka/DokkaOperationTest.java   | 10 +++++-----
 3 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/examples/src/bld/java/com/example/ExampleBuild.java b/examples/src/bld/java/com/example/ExampleBuild.java
index d4ef292..71edf27 100644
--- a/examples/src/bld/java/com/example/ExampleBuild.java
+++ b/examples/src/bld/java/com/example/ExampleBuild.java
@@ -111,6 +111,7 @@ public class ExampleBuild extends Project {
     public void javadoc() throws ExitStatusException, IOException, InterruptedException {
         new DokkaOperation()
                 .fromProject(this)
+                .failOnWarning(true)
                 .loggingLevel(LoggingLevel.INFO)
                 // Create build/javadoc
                 .outputDir(new File(buildDirectory(), "javadoc"))
diff --git a/src/main/java/rife/bld/extension/dokka/DokkaOperation.java b/src/main/java/rife/bld/extension/dokka/DokkaOperation.java
index 0b0936e..6d51006 100644
--- a/src/main/java/rife/bld/extension/dokka/DokkaOperation.java
+++ b/src/main/java/rife/bld/extension/dokka/DokkaOperation.java
@@ -131,13 +131,11 @@ public class DokkaOperation extends AbstractProcessOperation<DokkaOperation> {
         // -delayTemplateSubstitution
         if (delayTemplateSubstitution_) {
             args.add("-delayTemplateSubstitution");
-            args.add(String.valueOf(delayTemplateSubstitution_));
         }
 
         // -failOnWarning
         if (failOnWarning_) {
             args.add("-failOnWarning");
-            args.add(String.valueOf(failOnWarning_));
         }
 
         // -globalLinks_
@@ -188,13 +186,11 @@ public class DokkaOperation extends AbstractProcessOperation<DokkaOperation> {
         // -noSuppressObviousFunctions
         if (noSuppressObviousFunctions_) {
             args.add("-noSuppressObviousFunctions");
-            args.add(String.valueOf(noSuppressObviousFunctions_));
         }
 
         // -offlineMode
         if (offlineMode_) {
             args.add("-offlineMode");
-            args.add(String.valueOf(offlineMode_));
         }
 
         // -pluginConfiguration
@@ -209,7 +205,6 @@ public class DokkaOperation extends AbstractProcessOperation<DokkaOperation> {
         // -suppressInheritedMembers
         if (suppressInheritedMembers_) {
             args.add("-suppressInheritedMembers");
-            args.add(String.valueOf(suppressInheritedMembers_));
         }
 
         if (LOGGER.isLoggable(Level.FINE)) {
diff --git a/src/test/java/rife/bld/extension/dokka/DokkaOperationTest.java b/src/test/java/rife/bld/extension/dokka/DokkaOperationTest.java
index fbdac6d..864d6fa 100644
--- a/src/test/java/rife/bld/extension/dokka/DokkaOperationTest.java
+++ b/src/test/java/rife/bld/extension/dokka/DokkaOperationTest.java
@@ -68,8 +68,8 @@ class DokkaOperationTest {
                         path + "/lib/bld/kotlin-as-java-plugin-" + dokkaJar + ";path1;path2;path3;path4",
                 "-sourceSet", "-src " + path + "/src/main/kotlin",
                 "-outputDir", path + "/build",
-                "-delayTemplateSubstitution", "true",
-                "-failOnWarning", "true",
+                "-delayTemplateSubstitution",
+                "-failOnWarning",
                 "-globalLinks", "s^link^^s2^link2",
                 "-globalPackageOptions", "option1;option2;option3;option4",
                 "-globalSrcLinks_", "link1;link2;link3;link4",
@@ -77,10 +77,10 @@ class DokkaOperationTest {
                 "-loggingLevel", "debug",
                 "-moduleName", "name",
                 "-moduleVersion", "1.0",
-                "-noSuppressObviousFunctions", "true",
-                "-offlineMode", "true",
+                "-noSuppressObviousFunctions",
+                "-offlineMode",
                 "-pluginConfiguration", "{name}={\\\"json\\\"}^^{\\\"name2\\\"}={json2}",
-                "-suppressInheritedMembers", "true");
+                "-suppressInheritedMembers");
 
         assertThat(args).hasSize(matches.size());