diff --git a/src/test/java/rife/bld/extension/PmdOperationTest.java b/src/test/java/rife/bld/extension/PmdOperationTest.java index d5e2729..50d7ad0 100644 --- a/src/test/java/rife/bld/extension/PmdOperationTest.java +++ b/src/test/java/rife/bld/extension/PmdOperationTest.java @@ -177,7 +177,7 @@ class PmdOperationTest { void testJavaSecurity() { var pmd = newPmdOperation().ruleSets("category/java/security.xml") .inputPaths(Path.of("src/test/resources/java/Security.java")); - assertThat(pmd.performPmdAnalysis(TEST, pmd.initConfiguration(COMMAND_NAME))).isEqualTo(0); + assertThat(pmd.performPmdAnalysis(TEST, pmd.initConfiguration(COMMAND_NAME))).isEqualTo(1); } @Test diff --git a/src/test/resources/java/BestPractices.java b/src/test/resources/java/BestPractices.java index a7de345..36cbb4a 100644 --- a/src/test/resources/java/BestPractices.java +++ b/src/test/resources/java/BestPractices.java @@ -14,7 +14,9 @@ * limitations under the License. */ -package java;/** +package java; + +/** * BestPractices class * * @author Erik C. Thauvin diff --git a/src/test/resources/java/Design.java b/src/test/resources/java/Design.java index 42068de..e430e9d 100644 --- a/src/test/resources/java/Design.java +++ b/src/test/resources/java/Design.java @@ -14,7 +14,9 @@ * limitations under the License. */ -package java;/** +package java; + +/** * Design class * * @author Erik C. Thauvin diff --git a/src/test/resources/java/Documentation.java b/src/test/resources/java/Documentation.java index 2c90f8a..af2cba5 100644 --- a/src/test/resources/java/Documentation.java +++ b/src/test/resources/java/Documentation.java @@ -14,7 +14,9 @@ * limitations under the License. */ -package java;/** +package java; + +/** * @author Erik C. Thauvin * @since 1.0 */ diff --git a/src/test/resources/java/ErrorProne.java b/src/test/resources/java/ErrorProne.java index 0b042d8..b787d97 100644 --- a/src/test/resources/java/ErrorProne.java +++ b/src/test/resources/java/ErrorProne.java @@ -14,7 +14,9 @@ * limitations under the License. */ -package java;/** +package java; + +/** * ErrorProne class * * @author Erik C. Thauvin diff --git a/src/test/resources/java/MultiThreading.java b/src/test/resources/java/MultiThreading.java index 6dfc1fc..f2c8161 100644 --- a/src/test/resources/java/MultiThreading.java +++ b/src/test/resources/java/MultiThreading.java @@ -14,7 +14,9 @@ * limitations under the License. */ -package java;import java.text.SimpleDateFormat; +package java; + +import java.text.SimpleDateFormat; /** * MultiThreading class diff --git a/src/test/resources/java/Performance.java b/src/test/resources/java/Performance.java index 82b9a0b..e00f30f 100644 --- a/src/test/resources/java/Performance.java +++ b/src/test/resources/java/Performance.java @@ -14,7 +14,9 @@ * limitations under the License. */ -package java;/** +package java; + +/** * Performance class * * @author Erik C. Thauvin diff --git a/src/test/resources/java/Security.java b/src/test/resources/java/Security.java index a083b2c..caf0367 100644 --- a/src/test/resources/java/Security.java +++ b/src/test/resources/java/Security.java @@ -14,7 +14,7 @@ * limitations under the License. */ -package java;import java.security.SecureRandom; +package java; /** * Security class @@ -24,11 +24,6 @@ package java;import java.security.SecureRandom; */ public class Security { void bad() { - byte[] iv = new byte[] { 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, 00, }; + SecretKeySpec secretKeySpec = new SecretKeySpec("my secret here".getBytes(), "AES"); } - - void alsoBad() { - byte[] iv = "secret iv in here".getBytes(); - } - } diff --git a/src/test/resources/xml/basic.xml b/src/test/resources/xml/basic.xml index 3527b42..c261dc7 100644 --- a/src/test/resources/xml/basic.xml +++ b/src/test/resources/xml/basic.xml @@ -9,34 +9,34 @@ - - - - - - - - - - - - - + + + + + + + + + + + + + - - - + + + - - + + - - + + - + - - + + \ No newline at end of file