From 5c85cddf0df8a8eb76f2a0fc12d99818aacc85b8 Mon Sep 17 00:00:00 2001
From: "Erik C. Thauvin" <erik@thauvin.net>
Date: Mon, 28 Aug 2023 14:50:36 -0700
Subject: [PATCH 1/2] Added support for collections as arguments

---
 .../java/rife/bld/extension/PmdOperation.java | 52 +++++++++++++++++--
 1 file changed, 48 insertions(+), 4 deletions(-)

diff --git a/src/main/java/rife/bld/extension/PmdOperation.java b/src/main/java/rife/bld/extension/PmdOperation.java
index 303bf43..51e8036 100644
--- a/src/main/java/rife/bld/extension/PmdOperation.java
+++ b/src/main/java/rife/bld/extension/PmdOperation.java
@@ -26,10 +26,7 @@ import rife.bld.operations.AbstractOperation;
 import java.net.URI;
 import java.nio.file.Path;
 import java.nio.file.Paths;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
-import java.util.Objects;
+import java.util.*;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
@@ -162,6 +159,29 @@ public class PmdOperation extends AbstractOperation<PmdOperation> {
         return this;
     }
 
+    /**
+     * Adds new rule set paths.
+     * <p>
+     * The built-in rule set paths are:
+     * <ul>
+     *     <li>{@code rulesets/java/quickstart.xml}</li>
+     *     <li>{@code category/java/bestpractices.xml}</li>
+     *     <li>{@code category/java/codestyle.xml}</li>
+     *     <li>{@code category/java/design.xml}</li>
+     *     <li>{@code category/java/documentation.xml}</li>
+     *     <li>{@code category/java/errorprone.xml}</li>
+     *     <li>{@code category/java/multithreading.xml}</li>
+     *     <li>{@code category/java/performance.xml}</li>
+     *     <li>{@code category/java/security.xml}</li>
+     * </ul>
+     *
+     * @see #ruleSets(Collection)
+     */
+    public PmdOperation addRuleSet(Collection<String> ruleSet) {
+        ruleSets.addAll(ruleSet);
+        return this;
+    }
+
     /**
      * Sets the location of the cache file for incremental analysis.
      */
@@ -421,6 +441,30 @@ public class PmdOperation extends AbstractOperation<PmdOperation> {
         return this;
     }
 
+    /**
+     * Sets the rule set path(s), disregarding any previously set paths.
+     * <p>
+     * The built-in rule set paths are:
+     * <ul>
+     *     <li>{@code rulesets/java/quickstart.xml}</li>
+     *     <li>{@code category/java/bestpractices.xml}</li>
+     *     <li>{@code category/java/codestyle.xml}</li>
+     *     <li>{@code category/java/design.xml}</li>
+     *     <li>{@code category/java/documentation.xml}</li>
+     *     <li>{@code category/java/errorprone.xml}</li>
+     *     <li>{@code category/java/multithreading.xml}</li>
+     *     <li>{@code category/java/performance.xml}</li>
+     *     <li>{@code category/java/security.xml}</li>
+     * </ul>
+     *
+     * @see #addRuleSet(Collection)
+     */
+    public PmdOperation ruleSets(Collection<String> ruleSet) {
+        ruleSets.clear();
+        ruleSets.addAll(ruleSet);
+        return this;
+    }
+
     /**
      * Enables or disables adding the suppressed rule violations to the report.
      */

From 77b7d64852535949b7284161bfa774eb463defff Mon Sep 17 00:00:00 2001
From: "Erik C. Thauvin" <erik@thauvin.net>
Date: Mon, 28 Aug 2023 14:52:13 -0700
Subject: [PATCH 2/2] Updated copyright

---
 .github/workflows/bld.yml                     |  4 ++--
 .idea/copyright/Apache_License.xml            |  2 +-
 .idea/misc.xml                                |  2 ++
 README.md                                     |  2 +-
 .../rife/bld/extension/PmdOperationBuild.java | 16 +++++++++++++++
 .../java/rife/bld/extension/PmdOperation.java | 20 +++++++++----------
 .../rife/bld/extension/PmdOperationTest.java  | 20 +++++++++----------
 7 files changed, 42 insertions(+), 24 deletions(-)

diff --git a/.github/workflows/bld.yml b/.github/workflows/bld.yml
index ddcc35c..2b0ba38 100644
--- a/.github/workflows/bld.yml
+++ b/.github/workflows/bld.yml
@@ -8,7 +8,7 @@ jobs:
 
     strategy:
       matrix:
-        java-version: [ 17, 19, 20 ]
+        java-version: [ 17, 20 ]
 
     steps:
       - name: Checkout source repository
@@ -29,4 +29,4 @@ jobs:
         run: ./bld download
 
       - name: Run tests with bld
-        run: ./bld compile test
\ No newline at end of file
+        run: ./bld compile test
diff --git a/.idea/copyright/Apache_License.xml b/.idea/copyright/Apache_License.xml
index 206aa7d..15687f4 100644
--- a/.idea/copyright/Apache_License.xml
+++ b/.idea/copyright/Apache_License.xml
@@ -1,6 +1,6 @@
 <component name="CopyrightManager">
   <copyright>
-    <option name="notice" value=" Copyright &amp;#36;today.year the original author or authors.&#10; &#10; Licensed under the Apache License, Version 2.0 (the &quot;License&quot;);&#10;  you may not use this file except in compliance with the License.&#10;  You may obtain a copy of the License at&#10; &#10;      https://www.apache.org/licenses/LICENSE-2.0&#10; &#10; Unless required by applicable law or agreed to in writing, software&#10; distributed under the License is distributed on an &quot;AS IS&quot; BASIS,&#10; WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.&#10; See the License for the specific language governing permissions and&#10; limitations under the License." />
+    <option name="notice" value="Copyright &amp;#36;today.year the original author or authors.&#10; &#10;Licensed under the Apache License, Version 2.0 (the &quot;License&quot;);&#10;you may not use this file except in compliance with the License.&#10;You may obtain a copy of the License at&#10;&#10;    https://www.apache.org/licenses/LICENSE-2.0&#10;&#10;Unless required by applicable law or agreed to in writing, software&#10;distributed under the License is distributed on an &quot;AS IS&quot; BASIS,&#10;WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.&#10;See the License for the specific language governing permissions and&#10;limitations under the License." />
     <option name="myName" value="Apache License" />
   </copyright>
 </component>
\ No newline at end of file
diff --git a/.idea/misc.xml b/.idea/misc.xml
index dbe3041..d573dd7 100644
--- a/.idea/misc.xml
+++ b/.idea/misc.xml
@@ -1,3 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
 <project version="4">
   <component name="EntryPointsManager">
     <entry_points version="2.0">
@@ -32,6 +33,7 @@
     <option name="customRuleSets">
       <list>
         <option value="K:\java\semver\config\pmd.xml" />
+        <option value="$PROJECT_DIR$/../bld-exec/config/pmd.xml" />
       </list>
     </option>
     <option name="skipTestSources" value="false" />
diff --git a/README.md b/README.md
index 464f7af..227c784 100755
--- a/README.md
+++ b/README.md
@@ -1,4 +1,4 @@
-# [Bld](https://rife2.com/bld) Extension to Perform Static Code Analysis with [PMD](https://pmd.github.io/)
+# [bld](https://rife2.com/bld) Extension to Perform Static Code Analysis with [PMD](https://pmd.github.io/)
 
 
 [![License](https://img.shields.io/badge/license-Apache%20License%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0)
diff --git a/src/bld/java/rife/bld/extension/PmdOperationBuild.java b/src/bld/java/rife/bld/extension/PmdOperationBuild.java
index 5473054..1a4080a 100644
--- a/src/bld/java/rife/bld/extension/PmdOperationBuild.java
+++ b/src/bld/java/rife/bld/extension/PmdOperationBuild.java
@@ -1,3 +1,19 @@
+/*
+ * Copyright 2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
 package rife.bld.extension;
 
 import rife.bld.BuildCommand;
diff --git a/src/main/java/rife/bld/extension/PmdOperation.java b/src/main/java/rife/bld/extension/PmdOperation.java
index 51e8036..b86cd76 100644
--- a/src/main/java/rife/bld/extension/PmdOperation.java
+++ b/src/main/java/rife/bld/extension/PmdOperation.java
@@ -1,17 +1,17 @@
 /*
- *  Copyright 2023 the original author or authors.
+ * Copyright 2023 the original author or authors.
  *
- *  Licensed under the Apache License, Version 2.0 (the "License");
- *   you may not use this file except in compliance with the License.
- *   You may obtain a copy of the License at
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
  *
- *       https://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  */
 
 package rife.bld.extension;
diff --git a/src/test/java/rife/bld/extension/PmdOperationTest.java b/src/test/java/rife/bld/extension/PmdOperationTest.java
index cc61937..e9a6eac 100644
--- a/src/test/java/rife/bld/extension/PmdOperationTest.java
+++ b/src/test/java/rife/bld/extension/PmdOperationTest.java
@@ -1,17 +1,17 @@
 /*
- *  Copyright 2023 the original author or authors.
+ * Copyright 2023 the original author or authors.
  *
- *  Licensed under the Apache License, Version 2.0 (the "License");
- *   you may not use this file except in compliance with the License.
- *   You may obtain a copy of the License at
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
  *
- *       https://www.apache.org/licenses/LICENSE-2.0
+ *     https://www.apache.org/licenses/LICENSE-2.0
  *
- *  Unless required by applicable law or agreed to in writing, software
- *  distributed under the License is distributed on an "AS IS" BASIS,
- *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- *  See the License for the specific language governing permissions and
- *  limitations under the License.
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
  */
 
 package rife.bld.extension;