From 60deb1906ab4a27cd1e256c68cca4f132143ce1d Mon Sep 17 00:00:00 2001 From: "Erik C. Thauvin" Date: Fri, 15 Sep 2023 06:24:12 -0700 Subject: [PATCH] Replaced all append("x") with append('x') --- src/main/java/rife/bld/BaseProject.java | 10 +++++----- src/main/java/rife/bld/BuildExecutor.java | 2 +- src/main/java/rife/bld/dependencies/Dependency.java | 10 +++++----- .../java/rife/bld/dependencies/DependencyResolver.java | 6 +++--- src/main/java/rife/bld/dependencies/Repository.java | 8 ++++---- src/main/java/rife/bld/dependencies/VersionNumber.java | 2 +- .../java/rife/bld/operations/PublishOperation.java | 6 +++--- src/main/java/rife/bld/wrapper/Wrapper.java | 2 +- .../rife/bld/wrapper/WrapperExtensionResolver.java | 2 +- .../java/rife/bld/operations/TestJarOperation.java | 4 ++-- .../java/rife/bld/operations/TestWarOperation.java | 2 +- 11 files changed, 27 insertions(+), 27 deletions(-) diff --git a/src/main/java/rife/bld/BaseProject.java b/src/main/java/rife/bld/BaseProject.java index d379ae0..ebecc31 100644 --- a/src/main/java/rife/bld/BaseProject.java +++ b/src/main/java/rife/bld/BaseProject.java @@ -1546,22 +1546,22 @@ public class BaseProject extends BuildExecutor { var finger_print = new StringBuilder(); for (var repository : repositories()) { finger_print.append(repository.toString()); - finger_print.append("\n"); + finger_print.append('\n'); } for (var entry : dependencies().entrySet()) { finger_print.append(entry.getKey()); - finger_print.append("\n"); + finger_print.append('\n'); if (entry.getValue() != null) { for (var dependency : entry.getValue()) { finger_print.append(dependency.toString()); - finger_print.append("\n"); + finger_print.append('\n'); } } } finger_print.append(downloadSources()); - finger_print.append("\n"); + finger_print.append('\n'); finger_print.append(downloadJavadoc()); - finger_print.append("\n"); + finger_print.append('\n'); try { var digest = MessageDigest.getInstance("SHA-1"); diff --git a/src/main/java/rife/bld/BuildExecutor.java b/src/main/java/rife/bld/BuildExecutor.java index 6c238cf..028b578 100644 --- a/src/main/java/rife/bld/BuildExecutor.java +++ b/src/main/java/rife/bld/BuildExecutor.java @@ -399,7 +399,7 @@ public class BuildExecutor { fuzzy_regexp.append(ch); fuzzy_regexp.append("\\E.*"); } - fuzzy_regexp.append("$"); + fuzzy_regexp.append('$'); var fuzzy_pattern = Pattern.compile(fuzzy_regexp.toString()); matches.addAll(buildCommands().keySet().stream() .filter(c -> fuzzy_pattern.matcher(c.toLowerCase()).matches()) diff --git a/src/main/java/rife/bld/dependencies/Dependency.java b/src/main/java/rife/bld/dependencies/Dependency.java index 8939c18..bd7f778 100644 --- a/src/main/java/rife/bld/dependencies/Dependency.java +++ b/src/main/java/rife/bld/dependencies/Dependency.java @@ -130,9 +130,9 @@ public record Dependency(String groupId, String artifactId, VersionNumber versio */ public String toFileName() { var result = new StringBuilder(artifactId()); - result.append("-").append(version()); + result.append('-').append(version()); if (!classifier().isEmpty()) { - result.append("-").append(classifier()); + result.append('-').append(classifier()); } result.append(".").append(type()); return result.toString(); @@ -142,13 +142,13 @@ public record Dependency(String groupId, String artifactId, VersionNumber versio public String toString() { var result = new StringBuilder(groupId).append(":").append(artifactId); if (!version.equals(VersionNumber.UNKNOWN)) { - result.append(":").append(version); + result.append(':').append(version); } if (!classifier.isEmpty()) { - result.append(":").append(classifier); + result.append(':').append(classifier); } if (!type.isEmpty() && !"jar".equals(type)) { - result.append("@").append(type); + result.append('@').append(type); } return result.toString(); } diff --git a/src/main/java/rife/bld/dependencies/DependencyResolver.java b/src/main/java/rife/bld/dependencies/DependencyResolver.java index 281c857..8f61937 100644 --- a/src/main/java/rife/bld/dependencies/DependencyResolver.java +++ b/src/main/java/rife/bld/dependencies/DependencyResolver.java @@ -315,15 +315,15 @@ public class DependencyResolver { return getArtifactLocations().stream().map(a -> { var result = new StringBuilder(); - result.append(version).append("/").append(dependency_.artifactId()).append("-").append(pom_version); + result.append(version).append('/').append(dependency_.artifactId()).append('-').append(pom_version); if (!dependency_.classifier().isEmpty()) { - result.append("-").append(dependency_.classifier()); + result.append('-').append(dependency_.classifier()); } var type = dependency_.type(); if (type == null) { type = "jar"; } - result.append(".").append(type); + result.append('.').append(type); return a.appendPath(result.toString()); }).toList(); diff --git a/src/main/java/rife/bld/dependencies/Repository.java b/src/main/java/rife/bld/dependencies/Repository.java index cdff56f..27641f7 100644 --- a/src/main/java/rife/bld/dependencies/Repository.java +++ b/src/main/java/rife/bld/dependencies/Repository.java @@ -159,9 +159,9 @@ public record Repository(String location, String username, String password) { result.append(location()); } if (!location().endsWith("/")) { - result.append("/"); + result.append('/'); } - return result.append(group_path).append("/").append(artifactId).append("/").toString(); + return result.append(group_path).append('/').append(artifactId).append('/').toString(); } /** @@ -181,11 +181,11 @@ public record Repository(String location, String username, String password) { public String toString() { var result = new StringBuilder(location); if (username() != null) { - result.append(":"); + result.append(':'); try { result.append(StringEncryptor.MD5HLO.performEncryption(username(), null)); if (password() != null) { - result.append(":"); + result.append(':'); result.append(StringEncryptor.MD5HLO.performEncryption(password(), null)); } } catch (NoSuchAlgorithmException e) { diff --git a/src/main/java/rife/bld/dependencies/VersionNumber.java b/src/main/java/rife/bld/dependencies/VersionNumber.java index 650d70b..e6b245e 100644 --- a/src/main/java/rife/bld/dependencies/VersionNumber.java +++ b/src/main/java/rife/bld/dependencies/VersionNumber.java @@ -223,7 +223,7 @@ public record VersionNumber(Integer major, Integer minor, Integer revision, Stri version.append(minorInt()); } if (revision != null) { - version.append("."); + version.append('.'); version.append(revisionInt()); } if (qualifier != null && !qualifier.isEmpty()) { diff --git a/src/main/java/rife/bld/operations/PublishOperation.java b/src/main/java/rife/bld/operations/PublishOperation.java index 69109df..7fb0a9d 100644 --- a/src/main/java/rife/bld/operations/PublishOperation.java +++ b/src/main/java/rife/bld/operations/PublishOperation.java @@ -165,15 +165,15 @@ public class PublishOperation extends AbstractOperation { protected void executePublishArtifacts(Repository repository, VersionNumber actualVersion) { // upload artifacts for (var artifact : artifacts()) { - var artifact_name = new StringBuilder(info().artifactId()).append("-").append(actualVersion); + var artifact_name = new StringBuilder(info().artifactId()).append('-').append(actualVersion); if (!artifact.classifier().isEmpty()) { - artifact_name.append("-").append(artifact.classifier()); + artifact_name.append('-').append(artifact.classifier()); } var type = artifact.type(); if (type == null) { type = "jar"; } - artifact_name.append(".").append(type); + artifact_name.append('.').append(type); executePublishFileArtifact(repository, artifact.file(), info().version() + "/" + artifact_name); } diff --git a/src/main/java/rife/bld/wrapper/Wrapper.java b/src/main/java/rife/bld/wrapper/Wrapper.java index 19c2d1c..1ff47a9 100644 --- a/src/main/java/rife/bld/wrapper/Wrapper.java +++ b/src/main/java/rife/bld/wrapper/Wrapper.java @@ -364,7 +364,7 @@ public class Wrapper { var location = getWrapperDownloadLocation(version); var result = new StringBuilder(location); if (!location.endsWith("/")) { - result.append("/"); + result.append('/'); } result.append(fileName); return result.toString(); diff --git a/src/main/java/rife/bld/wrapper/WrapperExtensionResolver.java b/src/main/java/rife/bld/wrapper/WrapperExtensionResolver.java index c0b9f5d..1239a0c 100644 --- a/src/main/java/rife/bld/wrapper/WrapperExtensionResolver.java +++ b/src/main/java/rife/bld/wrapper/WrapperExtensionResolver.java @@ -134,7 +134,7 @@ public class WrapperExtensionResolver { contents.append(fingerPrintHash_); for (var file : localArtifacts_) { if (file.exists() && file.canRead()) { - contents.append("\n").append(file.lastModified()).append(":").append(file.getAbsolutePath()); + contents.append("\n").append(file.lastModified()).append(':').append(file.getAbsolutePath()); } } diff --git a/src/test/java/rife/bld/operations/TestJarOperation.java b/src/test/java/rife/bld/operations/TestJarOperation.java index 46a3174..8f70192 100644 --- a/src/test/java/rife/bld/operations/TestJarOperation.java +++ b/src/test/java/rife/bld/operations/TestJarOperation.java @@ -161,7 +161,7 @@ public class TestJarOperation { while (e.hasMoreElements()) { var jar_entry = e.nextElement(); content.append(jar_entry.getName()); - content.append("\n"); + content.append('\n'); } } @@ -203,7 +203,7 @@ public class TestJarOperation { while (e.hasMoreElements()) { var jar_entry = e.nextElement(); content.append(jar_entry.getName()); - content.append("\n"); + content.append('\n'); } } diff --git a/src/test/java/rife/bld/operations/TestWarOperation.java b/src/test/java/rife/bld/operations/TestWarOperation.java index d3925e4..ee91dd6 100644 --- a/src/test/java/rife/bld/operations/TestWarOperation.java +++ b/src/test/java/rife/bld/operations/TestWarOperation.java @@ -138,7 +138,7 @@ public class TestWarOperation { while (e.hasMoreElements()) { var jar_entry = e.nextElement(); content.append(jar_entry.getName()); - content.append("\n"); + content.append('\n'); } }