rife2/bld
rife2/bld
2
0
Fork 0
mirror of https://github.com/ethauvin/bld.git synced 2025-04-25 00:07:12 -07:00
Code Activity

Fixed excessive String concatenations in loop

Browse source
This commit is contained in:
Erik C. Thauvin 2023-09-15 06:40:58 -07:00
parent 89eb658d73
commit 7009e54c71
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/main/java/rife/bld/operations/AbstractCreateOperation.java
View file

@ -220,13 +220,17 @@ public abstract class AbstractCreateOperation<T extends AbstractCreateOperation<
for (var entry : project_.dependencies().entrySet()) {
build_template.blankValue("dependencies");
var version_string = new StringBuilder(0);
for (var dependency : entry.getValue()) {
build_template.setValue("groupId", dependency.groupId());
build_template.setValue("artifactId", dependency.artifactId());
var version = dependency.version();
var version_string = version.major() + "," + version.minor() + "," + version.revision();
version_string.setLength(0);
version_string.append(version.major()).append(',')
.append(version.minor()).append(',')
.append(version.revision());
if (!version.qualifier().isEmpty()) {
version_string += ",\"" + version.qualifier() + "\"";
version_string.append(",\"" ).append(version.qualifier()).append('"');
}
build_template.setValue("version", version_string);
build_template.appendBlock("dependencies", "dependency");