diff --git a/lib/build.gradle.kts b/lib/build.gradle.kts index b53d9dc..a4035eb 100644 --- a/lib/build.gradle.kts +++ b/lib/build.gradle.kts @@ -13,7 +13,7 @@ plugins { id("com.github.ben-manes.versions") version "0.46.0" } -val rifeVersion by rootProject.extra { "1.5.6" } +val rifeVersion by rootProject.extra { "1.5.5" } group = "com.uwyn.rife2" version = "1.0.1-SNAPSHOT" diff --git a/lib/src/main/java/rife/render/Abbreviate.java b/lib/src/main/java/rife/render/Abbreviate.java index 6944aa4..cfe679a 100644 --- a/lib/src/main/java/rife/render/Abbreviate.java +++ b/lib/src/main/java/rife/render/Abbreviate.java @@ -57,8 +57,6 @@ public class Abbreviate implements ValueRenderer { // do nothing } } - - return template.getEncoder().encode( - RenderUtils.abbreviate(template.getValueOrAttribute(differentiator), max, mark)); + return RenderUtils.abbreviate(template.getValueOrAttribute(differentiator), max, mark); } -} \ No newline at end of file +} diff --git a/lib/src/main/java/rife/render/BeatTime.java b/lib/src/main/java/rife/render/BeatTime.java index dd4cfad..e1eaf44 100644 --- a/lib/src/main/java/rife/render/BeatTime.java +++ b/lib/src/main/java/rife/render/BeatTime.java @@ -42,6 +42,6 @@ public class BeatTime implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - return template.getEncoder().encode(RenderUtils.beatTime(ZonedDateTime.now())); + return RenderUtils.beatTime(ZonedDateTime.now()); } } \ No newline at end of file diff --git a/lib/src/main/java/rife/render/Capitalize.java b/lib/src/main/java/rife/render/Capitalize.java index dc4c126..9e9bd91 100644 --- a/lib/src/main/java/rife/render/Capitalize.java +++ b/lib/src/main/java/rife/render/Capitalize.java @@ -19,7 +19,6 @@ package rife.render; import rife.template.Template; import rife.template.ValueRenderer; -import rife.tools.StringUtils; /** *
Capitalizes a template value.
@@ -41,6 +40,6 @@ public class Capitalize implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - return template.getEncoder().encode(StringUtils.capitalize(template.getValueOrAttribute(differentiator))); + return RenderUtils.capitalize(template.getValueOrAttribute(differentiator)); } } diff --git a/lib/src/main/java/rife/render/DateIso.java b/lib/src/main/java/rife/render/DateIso.java index 3fe35c6..b261268 100644 --- a/lib/src/main/java/rife/render/DateIso.java +++ b/lib/src/main/java/rife/render/DateIso.java @@ -42,6 +42,6 @@ public class DateIso implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - return template.getEncoder().encode(ZonedDateTime.now().format(RenderUtils.ISO_8601_DATE_FORMATTER)); + return ZonedDateTime.now().format(RenderUtils.ISO_8601_DATE_FORMATTER); } } diff --git a/lib/src/main/java/rife/render/DateTimeIso.java b/lib/src/main/java/rife/render/DateTimeIso.java index 50ac866..683abb7 100644 --- a/lib/src/main/java/rife/render/DateTimeIso.java +++ b/lib/src/main/java/rife/render/DateTimeIso.java @@ -61,6 +61,6 @@ public class DateTimeIso implements ValueRenderer { } } - return template.getEncoder().encode(ZonedDateTime.now().format(RenderUtils.ISO_8601_FORMATTER)); + return ZonedDateTime.now().format(RenderUtils.ISO_8601_FORMATTER); } } diff --git a/lib/src/main/java/rife/render/DateTimeRfc2822.java b/lib/src/main/java/rife/render/DateTimeRfc2822.java index a420201..5058b70 100644 --- a/lib/src/main/java/rife/render/DateTimeRfc2822.java +++ b/lib/src/main/java/rife/render/DateTimeRfc2822.java @@ -42,6 +42,6 @@ public class DateTimeRfc2822 implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - return template.getEncoder().encode(ZonedDateTime.now().format(RenderUtils.RFC_2822_FORMATTER)); + return ZonedDateTime.now().format(RenderUtils.RFC_2822_FORMATTER); } } diff --git a/lib/src/main/java/rife/render/EncodeBase64.java b/lib/src/main/java/rife/render/EncodeBase64.java index fd2e62a..c5bd854 100644 --- a/lib/src/main/java/rife/render/EncodeBase64.java +++ b/lib/src/main/java/rife/render/EncodeBase64.java @@ -44,9 +44,7 @@ public class EncodeBase64 implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - var properties = RenderUtils.parsePropertiesString(template.getDefaultValue(valueId)); - return RenderUtils.encode( - StringUtils.encodeBase64(template.getValueOrAttribute(differentiator).getBytes(StandardCharsets.UTF_8)), - properties); + return StringUtils.encodeBase64(template.getValueOrAttribute(differentiator) + .getBytes(StandardCharsets.UTF_8)); } } diff --git a/lib/src/main/java/rife/render/EncodeJs.java b/lib/src/main/java/rife/render/EncodeJs.java index 1122356..caafb18 100644 --- a/lib/src/main/java/rife/render/EncodeJs.java +++ b/lib/src/main/java/rife/render/EncodeJs.java @@ -42,7 +42,6 @@ public class EncodeJs implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - var properties = RenderUtils.parsePropertiesString(template.getDefaultValue(valueId)); - return RenderUtils.encode(RenderUtils.encodeJs(template.getValueOrAttribute(differentiator)), properties); + return RenderUtils.encodeJs(template.getValueOrAttribute(differentiator)); } } diff --git a/lib/src/main/java/rife/render/EncodeJson.java b/lib/src/main/java/rife/render/EncodeJson.java index 7356650..60916f6 100644 --- a/lib/src/main/java/rife/render/EncodeJson.java +++ b/lib/src/main/java/rife/render/EncodeJson.java @@ -42,7 +42,6 @@ public class EncodeJson implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - var properties = RenderUtils.parsePropertiesString(template.getDefaultValue(valueId)); - return RenderUtils.encode(StringUtils.encodeJson(template.getValueOrAttribute(differentiator)), properties); + return StringUtils.encodeJson(template.getValueOrAttribute(differentiator)); } } diff --git a/lib/src/main/java/rife/render/EncodeUnicode.java b/lib/src/main/java/rife/render/EncodeUnicode.java index 60166a1..1d67bf1 100644 --- a/lib/src/main/java/rife/render/EncodeUnicode.java +++ b/lib/src/main/java/rife/render/EncodeUnicode.java @@ -42,7 +42,6 @@ public class EncodeUnicode implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - var properties = RenderUtils.parsePropertiesString(template.getDefaultValue(valueId)); - return RenderUtils.encode(StringUtils.encodeUnicode(template.getValueOrAttribute(differentiator)), properties); + return StringUtils.encodeUnicode(template.getValueOrAttribute(differentiator)); } } diff --git a/lib/src/main/java/rife/render/EncodeUrl.java b/lib/src/main/java/rife/render/EncodeUrl.java index 6692636..f6201d5 100644 --- a/lib/src/main/java/rife/render/EncodeUrl.java +++ b/lib/src/main/java/rife/render/EncodeUrl.java @@ -42,7 +42,6 @@ public class EncodeUrl implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - var properties = RenderUtils.parsePropertiesString(template.getDefaultValue(valueId)); - return RenderUtils.encode(StringUtils.encodeUrl(template.getValueOrAttribute(differentiator)), properties); + return StringUtils.encodeUrl(template.getValueOrAttribute(differentiator)); } } diff --git a/lib/src/main/java/rife/render/FormatCreditCard.java b/lib/src/main/java/rife/render/FormatCreditCard.java index f2025eb..840d66e 100644 --- a/lib/src/main/java/rife/render/FormatCreditCard.java +++ b/lib/src/main/java/rife/render/FormatCreditCard.java @@ -40,6 +40,6 @@ public class FormatCreditCard implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - return template.getEncoder().encode(RenderUtils.formatCreditCard(template.getValueOrAttribute(differentiator))); + return RenderUtils.formatCreditCard(template.getValueOrAttribute(differentiator)); } } diff --git a/lib/src/main/java/rife/render/Lowercase.java b/lib/src/main/java/rife/render/Lowercase.java index aa7858c..d966142 100644 --- a/lib/src/main/java/rife/render/Lowercase.java +++ b/lib/src/main/java/rife/render/Lowercase.java @@ -45,6 +45,6 @@ public class Lowercase implements ValueRenderer { if (value == null || value.isBlank()) { return value; } - return template.getEncoder().encode(value.toLowerCase(Localization.getLocale())); + return value.toLowerCase(Localization.getLocale()); } } diff --git a/lib/src/main/java/rife/render/Mask.java b/lib/src/main/java/rife/render/Mask.java index a9c1e22..897b415 100644 --- a/lib/src/main/java/rife/render/Mask.java +++ b/lib/src/main/java/rife/render/Mask.java @@ -59,7 +59,6 @@ public class Mask implements ValueRenderer { // do nothing } } - return template.getEncoder().encode( - RenderUtils.mask(template.getValueOrAttribute(differentiator), mask, unmasked, fromStart)); + return RenderUtils.mask(template.getValueOrAttribute(differentiator), mask, unmasked, fromStart); } } diff --git a/lib/src/main/java/rife/render/Normalize.java b/lib/src/main/java/rife/render/Normalize.java index c3e66a2..636c8cb 100644 --- a/lib/src/main/java/rife/render/Normalize.java +++ b/lib/src/main/java/rife/render/Normalize.java @@ -40,6 +40,6 @@ public class Normalize implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - return template.getEncoder().encode(RenderUtils.normalize(template.getValueOrAttribute(differentiator))); + return RenderUtils.normalize(template.getValueOrAttribute(differentiator)); } } diff --git a/lib/src/main/java/rife/render/RenderUtils.java b/lib/src/main/java/rife/render/RenderUtils.java index 139d17f..e9fbe3c 100644 --- a/lib/src/main/java/rife/render/RenderUtils.java +++ b/lib/src/main/java/rife/render/RenderUtils.java @@ -21,7 +21,6 @@ import rife.tools.Localization; import rife.tools.StringUtils; import java.io.IOException; -import java.io.StringReader; import java.net.HttpURLConnection; import java.net.URL; import java.nio.charset.StandardCharsets; @@ -40,11 +39,6 @@ import java.util.concurrent.TimeUnit; * @since 1.0 */ public final class RenderUtils { - /** - * The encoding property. - */ - public static final String ENCODING_PROPERTY = "encoding"; - /** * ISO 8601 date formatter. * @@ -88,12 +82,12 @@ public final class RenderUtils { } /** - * Abbreviates a {@code String} to the given length using a replacement marker. + * Abbreviates a String to the given length using a replacement marker. * - * @param src the source {@code String} - * @param max the maximum length of the resulting {@code String} - * @param marker the {@code String} used as a replacement marker - * @return the abbreviated {@code String} + * @param src the source String + * @param max the maximum length of the resulting String + * @param marker the String used as a replacement marker + * @return the abbreviated String */ public static String abbreviate(String src, int max, String marker) { if (src == null || src.isBlank() || marker == null) { @@ -112,7 +106,7 @@ public final class RenderUtils { /** * Returns the Swatch Internet (.beat) Time for the give date-time. * - * @param zonedDateTime the date and time + * @param zonedDateTime the date and time. * @return the .beat time. (eg.: {@code @248}) */ public static String beatTime(ZonedDateTime zonedDateTime) { @@ -123,59 +117,23 @@ public final class RenderUtils { } /** - *Encodes the source {@code String} to the specified encoding.
+ * Capitalizes a String. * - *The supported encodings are:
- * - *Shortens a URL using is.gid.
* - *The URL {@code String} must be a valid http or https URL.
+ *The URL String must be a valid http or https URL.
* *Based on isgd-shorten
* @@ -448,8 +384,8 @@ public final class RenderUtils { /** * Swaps the case of a String. * - * @param src the {@code String} to swap the case of - * @return the modified {@code String} or null + * @param src the String to swap the case of + * @return the modified String or null */ @SuppressWarnings("PMD.AvoidReassigningLoopVariables") public static String swapCase(String src) { @@ -477,6 +413,19 @@ public final class RenderUtils { return new String(buff, 0, offset); } + /** + * Uncapitalizes a String. + * + * @param src the source String + * @return the uncapitalized String + */ + public static String uncapitalize(String src) { + if (src == null || src.isBlank()) { + return src; + } + return src.substring(0, 1).toLowerCase(Localization.getLocale()) + src.substring(1); + } + /** *Returns the formatted server uptime.
* @@ -499,7 +448,7 @@ public final class RenderUtils { * * @param uptime the uptime in milliseconds * @param properties the format properties - * @return the formatted uptime + * @return the formatted uptime. */ @SuppressWarnings("UnnecessaryUnicodeEscape") public static String uptime(long uptime, Properties properties) { @@ -551,7 +500,7 @@ public final class RenderUtils { * Validates a credit card number using the Luhn algorithm. * * @param cc the credit card number - * @return {@code true} if the credit card number is valid + * @return {@code trude} if the credit card number is valid */ public static boolean validateCreditCard(String cc) { try { @@ -584,5 +533,4 @@ public final class RenderUtils { } return false; } - } \ No newline at end of file diff --git a/lib/src/main/java/rife/render/Rot13.java b/lib/src/main/java/rife/render/Rot13.java index d3a33c4..4bca6db 100644 --- a/lib/src/main/java/rife/render/Rot13.java +++ b/lib/src/main/java/rife/render/Rot13.java @@ -40,6 +40,6 @@ public class Rot13 implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - return template.getEncoder().encode(RenderUtils.rot13(template.getValueOrAttribute(differentiator))); + return RenderUtils.rot13(template.getValueOrAttribute(differentiator)); } } diff --git a/lib/src/main/java/rife/render/ShortenUrl.java b/lib/src/main/java/rife/render/ShortenUrl.java index 3ddd62e..b52c686 100644 --- a/lib/src/main/java/rife/render/ShortenUrl.java +++ b/lib/src/main/java/rife/render/ShortenUrl.java @@ -42,6 +42,6 @@ public class ShortenUrl implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - return template.getEncoder().encode(RenderUtils.shortenUrl(template.getValueOrAttribute(differentiator))); + return RenderUtils.shortenUrl(template.getValueOrAttribute(differentiator)); } } diff --git a/lib/src/main/java/rife/render/SwapCase.java b/lib/src/main/java/rife/render/SwapCase.java index c059a6a..270f1f6 100644 --- a/lib/src/main/java/rife/render/SwapCase.java +++ b/lib/src/main/java/rife/render/SwapCase.java @@ -41,6 +41,6 @@ public class SwapCase implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - return template.getEncoder().encode(RenderUtils.swapCase(template.getValueOrAttribute(differentiator))); + return RenderUtils.swapCase(template.getValueOrAttribute(differentiator)); } } diff --git a/lib/src/main/java/rife/render/TimeIso.java b/lib/src/main/java/rife/render/TimeIso.java index 9f99269..e1f0023 100644 --- a/lib/src/main/java/rife/render/TimeIso.java +++ b/lib/src/main/java/rife/render/TimeIso.java @@ -42,6 +42,6 @@ public class TimeIso implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - return template.getEncoder().encode(ZonedDateTime.now().format(RenderUtils.ISO_8601_TIME_FORMATTER)); + return ZonedDateTime.now().format(RenderUtils.ISO_8601_TIME_FORMATTER); } } diff --git a/lib/src/main/java/rife/render/Trim.java b/lib/src/main/java/rife/render/Trim.java index fb97e31..53a66e1 100644 --- a/lib/src/main/java/rife/render/Trim.java +++ b/lib/src/main/java/rife/render/Trim.java @@ -44,6 +44,6 @@ public class Trim implements ValueRenderer { if (value == null || value.isEmpty()) { return value; } - return template.getEncoder().encode(value.trim()); + return value.trim(); } } diff --git a/lib/src/main/java/rife/render/Uncapitalize.java b/lib/src/main/java/rife/render/Uncapitalize.java index bef0dfe..1e670a7 100644 --- a/lib/src/main/java/rife/render/Uncapitalize.java +++ b/lib/src/main/java/rife/render/Uncapitalize.java @@ -19,7 +19,6 @@ package rife.render; import rife.template.Template; import rife.template.ValueRenderer; -import rife.tools.StringUtils; /** *Un-capitalizes a template value.
@@ -41,6 +40,6 @@ public class Uncapitalize implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - return template.getEncoder().encode(StringUtils.uncapitalize(template.getValueOrAttribute(differentiator))); + return RenderUtils.uncapitalize(template.getValueOrAttribute(differentiator)); } } diff --git a/lib/src/main/java/rife/render/Uppercase.java b/lib/src/main/java/rife/render/Uppercase.java index 47a7eb5..bb45bb7 100644 --- a/lib/src/main/java/rife/render/Uppercase.java +++ b/lib/src/main/java/rife/render/Uppercase.java @@ -45,6 +45,6 @@ public class Uppercase implements ValueRenderer { if (value == null || value.isBlank()) { return value; } - return template.getEncoder().encode(value.toUpperCase(Localization.getLocale())); + return value.toUpperCase(Localization.getLocale()); } } diff --git a/lib/src/main/java/rife/render/Uptime.java b/lib/src/main/java/rife/render/Uptime.java index 0353e6c..06b1371 100644 --- a/lib/src/main/java/rife/render/Uptime.java +++ b/lib/src/main/java/rife/render/Uptime.java @@ -55,13 +55,10 @@ public class Uptime implements ValueRenderer { } } - String uptime; if (template.hasAttribute(Uptime.class.getName())) { - uptime = RenderUtils.uptime((long) template.getAttribute(Uptime.class.getName()), properties); + return RenderUtils.uptime((long) template.getAttribute(Uptime.class.getName()), properties); } else { - uptime = RenderUtils.uptime(ManagementFactory.getRuntimeMXBean().getUptime(), properties); + return RenderUtils.uptime(ManagementFactory.getRuntimeMXBean().getUptime(), properties); } - - return template.getEncoder().encode(uptime); } } diff --git a/lib/src/main/java/rife/render/Year.java b/lib/src/main/java/rife/render/Year.java index c7fe2e3..d146738 100644 --- a/lib/src/main/java/rife/render/Year.java +++ b/lib/src/main/java/rife/render/Year.java @@ -43,6 +43,6 @@ public class Year implements ValueRenderer { */ @Override public String render(Template template, String valueId, String differentiator) { - return template.getEncoder().encode(ZonedDateTime.now().format(RenderUtils.ISO_8601_YEAR_FORMATTER)); + return ZonedDateTime.now().format(RenderUtils.ISO_8601_YEAR_FORMATTER); } } diff --git a/lib/src/test/java/rife/render/TestEncode.java b/lib/src/test/java/rife/render/TestEncode.java index 251b046..c5bc8bd 100644 --- a/lib/src/test/java/rife/render/TestEncode.java +++ b/lib/src/test/java/rife/render/TestEncode.java @@ -28,10 +28,6 @@ class TestEncode { var t = TemplateFactory.TXT.get("encodeBase64"); t.setValue(TestCase.FOO, TestCase.SAMPLE_TEXT); assertThat(t.getContent()).isEqualTo(t.getValue(TestCase.FOO) + ": VGhpcyBpcyBhIHRlc3Qu"); - - t = TemplateFactory.HTML.get("encodeBase64"); - t.setValue(TestCase.FOO, TestCase.SAMPLE_TEXT + " URL Encoded."); - assertThat(t.getContent()).as("with URL encoding").contains("VGhpcyBpcyBhIHRlc3QuIFVSTCBFbmNvZGVkLg%3D%3D"); } @Test @@ -54,11 +50,6 @@ class TestEncode { var t = TemplateFactory.TXT.get("encodeJs"); t.setAttribute(TestCase.FOO, "'\"\\/"); assertThat(t.getContent()).isEqualTo("\\'\\\"\\\\\\/"); - - t = TemplateFactory.HTML.get("encodeJs"); - t.setAttribute(TestCase.FOO, '"' + TestCase.SAMPLE_TEXT + '"'); - assertThat(t.getContent()).as("with unicode") - .isEqualTo("\\u005C\\u0022\\u0054\\u0068\\u0069\\u0073\\u0020\\u0069\\u0073\\u0020\\u0061\\u0020\\u0074\\u0065\\u0073\\u0074\\u002E\\u005C\\u0022"); } @Test @@ -66,10 +57,6 @@ class TestEncode { var t = TemplateFactory.JSON.get("encodeJson"); t.setAttribute(TestCase.FOO, "This is a \"•test\""); assertThat(t.getContent()).isEqualTo("{\n \"foo\": \"This is a \\\"\\u2022test\\\"\"\n}"); - - t = TemplateFactory.HTML.get("encodeJson"); - t.setAttribute(TestCase.FOO, "\"