1
0
Fork 0
mirror of https://github.com/ethauvin/version-processor.git synced 2025-04-24 23:47:11 -07:00

Added try-with-resources whenever applicable.

This commit is contained in:
Erik C. Thauvin 2016-01-17 11:20:26 -08:00
parent 5e5a8ce059
commit 83ecfe37a7

View file

@ -48,12 +48,12 @@ public class VersionProcessor extends AbstractProcessor {
if (versionValue != null) { if (versionValue != null) {
log("Version value found: " + versionValue); log("Version value found: " + versionValue);
jfo = filer.createSourceFile(packageName + ".GeneratedVersion"); jfo = filer.createSourceFile(packageName + ".GeneratedVersion");
BufferedWriter writer = new BufferedWriter(jfo.openWriter()); try (BufferedWriter writer = new BufferedWriter(jfo.openWriter())) {
writer.write("package " + packageName + ";\n\n"); writer.write("package " + packageName + ";\n\n");
writer.write("public class GeneratedVersion {\n"); writer.write("public class GeneratedVersion {\n");
writer.write(" public static final String VERSION = \"" + versionValue + "\";\n"); writer.write(" public static final String VERSION = \"" + versionValue + "\";\n");
writer.write("}\n"); writer.write("}\n");
writer.close(); }
log("Generated " + jfo.getName()); log("Generated " + jfo.getName());
} else { } else {
error("Need to specify either @Version(value) or @Version(fileName)"); error("Need to specify either @Version(value) or @Version(fileName)");
@ -79,11 +79,10 @@ public class VersionProcessor extends AbstractProcessor {
if (f.exists()) { if (f.exists()) {
log("Found " + f); log("Found " + f);
Properties p = new Properties(); Properties p = new Properties();
FileReader r = new FileReader(f); try (FileReader r = new FileReader(f)) {
p.load(r); p.load(r);
String result = p.getProperty(version.propertyName()); return p.getProperty(version.propertyName());
r.close(); }
return result;
} else { } else {
error("Couldn't find " + version.fileName()); error("Couldn't find " + version.fileName());
} }