rife2/bld
rife2/bld
2
0
Fork 0
mirror of https://github.com/ethauvin/bld.git synced 2025-04-25 00:07:12 -07:00
Code Activity

Revert "Fixed excessive String concatenations in loop"

Browse source 
This reverts commit 7009e54c71.
This commit is contained in:
Geert Bevin 2023-10-10 11:55:38 -04:00
parent 400bb13532
commit f53c73c9d5
1 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/main/java/rife/bld/operations/AbstractCreateOperation.java
View file

@ -220,17 +220,13 @@ public abstract class AbstractCreateOperation<T extends AbstractCreateOperation<
for (var entry : project_.dependencies().entrySet()) {
build_template.blankValue("dependencies");
var version_string = new StringBuilder(0);
for (var dependency : entry.getValue()) {
build_template.setValue("groupId", dependency.groupId());
build_template.setValue("artifactId", dependency.artifactId());
var version = dependency.version();
version_string.setLength(0);
version_string.append(version.major()).append(',')
.append(version.minor()).append(',')
.append(version.revision());
var version_string = version.major() + "," + version.minor() + "," + version.revision();
if (!version.qualifier().isEmpty()) {
version_string.append(",\"" ).append(version.qualifier()).append('"');
version_string += ",\"" + version.qualifier() + "\"";
}
build_template.setValue("version", version_string);
build_template.appendBlock("dependencies", "dependency");